Received-SPF: pass (google.com: domain of linux-kernel+bounces-80540-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ab237d0e08b6919d29f25d89ec34d149341f4c57.camel@codeconstruct.com.au>
Subject: Re: [PATCH v1 10/14] serial: 8250_of: Switch to use
 uart_read_port_properties()
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thomas Gleixner
 <tglx@linutronix.de>, linux-kernel@vger.kernel.org, 
 linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
 linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, 
 linux-mips@vger.kernel.org, linux-tegra@vger.kernel.org, Jiri Slaby
 <jirislaby@kernel.org>, Joel Stanley <joel@jms.id.au>, Florian Fainelli
 <florian.fainelli@broadcom.com>, Ray Jui <rjui@broadcom.com>, Scott Branden
 <sbranden@broadcom.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, Al Cooper <alcooperx@gmail.com>, 
 Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>, Paul
 Cercueil <paul@crapouillou.net>,  Vladimir Zapolskiy <vz@mleia.com>,
 Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter
 <jonathanh@nvidia.com>, Kunihiko Hayashi <hayashi.kunihiko@socionext.com>, 
 Masami Hiramatsu <mhiramat@kernel.org>, Andi Shyti
 <andi.shyti@linux.intel.com>
Date: Mon, 26 Feb 2024 14:42:27 +1030
In-Reply-To: <Zdd6lnXwvpPPUhRR@smile.fi.intel.com>
References: <20240221183442.4124354-1-andriy.shevchenko@linux.intel.com>
	 <20240221183442.4124354-11-andriy.shevchenko@linux.intel.com>
	 <0a828f2c50de712940fb9a881702ac1678a35b7c.camel@codeconstruct.com.au>
	 <ZddKzHplwOX7naLv@smile.fi.intel.com> <Zdd5m2xIPlGI0_Qv@smile.fi.intel.com>
	 <Zdd6lnXwvpPPUhRR@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-02-22 at 18:47 +0200, Andy Shevchenko wrote:
> On Thu, Feb 22, 2024 at 06:43:08PM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 22, 2024 at 03:23:24PM +0200, Andy Shevchenko wrote:
> > > On Thu, Feb 22, 2024 at 11:07:05AM +1030, Andrew Jeffery wrote:
> > > > On Wed, 2024-02-21 at 20:31 +0200, Andy Shevchenko wrote:
> > > > > Since we have now a common helper to read port properties
> > > > > use it instead of sparse home grown solution.
> > > >=20
> > > > I did some brief testing of the series for the Aspeed machines unde=
r
> > > > qemu, building them on top of v6.8-rc5:
> > > >=20
> > > > export ARCH=3Darm
> > > > export CROSS_COMPILE=3Darm-linux-gnueabihf-
> > > > make aspeed_g5_defconfig
> > > > make -j$(nproc)
> > > > qemu-system-arm -M rainier-bmc -nographic -no-reboot -kernel arch/a=
rm/boot/zImage -dtb arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dtb -in=
itrd ...
> > > >=20
> > > > I got an oops during boot, which bisected to this change:
> > >=20
> > > Thank you for prompt testing! I will look at it.
> >=20
> > I found the issue, will be fixed in next version.
>=20
> Whoever is going to test this series, the
>=20
> -		port->iotype =3D use_defaults ? UPIO_MEM : port->iotype;
> +		port->iotype =3D UPIO_MEM;
>=20
> should be applied to uart_read_port_properties() implementation.
>=20

Thanks, with that fix applied it works fine for me also.

Andrew