Received-SPF: pass (google.com: domain of linux-kernel+bounces-80593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <06d494bc-e649-4ff1-9c05-967d1f5c0727@amd.com>
Date: Mon, 26 Feb 2024 12:02:41 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] ASoC: amd: simplify soundwire dependencies for legacy
 stack
To: Mark Brown <broonie@kernel.org>
Cc: Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
 Mario.Limonciello@amd.com, arnd@arndb.de, Liam Girdwood
 <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
 Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
 Lucas Tanure <lucas.tanure@collabora.com>,
 Syed Saba Kareem <Syed.SabaKareem@amd.com>,
 Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
 "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..."
 <linux-sound@vger.kernel.org>, open list <linux-kernel@vger.kernel.org>,
 Venkata prasad Potturu <venkataprasad.potturu@amd.com>
References: <20240226062853.2100457-1-Vijendar.Mukunda@amd.com>
Content-Language: en-US
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <20240226062853.2100457-1-Vijendar.Mukunda@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UnAzUlg0N1B2dTkvbGtQMWFScFA4VlBGUWdtQ2U1dERLRHV4VnV5UFBvZlNL?=
 =?utf-8?B?WDNadm9EczdkZ0dNRWcra3pCRzNqSVVuK0E3SWZtWGRzL2kvWERGakF4Q1NW?=
 =?utf-8?B?aEtYb0hvRDZLWnYyUmpNdU9RdzNEYlJtSm5pYlVsSnBpTmJkZ1R0STBLZ3JB?=
 =?utf-8?B?OWp1a1J2ZGhMOGtCbGZmWkNmWkhaVXNYVGlLSEVoTEh6Qm5DQTg1dWpzakZw?=
 =?utf-8?B?aHJvY2N4ZjZKSXloMTFvWWZxT1dOU0tIVG11b3daQm9ieTlJQVZsUEVlMnA4?=
 =?utf-8?B?d2llQVlsU0xmNUhGNnY3WEtuVkpyUDAxY1FmWGczK0dLczg4Y1g1ei9HSjhy?=
 =?utf-8?B?c05OSjd6U1h6aWQ5enRHeGFJRVZtN3g0dUFrSVRHemtpVml4RTJrVW0vdGFa?=
 =?utf-8?B?SmFXSFE4b2R5b0ZmYnhRT05MRWhXSG9kRWR4c2FSWnR1TEtYbDJaaUNvNk5i?=
 =?utf-8?B?Z0I5SjB6aGRUU3dVeEljbHEwWWQzL2pvMGw1bVBwMURrOTJFV2JRVHFQYlFJ?=
 =?utf-8?B?NU1HcGphM3E2cHJ2Nnoxa09rZFpCRjJXV2FsbENLVngrSFgyZGcxenpBeDJm?=
 =?utf-8?B?enZiTHlXSTVqdy9wSW8vclowbmxWVzZMbkVXS0lRMVpGRUp0TUFkc3BkdHph?=
 =?utf-8?B?TEhyTjdYNlZ6aGhidWVxTHZSeHlkRFhxR2RxajcwbjByRzQ2VXFhV1FqOGpn?=
 =?utf-8?B?Mk9FQndTSnhWYVJHVUlOU3pweFk3UkhHTDg0REkxY1BsM3FMTTZrSWNpVDIy?=
 =?utf-8?B?MUQ4dWhLWkxXV2h2Qjh6Qzl6L3U4QlIwYk8vSDhYdU53eUVGWm1oUU5XK1lE?=
 =?utf-8?B?c01FSzM1bEcxcm5uNHFoV3VaSExUZ3VsK2RJQWQzeldKZEF4NkVUeDVVUnYv?=
 =?utf-8?B?VkVMTVM2OVl4aW5xcnUyNGlCTkVXYVdrRWI2NzZRcEliUWx3Qk5sQWYxNTFC?=
 =?utf-8?B?VWQ1SFBxSUJJZ3NoTFIvL3JYUlNHVTRTMENWaWovejZtbkh4MWlCMHpnTmlO?=
 =?utf-8?B?WEdIWEp5ZG9HZ3V6STg4SDN3Qkd5c2NZMlU0UnY2WHB2eG1kSGtEdVJKKzNa?=
 =?utf-8?B?a1JDd1RtR1dEL3Rkb2VNNU9aaFJTU3BTRjhzL2RHRFl6cGFGUEo0YW90eGVN?=
 =?utf-8?B?Nlc4ZlVQYTRWN0VvMmFnV3lvdnlLZ3dUTUh0UENwRUwvQi9FdEExaVZQL3RK?=
 =?utf-8?B?dzhaSTRDRmI1T3Y5emhZTjE1QUYyUE9NcmtxYldwV2RWREJ2OStNTFVFRUNC?=
 =?utf-8?B?bzAzN0o2RHZqc3ljUmE3UjRUMDYwZzRJZXRQM1F3T1FGRFh3eTRaSnBXeENN?=
 =?utf-8?B?Sm05bmdTa3VxTU42WjVVSGd1NEE0Ylg4NU51S3RTTGw4ZWI0ZHp0UGh2QWNi?=
 =?utf-8?B?ZTd0OGNld0hMYVcrbCtYVWdpQUpnMThGZzhxVmNGZmNka0NKQzVvZlJ4TDhh?=
 =?utf-8?B?WXFHZy83QStMbXB1dGM3bXMrZFEySy93aWU0RzBRTDJQRlFaUEJhUStjRWtZ?=
 =?utf-8?B?a1FVckhtYnRQZ3NGc1pocEdpemNzeHVMaW1hODR5UER1ckNvT1ppVmRLa05W?=
 =?utf-8?B?Rm1ISEhteFZkdzFuTGNVSW5OOXQ1TUxKQUFMUERCMk9CajlidkZENmhxQ3o5?=
 =?utf-8?B?ZlV0TGFEdmR6TWRjaGdvTVR1MExabnQ5TStZU3VCQWwydW44czZiYVNkLytl?=
 =?utf-8?B?VUFYdTRqQzhUZzV6QkVrSkdHZXZSUzlGUk4xc0w0SHEvQkl4L1R3SVk2L1NL?=
 =?utf-8?B?cjBBQklDT2dzYUM1OVRuaFlxV3FlSnJMYVlnVVh5V0htL2hBYThQQ1dtdHFk?=
 =?utf-8?B?d09JQU0wVmZUQkdLN2N6UE9vc0ZpWVpxeDdlSUtZSFU3YWpNeGNlMXZ5QkF4?=
 =?utf-8?B?RjhNSzdUbTVIL0kvM3duZFJRR1NhS1ExVnFiei9ieVZ4cFlJVmxrVkxVN0o3?=
 =?utf-8?B?M2ZjWTJVcW0rcWZxd3ZkN1dadTdZaXlCNGkzVEFHaGhGcHRhSDhVSVRabW5E?=
 =?utf-8?B?Z2hiRUFsc09RTXNkQUN5WjYwM2U0WVl2T2VHQitIMmdrTS9VdzBub29JNVQx?=
 =?utf-8?B?TDlKaWFJSUdXZlRHQ0w0ZkxvSVdpbCtSYmV4MUp6Y0toUnNjcTVYM2YybXRo?=
 =?utf-8?Q?8WcRxTvJ4+g3a6biaw0vtuef6?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 030db1db-acd6-4892-9655-08dc3694c22b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 06:32:52.5769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mpDu8YhJgg6hK5PJRb+pjrA5YVIXkOpZMjOE/Q7qfg/WSa/EB2lMwW1Zh8ghOwVLFaXXFNcujczBQ8IaeX+Log==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6872

On 26/02/24 11:58, Vijendar Mukunda wrote:
> The CONFIG_SOUNDWIRE_AMD is a user-visible option, it should be never
> selected by another driver.
> So replace the extra complexity with a normal Kconfig dependency in
> SND_SOC_AMD_SOUNDWIRE.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
>  sound/soc/amd/Kconfig | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index fa74635cee08..3508f5a96b75 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -134,15 +134,14 @@ config SND_SOC_AMD_RPL_ACP6x
>  
>  config SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
>  	tristate
> -	select SOUNDWIRE_AMD if SND_SOC_AMD_SOUNDWIRE != n
>  	select SND_AMD_SOUNDWIRE_ACPI if ACPI
>  
>  config SND_SOC_AMD_SOUNDWIRE
>  	tristate "Support for SoundWire based AMD platforms"
>  	default SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
>  	depends on SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
> -	depends on ACPI && SOUNDWIRE
> -	depends on !(SOUNDWIRE=m && SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE=y)
> +	depends on ACPI
> +	depends on SOUNDWIRE_AMD
>  	help
>  	  This adds support for SoundWire for AMD platforms.
>  	  Say Y if you want to enable SoundWire links with SOF.