Received-SPF: pass (google.com: domain of linux-kernel+bounces-80601-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 26 Feb 2024 07:44:40 +0100
From: Michal Kubecek <mkubecek@suse.cz>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Lennart Franzen <lennart@lfdomain.com>,
	Alexandru Tachici <alexandru.tachici@analog.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: adi: requires PHYLIB support
Message-ID: <20240226064440.ismpxvp5qmnskyna@lion.mk-sys.cz>
References: <20240215070050.2389-1-rdunlap@infradead.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="dokggcunvhr5bb4x"
Content-Disposition: inline
In-Reply-To: <20240215070050.2389-1-rdunlap@infradead.org>


--dokggcunvhr5bb4x
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 14, 2024 at 11:00:50PM -0800, Randy Dunlap wrote:
> This driver uses functions that are supplied by the Kconfig symbol
> PHYLIB, so select it to ensure that they are built as needed.
>=20
> When CONFIG_ADIN1110=3Dy and CONFIG_PHYLIB=3Dm, there are multiple build
> (linker) errors that are resolved by this Kconfig change:
>=20
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_net_ope=
n':
>    drivers/net/ethernet/adi/adin1110.c:933: undefined reference to `phy_s=
tart'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_probe_n=
etdevs':
>    drivers/net/ethernet/adi/adin1110.c:1603: undefined reference to `get_=
phy_device'
>    ld: drivers/net/ethernet/adi/adin1110.c:1609: undefined reference to `=
phy_connect'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_disconn=
ect_phy':
>    drivers/net/ethernet/adi/adin1110.c:1226: undefined reference to `phy_=
disconnect'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `devm_mdiobus_all=
oc':
>    include/linux/phy.h:455: undefined reference to `devm_mdiobus_alloc_si=
ze'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_registe=
r_mdiobus':
>    drivers/net/ethernet/adi/adin1110.c:529: undefined reference to `__dev=
m_mdiobus_register'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_net_sto=
p':
>    drivers/net/ethernet/adi/adin1110.c:958: undefined reference to `phy_s=
top'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_disconn=
ect_phy':
>    drivers/net/ethernet/adi/adin1110.c:1226: undefined reference to `phy_=
disconnect'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_adjust_=
link':
>    drivers/net/ethernet/adi/adin1110.c:1077: undefined reference to `phy_=
print_status'
>    ld: drivers/net/ethernet/adi/adin1110.o: in function `adin1110_ioctl':
>    drivers/net/ethernet/adi/adin1110.c:790: undefined reference to `phy_d=
o_ioctl'
>    ld: drivers/net/ethernet/adi/adin1110.o:(.rodata+0xf60): undefined ref=
erence to `phy_ethtool_get_link_ksettings'
>    ld: drivers/net/ethernet/adi/adin1110.o:(.rodata+0xf68): undefined ref=
erence to `phy_ethtool_set_link_ksettings'
>=20
> Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402070626.eZsfVHG5-lkp@i=
ntel.com/
> Cc: Lennart Franzen <lennart@lfdomain.com>
> Cc: Alexandru Tachici <alexandru.tachici@analog.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> ---
>  drivers/net/ethernet/adi/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>=20
> diff -- a/drivers/net/ethernet/adi/Kconfig b/drivers/net/ethernet/adi/Kco=
nfig
> --- a/drivers/net/ethernet/adi/Kconfig
> +++ b/drivers/net/ethernet/adi/Kconfig
> @@ -7,6 +7,7 @@ config NET_VENDOR_ADI
>  	bool "Analog Devices devices"
>  	default y
>  	depends on SPI
> +	select PHYLIB
>  	help
>  	  If you have a network (Ethernet) card belonging to this class, say Y.

Shouldn't the "select PHYLIB" be added to ADIN1110 rather than
NET_VENDOR_ADI? Now with v6.8-rc6, PHYLIB and few other options are
forced to "Y" whenever NET_VENDOR_ADI is enabled (even with ADIN1110
disabled).

Michal

--dokggcunvhr5bb4x
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAmXcM1MACgkQ538sG/LR
dpWWyQf+IwV1bbDi03xWEPWF9NbDjKpBv4a2Lg5jNjnCa+k3kW3DNzThJTedzX5F
ROmPLIj1cH4cKnaK++npbAlv8K4rZXlvibJDDrXHzNi67IuoExFy1foTyfx8Kr/1
fImb56B2WQXW4SrlHPXi8dB8CDIqlu+z3ec1eG0DEKYBM1WbVP9LKNA/FjNVi0pX
ktr2s2tv2CgZ/4m3+/cPvxQIhiQYFjdfeiXmWaEcfjxgqZRoyGOqqqrCylHk2mIG
0auC4nBbvEkFZqE9p4iPgFQ4IoMf8bnFtNMOawmx/DoDuj3QbgGEKBdDvDbdlRVn
/z0uBAhXH5yRjGpd9XHPDcV2JZthLQ==
=wmo4
-----END PGP SIGNATURE-----

--dokggcunvhr5bb4x--