Received-SPF: pass (google.com: domain of linux-kernel+bounces-80615-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240225151209.343160-1-alexander.stein@mailbox.org>
In-Reply-To: <20240225151209.343160-1-alexander.stein@mailbox.org>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Mon, 26 Feb 2024 16:02:57 +0900
Message-ID: <CAK7LNARxfhYm9WyDH-S0PT7Mb5Tj5tmbqGLs9NzNxzsi1_4OQw@mail.gmail.com>
Subject: Re: [PATCH 1/1] kbuild: Add DT schema check also when applying DT overlays
To: Alexander Stein <alexander.stein@mailbox.org>, Rob Herring <robh+dt@kernel.org>, 
	DTML <devicetree@vger.kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, linux-kbuild@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

+ Rob Herring, DT List


On Mon, Feb 26, 2024 at 12:12=E2=80=AFAM Alexander Stein
<alexander.stein@mailbox.org> wrote:
>
> Add a similar mechanism as for regular DT files to call the DT checker
> after applying DT overlays to base DT files.
>
> Signed-off-by: Alexander Stein <alexander.stein@mailbox.org>
> ---
> I'm unsure if this is the "right" way, or if the multi-dtb-y lines
> should be moved. But checking for schemas in DT overlays is a nice thing.


There is no need to move the multi-dtb-y line.


>  scripts/Makefile.lib | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 038a12e15586..964892b18f95 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -406,10 +406,6 @@ cmd_dtc =3D $(HOSTCC) -E $(dtc_cpp_flags) -x assembl=
er-with-cpp -o $(dtc-tmp) $< ;
>  quiet_cmd_fdtoverlay =3D DTOVL   $@
>        cmd_fdtoverlay =3D $(objtree)/scripts/dtc/fdtoverlay -o $@ -i $(re=
al-prereqs)
>
> -$(multi-dtb-y): FORCE
> -       $(call if_changed,fdtoverlay)
> -$(call multi_depend, $(multi-dtb-y), .dtb, -dtbs)
> -
>  ifneq ($(CHECK_DTBS)$(CHECK_DT_BINDING),)
>  DT_CHECKER ?=3D dt-validate
>  DT_CHECKER_FLAGS ?=3D $(if $(DT_SCHEMA_FILES),-l $(DT_SCHEMA_FILES),-m)
> @@ -418,9 +414,13 @@ DT_TMP_SCHEMA :=3D $(objtree)/$(DT_BINDING_DIR)/proc=
essed-schema.json
>
>  quiet_cmd_dtb =3D        DTC_CHK $@
>        cmd_dtb =3D        $(cmd_dtc) ; $(DT_CHECKER) $(DT_CHECKER_FLAGS) =
-u $(srctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ || true
> +quiet_cmd_dtbo =3D DTOVL_CHK $@
> +      cmd_dtbo =3D $(cmd_fdtoverlay) ; $(DT_CHECKER) $(DT_CHECKER_FLAGS)=
 -u $(srctree)/$(DT_BINDING_DIR) -p $(DT_TMP_SCHEMA) $@ || true
>  else
>  quiet_cmd_dtb =3D $(quiet_cmd_dtc)
>        cmd_dtb =3D $(cmd_dtc)
> +quiet_cmd_dtbo =3D $(quiet_cmd_fdtoverlay)
> +      cmd_dtbo =3D $(cmd_fdtoverlay)
>  endif
>
>  $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> @@ -429,6 +429,10 @@ $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) F=
ORCE
>  $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>         $(call if_changed_dep,dtc)
>
> +$(multi-dtb-y): FORCE
> +       $(call if_changed,dtbo)
> +$(call multi_depend, $(multi-dtb-y), .dtb, -dtbs)
> +
>  dtc-tmp =3D $(subst $(comma),_,$(dot-target).dts.tmp)
>
>  # Bzip2
> --
> 2.44.0
>


--=20
Best Regards
Masahiro Yamada