Received-SPF: pass (google.com: domain of linux-kernel+bounces-80719-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 26 Feb 2024 10:03:02 +0200
From: Oded Gabbay <ogabbay@kernel.org>
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] accel: constify the struct device_type usage
Message-ID: <ZdxFtvl6C/k71nbZ@ogabbay-vm-u22.habana-labs.com>
References: <20240219-device_cleanup-accel-v1-1-5031e5046cff@marliere.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240219-device_cleanup-accel-v1-1-5031e5046cff@marliere.net>

On Mon, Feb 19, 2024 at 04:48:28PM -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the
> accel_sysfs_device_minor variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  drivers/accel/drm_accel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accel/drm_accel.c b/drivers/accel/drm_accel.c
> index 24cac4c0274b..16c3edb8c46e 100644
> --- a/drivers/accel/drm_accel.c
> +++ b/drivers/accel/drm_accel.c
> @@ -23,7 +23,7 @@ static struct idr accel_minors_idr;
>  
>  static struct dentry *accel_debugfs_root;
>  
> -static struct device_type accel_sysfs_device_minor = {
> +static const struct device_type accel_sysfs_device_minor = {
>  	.name = "accel_minor"
>  };
>  
> 
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20240219-device_cleanup-accel-a990dc3bfbc1
> 
> Best regards,
> -- 
> Ricardo B. Marliere <ricardo@marliere.net>
> 
Applied to -next.
Thanks,
Oded