Received-SPF: pass (google.com: domain of linux-kernel+bounces-80725-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
References: <20240201092559.910982-1-yukuai1@huaweicloud.com>
 <Zb2wxIpf7uYV6Vya@bmarzins-01.fast.eng.rdu2.dc.redhat.com>
 <528ce926-6f17-c1ea-8e77-c7d5d7f56022@huaweicloud.com>
 <ZcE4mGXCDwjqBXgf@bmarzins-01.fast.eng.rdu2.dc.redhat.com>
 <1fdbfcf8-1ee9-4079-e84e-6e2c1121491b@huaweicloud.com>
 <ZcGuRIrZJaEtXjPh@bmarzins-01.fast.eng.rdu2.dc.redhat.com>
 <CAPhsuW6arbEmRUK3xG1XVjra3BtSx9_wFe+QKDBbTgb3DgYXig@mail.gmail.com>
 <ZcVhA_IqXH2Pg79t@bmarzins-01.fast.eng.rdu2.dc.redhat.com>
 <CAPhsuW6VqSRUsB2oQ+Hmf-0+2gfKHgN1skvvUwDmqDOxJvEKtA@mail.gmail.com>
User-agent: mu4e 1.7.5; emacs 28.2
From: Su Yue <l@damenly.org>
To: Song Liu <song@kernel.org>
Cc: Benjamin Marzinski <bmarzins@redhat.com>, Yu Kuai
 <yukuai1@huaweicloud.com>, mpatocka@redhat.com, heinzm@redhat.com,
 xni@redhat.com, blazej.kucman@linux.intel.com, agk@redhat.com,
 snitzer@kernel.org, dm-devel@lists.linux.dev, jbrassow@f14.redhat.com,
 neilb@suse.de, shli@fb.com, akpm@osdl.org, linux-kernel@vger.kernel.org,
 linux-raid@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com,
 "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v5 00/14] dm-raid/md/raid: fix v6.7 regressions
Date: Mon, 26 Feb 2024 15:58:02 +0800
In-reply-to: <CAPhsuW6VqSRUsB2oQ+Hmf-0+2gfKHgN1skvvUwDmqDOxJvEKtA@mail.gmail.com>
Message-ID: <34tfodss.fsf@damenly.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable


On Fri 09 Feb 2024 at 14:37, Song Liu <song@kernel.org> wrote:

> On Thu, Feb 8, 2024 at 3:17=E2=80=AFPM Benjamin Marzinski=20
> <bmarzins@redhat.com> wrote:
>>
> [...]
>> >
>> > I am not able to get reliable results from=20
>> > shell/lvconvert-repair-raid.sh
>> > either. For 6.6.0 kernel, the test fails. On 6.8-rc1 kernel,=20
>> > the test fails
>> > sometimes.
>> >
>> > Could you please share more information about your test=20
>> > setup?
>> > Specifically:
>> > 1. Which tree/branch/tag are you testing?
>> > 2. What's the .config used in the tests?
>> > 3. How do you run the test suite? One test at a time, or all=20
>> > of them
>> > together?
>> > 4. How do you handle "test passes sometimes" cases?
>>
>> So, I have been able to recreate the case where=20
>> lvconvert-repair-raid.sh
>> keeps failing. It happens when I tried running the reproducer=20
>> on a virtual
>> machine made using a cloud image, instead of one that I=20
>> manually
>> installed. I'm not sure why there is a difference. But I can=20
>> show you
>> how I can reliably recreate the errors I'm seeing.
>>
>>
>> Create a new Fedora 39 virtual machine with the following=20
>> commands (I'm
>> not sure if it is possible to reproduce this on a machine using=20
>> less
>> memory and cpus, but I can try that if you need me to. You=20
>> probably also
>> want to pick a faster Fedora Mirror for the image location):
>> # virt-install --name repair-test --memory 8192 --vcpus 8=20
>> --disk size=3D40
>> --graphics none --extra-args "console=3DttyS0" --osinfo
>> detect=3Don,name=3Dfedora-unknown --location
>> https://download.fedoraproject.org/pub/fedora/linux/releases/39/Server/x=
86_64/os/
>>
>
> virt-install doesn't work well in the my daily dev server. I=20
> will try on a
> different machine.
>
>> Install to the whole virtual drive, using the default LVM=20
>> partitioning.
>> Then ssh into the VM and run the following commands to setup=20
>> the
>> lvm2-testsuite and 6.6.0 kernel:
>>
> [...]
>
>>
>> Rerun the lvm2-testsuite with the same commands as before:
>>
>> # mount -o remount,dev /tmp
>
> This mount trick helped me run tests without a full image (use
> CONFIG_9P_FS to reuse host file systems instead). Thanks!
>
>> # cd ~/lvm2
>> # make check T=3Dlvconvert-repair-raid.sh
>>
>> This fails about 20% of the time, usually at either line 146 or=20
>> 164. You
>> can check by running the following command when the test fails.
>
> However, I am seeing lvconvert-repair-raid.sh passes all the=20
> time
> with both 6.6 kernel and 6.8+v5 patchset. My host system is
> CentOS 8.
>

shell/lvconvert-repair-raid.sh fails for SLES 15SP5 + upstream=20
lvm2 +
v6.8+v5 patchset but not with v6.6 kernel.

--
Su

> I guess we will have to run more tests.
>
> DM folks, please also review the set. We won't be able to ship=20
> the
> dm changes without your thorough reviews.
>
> Thanks,
> Song