Received-SPF: pass (google.com: domain of linux-kernel+bounces-80758-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\))
Subject: Re: [PATCH] time: Use div64_long() instead of do_div()
From: Thorsten Blum <thorsten.blum@toblux.com>
In-Reply-To: <4bc9df7f-ea00-ad5e-02f0-d4cae6f005ad@huawei.com>
Date: Mon, 26 Feb 2024 09:27:18 +0100
Cc: linux-kernel@vger.kernel.org,
 Thomas Gleixner <tglx@linutronix.de>,
 Anna-Maria Behnsen <anna-maria@linutronix.de>,
 Frederic Weisbecker <frederic@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 John Stultz <jstultz@google.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E2A9A6AE-84F4-4C86-80CA-CC0C480FD9A8@toblux.com>
References: <20240225232541.17659-2-thorsten.blum@toblux.com>
 <4bc9df7f-ea00-ad5e-02f0-d4cae6f005ad@huawei.com>
To: "Liao, Chang" <liaochang1@huawei.com>


> On Feb 26, 2024, at 04:28, Liao, Chang <liaochang1@huawei.com> wrote:
>=20
> I am considering using div64_ul() to calculate the result. as shift_hz =
is
> unsigned long, assume the sign bit of divisor cycles_per_tick never be =
set
> in this context,then div64_long() will do a extra sign extension for =
result.

Yes, div64_ul() is better and also removes the warning.

I'll submit a v2 shortly.

Thanks,
Thorsten=