Received-SPF: pass (google.com: domain of linux-kernel+bounces-80946-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fe89c82c-18e8-4acf-97c7-a319f20c26f4@amd.com>
Date: Mon, 26 Feb 2024 09:45:11 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] clk: clocking-wizard: Remove redundant initialization of
 pointer div_addr
Content-Language: en-US
To: Colin Ian King <colin.i.king@gmail.com>,
 Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
 <sboyd@kernel.org>, linux-clk@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240223134347.3908301-1-colin.i.king@gmail.com>
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <20240223134347.3908301-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OTVaVU9zeDlEa3NBVlA3QVhMNnYyWFd5Nytmdk1Xd1ZLKzZ6Mm5ad0M1bTJM?=
 =?utf-8?B?NktuL2tzWGRGNVNQM3k5U2h5TjhVK21wOTBQK21VamJRd1R4U3NaUnRKU3VP?=
 =?utf-8?B?K1BBY29FdjJHUERIVjMrWnhvVGZYYyttVXk4OG1NeXJEcldYdWMxU3QzT01q?=
 =?utf-8?B?QzV2N2RqN3RDdUVHZVd0KzRmUFRtSk43WjdNSytWallMUGFwTE5jdk9rblN6?=
 =?utf-8?B?VmRSSGZMY0djdDBRUGVrQmdjbDF2RTdJQlY5Vy9ZNkxOU0JMTXllOXU0KzZv?=
 =?utf-8?B?RXErazhLTFZHVVV1Q2ZONytla1dicnFkT0twNFp6NlZCTEpuMTlxU1JndXRC?=
 =?utf-8?B?NzJXZE1EbVJDMzhjQW94UzA3dnZqRHB3czQ3UjVVTm5uR1Ewb0RaZmNyUSt1?=
 =?utf-8?B?eG9QOGE2b3NyU0xuWDhXSDFRdW5CSXVFN2dSdGw2VERmTTNJNlVXSGRtTFFS?=
 =?utf-8?B?eW5iTVN3dVlyVEF0VFRZQ0JsUHIxcVh3c2ZzNWZYU291Q0lXeTNyZ2Y5VDlS?=
 =?utf-8?B?ZXFFd1BuQnVvZEN4VkF2Tis4NUNuUzIzbysyaHNZbThDNlpkUitmdElCTHdE?=
 =?utf-8?B?Q3B5QW5SaHhqSW1Gbmp3ME5lc29WZnA0SWNPVWpRWTN5cEN1a3RUL2VpSEYy?=
 =?utf-8?B?eFBCbHZjWTBranM3blFRUDB5c0d3OVJBQ01qRWRNKy9QZXVEOVdURUpsVzBW?=
 =?utf-8?B?YUlCeE5saFZQN1F1NzFUbzlpUlFtYlNGcC9qb0ZUTUFZNkJXQm1aL1pERjR3?=
 =?utf-8?B?aVBscnBWMmV3N0pvaUpaY04zWnhjdm5hM2pLdmlwT0FpT1B4V1lpM3ZGeVhq?=
 =?utf-8?B?U0tIMWFJL28xSCsrUDlmb1pEMVFoRkJadHA1bmh2eUdJdFgyYVB5eWl5bU1G?=
 =?utf-8?B?dzJqR2Uyd0EyZGYzaUhwRno1bmcxYTlpaHFMTVVKRUpCaDBremV6UDFpeXAr?=
 =?utf-8?B?TXdOZUlzenZuU2h4VFI5Qm42bTdOOXdrTGZYTm1GRG9BQnNoRXVBQmZWSGZM?=
 =?utf-8?B?YWlrN2JwMytCdmRuTldVQmx3Nytrck5TdWNHeDNqandrSTVkWERDbkF3d3pN?=
 =?utf-8?B?S0EwN1FtUmFjWlgxUU9rek9lblhROXlvTVpzejlkK1NoTkJWeGRxdnVGRmJ6?=
 =?utf-8?B?M0hwaGtIZkVia0pQNUdEb2tDWFlIcjJXN09Nbit6STNkb2RObFBJN3paVWdC?=
 =?utf-8?B?UE1YRW04Tm1rcndiYjNZMndkTGV2NUhsTXJtVmMzL0VjdlE2VVM0ZE8waVdw?=
 =?utf-8?B?T2NyajdBRUl3VDMwTENmcy9yNWRqYitYY1ptMG1xWFBmdWZQalZrdVMzaGoz?=
 =?utf-8?B?NENTUUlJM0JxcENxaktyd1Z4Q1JVa2VLaVVPaUY5ejl2Tml2aEVGRHIrMzRk?=
 =?utf-8?B?L3hBSCt3Mk5CbmJPYWFtN2RPVlNPb0I4WGJkMjJrUk1wdkRHNmVRb3BkS1A1?=
 =?utf-8?B?Y1h6Ykw1WHhvaE5kNmF2STZSK0RIblBUb0xMQ1BTVng0Zlk0bnBxWDZobTBJ?=
 =?utf-8?B?WG00VURITmFSUVNKLy80ditpZnlxN255VTVyUVdvaHZ2QXltWTRnNW4vejNk?=
 =?utf-8?B?TVJMVzdhNlB0bHVqdkd5c0ZNTHk3VnN1dCtJdmZpdFptL1dNOFZudEhZaHYz?=
 =?utf-8?B?RDVuUHZwNjA5NWp5cjhZZWVZTTNWdkM3T1REY3Bid3U1WnM4aU10NTU2UkEy?=
 =?utf-8?B?L2J1Mld0SDQvRDRRV0Q2NWFnbXA2blR0KzBxaWdTbkNBb2JRQ3JpUys4MHBY?=
 =?utf-8?B?MjY5dkpQak1DQ3IyMW1vWGx3SnhmdVFKUm9QQ0MyZk5VQTFrL2pXcTBYOGlI?=
 =?utf-8?B?Zk8wM0NFWjc0WWVuV3RXTUF0eHZIY0VXNmlQZ0pCOTVXNkgxWndGb2lxRlpi?=
 =?utf-8?B?RWE0bjAzVlk0emJUMzFaOUtiVUVYZHA5dWVvd3NyM2tjb2s0REtPMFVqczBV?=
 =?utf-8?B?OE5LcEpnQzROOTlaTkJoVWJwWXVubWl2Mk1sYWFvUkRkU3gwODVWL3NxdXUx?=
 =?utf-8?B?bURlMVBrMjlRUFhUc2dhU09WcmJzQW9IRWlrRWxUYWpXYjJOL0ExWGt2UFJN?=
 =?utf-8?B?T2pUZGsvaDV4MXdEQ3lhQUtoeXBlTEg0c2toY2FyVUpaK24zdU1udTIrSjdV?=
 =?utf-8?Q?JoptEB+6sK0+KrPzYYrIicN6k?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e02d57d4-654c-41cf-ce40-08dc36a745fb
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 08:45:24.3740
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2hZO6nC99AtLDWYl8KUushPmJX31RzNDUwGvjONMzraOzMDiIQQSmZyEGvaFD1fi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7254


On 2/23/24 14:43, Colin Ian King wrote:
> The pointer div_addr is being assigned a value that is never used, it is
> being re-assigned a different value near the end of the function where
> it is being read in the next statement. The initialization is redundant
> and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/clk/xilinx/clk-xlnx-clock-wizard.c:501:16: warning: Value stored
> to 'div_addr' during its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   drivers/clk/xilinx/clk-xlnx-clock-wizard.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> index 6a6e5d9292e8..19eb3fb7ae31 100644
> --- a/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> +++ b/drivers/clk/xilinx/clk-xlnx-clock-wizard.c
> @@ -498,7 +498,7 @@ static int clk_wzrd_dynamic_all_nolock(struct clk_hw *hw, unsigned long rate,
>   {
>   	struct clk_wzrd_divider *divider = to_clk_wzrd_divider(hw);
>   	unsigned long vco_freq, rate_div, clockout0_div;
> -	void __iomem *div_addr = divider->base;
> +	void __iomem *div_addr;
>   	u32 reg, pre, f;
>   	int err;
>   

Reviewed-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal