Received-SPF: pass (google.com: domain of linux-kernel+bounces-80982-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <CAGsJ_4zera4+bWuXHKjdU3QdiR3sqcUQB3gF08DPD49OCT4S9w@mail.gmail.com>
 <20240226083714.26187-1-ioworker0@gmail.com> <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com>
In-Reply-To: <9bcf5141-7376-441e-bbe3-779956ef28b9@redhat.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Mon, 26 Feb 2024 16:55:09 +0800
Message-ID: <CAK1f24mdwjz2J5VmeYSDwb4jMbrXUVCSF_0pOcWSVt1cfa0FhQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] mm/madvise: enhance lazyfreeing with mTHP in madvise_free
To: David Hildenbrand <david@redhat.com>
Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, 
	linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, peterx@redhat.com, 
	ryan.roberts@arm.com, shy828301@gmail.com, songmuchun@bytedance.com, 
	wangkefeng.wang@huawei.com, zokeefe@google.com, fengwei.yin@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey David,

Thanks for your suggestion!

On Mon, Feb 26, 2024 at 4:41=E2=80=AFPM David Hildenbrand <david@redhat.com=
> wrote:
>
[...]
> > On Mon, Feb 26, 2024 at 12:00=E2=80=AFPM Barry Song <21cnbao@gmail.com>=
 wrote:
> > [...]
> >> On Mon, Feb 26, 2024 at 1:33=E2=80=AFAM Lance Yang <ioworker0@gmail.co=
m> wrote:
> > [...]
[...]
> > +static inline bool pte_range_cont_mapped(pte_t *pte, unsigned long nr)
> > +{
> > +     pte_t pte_val;
> > +     unsigned long pfn =3D pte_pfn(pte);
> > +     for (int i =3D 0; i < nr; i++) {
> > +             pte_val =3D ptep_get(pte + i);
> > +             if (pte_none(pte_val) || pte_pfn(pte_val) !=3D (pfn + i))
> > +                     return false;
> > +     }
> > +     return true;
> > +}
>
> I dislike the "cont mapped" terminology.
>
> Maybe folio_pte_batch() does what you want?

folio_pte_batch() is a good choice. Appreciate it!

Best,
Lance

>
> --
> Cheers,
>
> David / dhildenb
>