Received-SPF: pass (google.com: domain of linux-kernel+bounces-80983-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <bda53361-d334-411b-8ac1-069d41025804@linux.dev>
Date: Mon, 26 Feb 2024 16:55:01 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] net: remove SLAB_MEM_SPREAD flag usage
Content-Language: en-US
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vbabka@suse.cz,
 Xiongwei.Song@windriver.com
References: <20240224134943.829751-1-chengming.zhou@linux.dev>
From: Chengming Zhou <chengming.zhou@linux.dev>
In-Reply-To: <20240224134943.829751-1-chengming.zhou@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/2/24 21:49, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete explicitly to avoid confusion
for users. Here we can just remove all its users, which has no any
functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!

> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  net/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/socket.c b/net/socket.c
> index ed3df2f749bf..7e9c8fc9a5b4 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -343,7 +343,7 @@ static void init_inodecache(void)
>  					      0,
>  					      (SLAB_HWCACHE_ALIGN |
>  					       SLAB_RECLAIM_ACCOUNT |
> -					       SLAB_MEM_SPREAD | SLAB_ACCOUNT),
> +					       SLAB_ACCOUNT),
>  					      init_once);
>  	BUG_ON(sock_inode_cachep == NULL);
>  }