Received-SPF: pass (google.com: domain of linux-kernel+bounces-80922-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <21ccdf91-19e1-497e-be65-ef2063ea0b7f@xs4all.nl>
Date: Mon, 26 Feb 2024 09:41:14 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] media: dvbdev: export adapter's name and bus ID to
 DVB uevent variables
To: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
 Dan Carpenter <dan.carpenter@linaro.org>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Hyunwoo Kim <imv4bel@gmail.com>, Sakari Ailus
 <sakari.ailus@linux.intel.com>, Zhipeng Lu <alexious@zju.edu.cn>,
 linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
References: <cover.1708422122.git.mchehab@kernel.org>
 <22e1d85d8896681a3f3f9abdc323e634b49fa1fd.1708422122.git.mchehab@kernel.org>
Content-Language: en-US, nl
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
In-Reply-To: <22e1d85d8896681a3f3f9abdc323e634b49fa1fd.1708422122.git.mchehab@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 20/02/2024 10:46, Mauro Carvalho Chehab wrote:
> Add two new variables for uevent, helping udev to be able to setup
> a persistent name for the device.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Regards,

	Hans

> ---
>  drivers/media/dvb-core/dvbdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
> index 733d0bc4b4cc..01227c695cbd 100644
> --- a/drivers/media/dvb-core/dvbdev.c
> +++ b/drivers/media/dvb-core/dvbdev.c
> @@ -1064,6 +1064,8 @@ static int dvb_uevent(const struct device *dev, struct kobj_uevent_env *env)
>  {
>  	const struct dvb_device *dvbdev = dev_get_drvdata(dev);
>  
> +	add_uevent_var(env, "DVB_ADAPTER_NAME=%s", dvbdev->adapter->name);
> +	add_uevent_var(env, "DVB_ADAPTER_PDEV=%s", dev_name(dev->parent));
>  	add_uevent_var(env, "DVB_ADAPTER_NUM=%d", dvbdev->adapter->num);
>  	add_uevent_var(env, "DVB_DEVICE_TYPE=%s", dnames[dvbdev->type]);
>  	add_uevent_var(env, "DVB_DEVICE_NUM=%d", dvbdev->id);