Received-SPF: pass (google.com: domain of linux-kernel+bounces-81051-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 26 Feb 2024 10:28:06 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Shuah Khan <skhan@linuxfoundation.org>
CC: Reinette Chatre <reinette.chatre@intel.com>, <shuah@kernel.org>,
	<fenghua.yu@intel.com>, <linux-kselftest@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in
 Intel CAT selftest
Message-ID: <beuizmgezzcnd3f74nsmigfn7n5emj43pxaqtyki7bjgj4nqn5@ldpqu65vaunu>
References: <cover.1708072203.git.maciej.wieczor-retman@intel.com>
 <f8886683-4f24-47ce-a0c6-ef28466bfec9@intel.com>
 <685828ed-06d2-4a2c-9911-05145e55ea1a@linuxfoundation.org>
 <48dab897-162d-4075-baa9-f5391a23d31d@intel.com>
 <a8f1f104-c5c1-400c-873e-99b01cde1d88@linuxfoundation.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a8f1f104-c5c1-400c-873e-99b01cde1d88@linuxfoundation.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?erhL7wdl0hLN0UnWB6omJnY2QGVUa6mFJM9uUHXW65rQ7hW+OanmOaxsaC?=
 =?iso-8859-1?Q?j46gtD481prL0qfAd/3ycWDP879+eTtKBJA1YMnuezNNnPjjj+aEjeul26?=
 =?iso-8859-1?Q?j9bXoPOeGb0yqvJ09Ur3CM/tFC/slTGj1KT6rfmPuumScyWk99/JBS3AyC?=
 =?iso-8859-1?Q?zGxaum6STx+xxKkkcZYZakaGiALU2bw0jxKEp0iFzIZ5H5xGrIhmdAy6mL?=
 =?iso-8859-1?Q?kZEbKPA3uYsphWJiu/uJtLWD2lBwMR/MZjqFa8nFvwHoUOKJJE9DeeiSWZ?=
 =?iso-8859-1?Q?qwVCOY3Lq2cV5vK5XwtV/xkUsG0XM43lj+fmHnNAVUhWnzei4801UgTPvq?=
 =?iso-8859-1?Q?EiSfTtsENj5eDT977eCVpftKe7jxcbhPtyQLeeBXkAp2m1R/KDgvBuhCZQ?=
 =?iso-8859-1?Q?30GVD54zUF0CCD1CynvXJFXa9lUPcxSVOzrdPS9SprLHBDSLKxOwFYqpla?=
 =?iso-8859-1?Q?sJErmT/pD7oYGtG0e0vouFBL1/zFP5ujKasJTiEX00cHoHCDq/Q1M3oG4+?=
 =?iso-8859-1?Q?Mh1k0LsmqpBX+z2DEoGKT1uO+CfX3MeHOHKHjEIiXKR1EhTm9GhE6CJ7dR?=
 =?iso-8859-1?Q?nA3wF0+nFeuQ7piWSLc4n5+cduxZpyyOsl98zSRxHLVgiD+zQrhqB8zTZm?=
 =?iso-8859-1?Q?ruO/QmBbI31p22GIsrJ5PZ5tSivBEO9WZE5/DTXrr56RTvKJ+fcmfYoSEs?=
 =?iso-8859-1?Q?wtgk4hwz+tSzILHCXTiGXTRtR7WrS0NvfkeUSSkVGgq+sfX51cKAifMc9D?=
 =?iso-8859-1?Q?v3+1Y7IwIesBqtJYwOAjII6hfzh6ovW99uBCOve6iF4VYPvpDbjFIJfShb?=
 =?iso-8859-1?Q?KcNOhKSxnt6n79uGMHIppu4aO18/+RVC/HfxYj/d4xcwUXtMVp5jUS3ck/?=
 =?iso-8859-1?Q?LbaGKrqXyKl5/LlzkNsxQOvt68Kg5C22qqI15EUndic3qITCnZLJXyoLzO?=
 =?iso-8859-1?Q?RuoNHY46KnMMY1pAAFvbxGuuUrUVcIJbu1wakDNyPGYPcgtiIu6bj6/Eti?=
 =?iso-8859-1?Q?2Es01s2CmLJvWdnHB6YEJSIQS4v2fBgDo0Bzbtq0GaE558fBNd1C67WdV4?=
 =?iso-8859-1?Q?IWDn6TXcn5diw8tetnrXzNc1XprLopydB6FpE27gNux7YdDmEzJWMHyYan?=
 =?iso-8859-1?Q?5Frv+IQMlSLF4VhBviywRf3ka1a0235256tKfVxPpKgZfskKnjeER8sO/Y?=
 =?iso-8859-1?Q?iBfLK1TRGwn7YOTR//l9PqiNd3UVjI6kx3uL6eC8mjWaIUfAYJgvWmOUnC?=
 =?iso-8859-1?Q?AkpjrL03R2lHP/yZ18RuLWO19xiJsWvQrBVogXYrjce2z3F6xClVCBws2T?=
 =?iso-8859-1?Q?XHvxUpBh7aM2qDT9MEKMXI4gi7yQRbA5a4T3ycaK8LF6G6o5Ol+sJ7wpdw?=
 =?iso-8859-1?Q?HA0mIG6aS+ywGkmT8HHa1XwJ+8yx/LROMOJ1KYYwNA2RE9jOuXwHefN1U+?=
 =?iso-8859-1?Q?sWgH/acJ6qImh+Z/PE2T6D2YZt8GpT3SwAoEKl6wZxU5LfCDljklWaRKuP?=
 =?iso-8859-1?Q?JhhvHNhJnZjK9zXKC+LPiDCc0d3oVhKrdOcqGTKKRftUQ0bwUnfDu/hdtx?=
 =?iso-8859-1?Q?bi9CBdSGYm6r9fV5/87nHisDfYYVrC1CrwDQKp7An/Q3SwctK4Sw1KfG/r?=
 =?iso-8859-1?Q?rXgqd6dlWLHM9vRYAncM2NkIXtS8C+Y/KCQS2avN+I5VNYflXTMnN/Jn/C?=
 =?iso-8859-1?Q?eIF+1a6TkM0Ea0zLues=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f18fa84-223b-41ad-eef2-08dc36ad423c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 09:28:15.0590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Obvy7xl3CG+xb2488ww9e0ilOA9+XWOdMnbmKTDt1qgN6csFzKbpkzzoe/kbNvf2s5Y1pP28LeNzHJ+KVmCPb92BZaCk5e+zP/FVhHBKhU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8400
X-OriginatorOrg: intel.com

Hi Shuah,

On 2024-02-23 at 15:37:11 -0700, Shuah Khan wrote:
>
>Hi Reinette,
>
>Okay ran a quick test. Why does this test leave "/sys/fs/resctrl"
>mounted when it exits. Can we fix this to unmount before the test
>exits?

I also wasn't able to reproduce this unmounting issue:
- with unmounted resctrl before test:

	[/root]# ls /sys/fs/resctrl/
	[/root]#
	[/root]# ./resctrl_tests -t L3_NONCONT_CAT
	TAP version 13
	# Pass: Check kernel supports resctrl filesystem
	# Pass: Check resctrl mountpoint "/sys/fs/resctrl" exists
	# resctrl filesystem not mounted
	# dmesg: [   12.502941] resctrl: L3 allocation detected
	# dmesg: [   12.507134] resctrl: MB allocation detected
	# dmesg: [   12.511315] resctrl: L3 monitoring detected
	1..1
	# Starting L3_NONCONT_CAT test ...
	# Mounting resctrl to "/sys/fs/resctrl"
	# Write schema "L3:1=3f" to resctrl FS
	# Write schema "L3:1=f0f" to resctrl FS # write() failed : Invalid argument
	# Non-contiguous CBMs not supported and write of non-contiguous CBM failed as expected
	ok 1 L3_NONCONT_CAT: test
	# Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
	[/root]# ls /sys/fs/resctrl/
	[/root]#

And with mounted before test:

	[/root]# ls /sys/fs/resctrl/
	[/root]#
	[/root]# mount -t resctrl resctrl /sys/fs/resctrl
	[/root]# ls /sys/fs/resctrl/
	cpus  cpus_list  info  mode  mon_data  mon_groups  schemata  size  tasks
	[/root]# ./resctrl_tests -t L3_NONCONT_CAT
	TAP version 13
	# Pass: Check kernel supports resctrl filesystem
	# Pass: Check resctrl mountpoint "/sys/fs/resctrl" exists
	# resctrl filesystem is mounted
	# dmesg: [   12.502941] resctrl: L3 allocation detected
	# dmesg: [   12.507134] resctrl: MB allocation detected
	# dmesg: [   12.511315] resctrl: L3 monitoring detected
	1..1
	# Starting L3_NONCONT_CAT test ...
	# Mounting resctrl to "/sys/fs/resctrl"
	# Write schema "L3:1=3f" to resctrl FS
	# Write schema "L3:1=f0f" to resctrl FS # write() failed : Invalid argument
	# Non-contiguous CBMs not supported and write of non-contiguous CBM failed as expected
	ok 1 L3_NONCONT_CAT: test
	# Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
	[/root]# ls /sys/fs/resctrl/
	[/root]#

Looking at the code there is an unmounting function called after each test (at
the end of run_single_test() inside of test_cleanup()). The non-contiguous test
also doesn't write any data into a temp file so no additional cleanup is
necessary.

-- 
Kind regards
Maciej Wiecz?r-Retman