Received-SPF: pass (google.com: domain of linux-kernel+bounces-81063-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <85d2aef9-b966-4c90-8602-ba5961efc23a@oracle.com>
Date: Mon, 26 Feb 2024 09:36:37 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 06/11] block: Add atomic write support for statx
Content-Language: en-US
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>, axboe@kernel.dk,
        kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <87frxg1v8p.fsf@doe.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <87frxg1v8p.fsf@doe.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?STJzbXVqWm5DTXBUWElGYWhkMW9ESlZSKzRtY2RhWi9VYkFES0dzTlMxd201?=
 =?utf-8?B?ekdYN29RanVBeWplM3FLbENTS05CVDlaSVNsRDVUNFFSallnZTZ1UHJ3NndR?=
 =?utf-8?B?Y3hPVWEyNmZGalBvZFdJM0tyV2pKUjVzbGgzSjVmZERSeHpDVFd1YlVSbDNN?=
 =?utf-8?B?V3lURjgrdVJNNitaS3hHWEc3M2ZQSCtTZDVXZ2hNVW9hWjl0aWp6WG51ZXVO?=
 =?utf-8?B?NkNjb3NVaVlrR2lHREpQR3l6Y3ZJNERaenJHZVdvMXJSR3haRVFxYm54VG4r?=
 =?utf-8?B?TGpDWVgydUpUbFVTZElybERxY0h6dlVWcytyN2pLMnRoNHlrY0RZUVNNUk56?=
 =?utf-8?B?Y1lhWFFSRzdOWFNLTGFLbFFkVU9aRHZRWUpUVmpZQjJkeUFBdmlDOG9DZ0NK?=
 =?utf-8?B?TERoNXV4YVZMODRtb2JtdWNob3VrcWthalIvdDRjT2lJM2dwd2E4QWRsd1lM?=
 =?utf-8?B?bEJHWCtJLzRlZWVLenliM1JRZjgzaDBLRjVycElaczI5WHJoRXEwKytDdGNq?=
 =?utf-8?B?ZWtoeWttYmpuL05mS3F3S2FxbmVmZy9zbjFRQnZkYS9Sa0RNaU02Z0JTQkw2?=
 =?utf-8?B?RkZreVRiN2I2bkswbE85ZjBXUk9xM0FTSDBHK2FKUEN2dll3c1pqMmo4b3N6?=
 =?utf-8?B?b3ZYbkxoTzJLblRpT3NyRnNaa1pLZ1Zxei9qaFNpWTI1Rllnd3NHN2lSS21z?=
 =?utf-8?B?RVUrbkhnWTFUc2FUSnZjbEpTbW9JeitJdWxIKzhVaVFGY2hXKzBqWnMvZk5z?=
 =?utf-8?B?aW1CQ05oSkk4djN5U0Q4Y1MxWGtZcEU4bUlNaEQwZklmcW1TOEd6UVByQWJ3?=
 =?utf-8?B?ZytueE1TUUxzdit2dnR6S04yN1ErdWU5cVdNU05kVmtZcGFNTlRxY0E3blpN?=
 =?utf-8?B?M082eHhBQ29RSzVlemdUU09TcVptU0drTXBpYWtFeWk1ZUd2Q2NxNU9Mbkpj?=
 =?utf-8?B?a2JPMkdwdDMweXdueVJLdDJpS1BwYitLb1EvSmovekhHWWFDUXJUNHhEZ0x0?=
 =?utf-8?B?b1E3ZmlleGZHSDlwZFJyTDc2b0phbnJ6TGp4TVJ6SWRLOEVybVNUcDVReURl?=
 =?utf-8?B?dUttMGRpUkVHM2RleE5EMVFuMk45NmN1YWFHanhmU2tYYVdOZWVIYXZmWUtZ?=
 =?utf-8?B?WHRRYkpua0ZOLzl2MTU0WmdoOW9RbVpkRXBtSjNYQnFNak9MUUhLaG53bWxz?=
 =?utf-8?B?dE12YnhCR05WUnJyUnV3M1ZsZ0Z4U2s0TDF1UG93Qk5mWGI4Y0VidWhoU016?=
 =?utf-8?B?R0xQbmFjbTVKZHRDNXpsajR2bitzMUhYSlJVdGt1UmlCR1Y1SEg1bS8rRnlE?=
 =?utf-8?B?akxlQlNGWUZNNXFoMzRsbUFlTUNoTmJ6cmVtN1JwZ0NGUkJDQzVFRVRndUli?=
 =?utf-8?B?OVIxcHZIWDVjMU5TS2sraE9rUHA2U3FZaGFPY1MzWU5iTEloYlFvWFl5c09R?=
 =?utf-8?B?R2dEckVlRElvUzIwc1pXajM2c0ZBNFVndjAybS92SzRNY3VFOWh5ejZHdmJm?=
 =?utf-8?B?YzIzM09yWWV6Nk50YjVKV2tQN2FwWUhyb2FQY29oVEpYUm9aWnJMRzgwSDhN?=
 =?utf-8?B?b01PNE1ERG9IZ0Z5T3ErSCtFb1puUDBNNlVhK3BCUTRYWHJQRFIvaWtCWWVh?=
 =?utf-8?B?M2lmRUFTSVhSc1ZKZVFsQmJXc2RKeVRURmVVZnNkeUJOa3UxVGZaa3ZqK3VU?=
 =?utf-8?B?a3ZweWdESyt0c2VqNUhDOUFMelhORzJpSnNma0MwZXpMYjJqZGduWXYvSm1x?=
 =?utf-8?B?Q1Q2QnBUZFVWbk5zR2hYWFhPc0xiaWxKbWMzQ3pjYTN4SEFFU3BlazZRdU5k?=
 =?utf-8?B?TGZOREttdit2V3o5T1paR2JvQjVtV1A0SHdtdWZXZUpNZ3lhaDVkOVpzVWMx?=
 =?utf-8?B?UjR2YnNqZ3FRUG9IeGRXUEdFdVZZdnJUdElaU01OR1NGYll5cTV0OE4xbnE3?=
 =?utf-8?B?SzNra3krMGRtSHc5VVNWRGl1L2NhNGVaMHFqcENpaVAwcFhkc3hGejIyZkZ6?=
 =?utf-8?B?Z3pVSVR1SkxtbTF1RW5XUzZSakI0emVLa2t2Mk1YTVF4SG8zUkExeExwR09G?=
 =?utf-8?B?TGNkcmhLU2xOWncyclR3TTR3Mk5hRkVoWUdta29yb1NQN1UvK2tPa0FPUlA2?=
 =?utf-8?B?TnZFcXdqSjQ2WnlIYWRFcjczU1ZueURCTHRITTJCU0JqM3R0STd1V1pLRGx5?=
 =?utf-8?B?eVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	cRjW46JyVq1nyfTPRgiqIGu290f/ZudVZwdAkzRHnPuhyktyXc8EHCc0i609B7Rj3WVydEm6EAXRA1vmq4GPPmGZ8U6b10u4NiDqezoUFV8fEkTOHWN1tlrqv8qJW9FVjSMyHxU1I26tUzEXjKW6DlO+ZiKyURmsj9L2bcR7950t4+Om88dhrw5wfsMK23erpAytRCMiMatufsQeC5WZlMQgEYjo9bIogTWZGqz6diGm6gCDBIuCtHNy28BesUpWcP09UWK7JjoURm/qLEo3tW1PePMCMVYb8YV/7FRsN0EcV0dewdnwYJWBV0jjJh8NFOyIZVqIbkMghylj4swI8biuZN6Qts/iVqjLlp2Y/w0n7WWJ8QAP+slvYdIUtW5LZMGQEFCo0HGinDlKebUuB3Ka0KNLZ1ub2bGNiFkC6jYwemK7NngN2BcH4KvTdKNhtyg56T6LIZaT2CQYSkCovq0lhdNoCoMJ7/SVT9L7/cF3Yt7fELYIJDW8BBP+JHGuIndmQ+9QZqSNFW29wpp3lL0JKVQI0wv5s/dEy4pQkZn+fNoIRPW3xRdB4G0Tt1zG5CEfgGMtfj///8tFQNRPxTqtOkuDlhWVLg+3YbWM+KE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f434f809-47a3-40ad-d153-08dc36ae716a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 09:36:43.6623
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mXb88wENguKtA0A1TSSjMezPTqPWZ+sZHUx1afRcUWiNacraFacI7z+pxSKoFKvdUgY2m2t7/ytlWVH753jLwA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4369
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-26_07,2024-02-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0
 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 suspectscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402260072
X-Proofpoint-ORIG-GUID: h_N4ZjsXTDfNWxYmC7LWkOSPhdJfF_Jw
X-Proofpoint-GUID: h_N4ZjsXTDfNWxYmC7LWkOSPhdJfF_Jw

On 25/02/2024 14:20, Ritesh Harjani (IBM) wrote:
> John Garry <john.g.garry@oracle.com> writes:
> 
>> From: Prasad Singamsetty <prasad.singamsetty@oracle.com>
>>
>> Extend statx system call to return additional info for atomic write support
>> support if the specified file is a block device.
>>
>> Signed-off-by: Prasad Singamsetty <prasad.singamsetty@oracle.com>
>> Signed-off-by: John Garry <john.g.garry@oracle.com>
>> ---
>>   block/bdev.c           | 37 +++++++++++++++++++++++++++----------
>>   fs/stat.c              | 13 ++++++-------
>>   include/linux/blkdev.h |  5 +++--
>>   3 files changed, 36 insertions(+), 19 deletions(-)
>>
>> diff --git a/block/bdev.c b/block/bdev.c
>> index e9f1b12bd75c..0dada9902bd4 100644
>> --- a/block/bdev.c
>> +++ b/block/bdev.c
>> @@ -1116,24 +1116,41 @@ void sync_bdevs(bool wait)
>>   	iput(old_inode);
>>   }
>>   
>> +#define BDEV_STATX_SUPPORTED_MASK (STATX_DIOALIGN | STATX_WRITE_ATOMIC)
>> +
>>   /*
>> - * Handle STATX_DIOALIGN for block devices.
>> - *
>> - * Note that the inode passed to this is the inode of a block device node file,
>> - * not the block device's internal inode.  Therefore it is *not* valid to use
>> - * I_BDEV() here; the block device has to be looked up by i_rdev instead.
>> + * Handle STATX_{DIOALIGN, WRITE_ATOMIC} for block devices.
>>    */
>> -void bdev_statx_dioalign(struct inode *inode, struct kstat *stat)
>> +void bdev_statx(struct dentry *dentry, struct kstat *stat, u32 request_mask)
> 
> why change this to dentry? Why not keep it as inode itself?

I suppose that I could do that.

Thanks,
John