Received-SPF: pass (google.com: domain of linux-kernel+bounces-81079-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 26 Feb 2024 10:42:44 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] selftests/resctrl: Move cleanups out of
 individual tests
Message-ID: <sryavktjx6eqavjseo7ktii3v2g7opfodsv42fdlsy4dm3dwy4@algmgqcm6m35>
References: <cover.1708599491.git.maciej.wieczor-retman@intel.com>
 <bc4a4fec20420fb792612be024473f31f40d7bca.1708599491.git.maciej.wieczor-retman@intel.com>
 <8caed6ce-808a-4d25-823a-fc4d6b56268d@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8caed6ce-808a-4d25-823a-fc4d6b56268d@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?XifY4e4Ur05epZuJsv7Mid6y53yjMmyfg/PHimXxC2w7a03nZVDUra1SSm?=
 =?iso-8859-1?Q?scitIC1A1WwqsNOZmeFsuuCZt5NgDLmNBRRxXCcl6m33Q/F+GBmvfDQTFv?=
 =?iso-8859-1?Q?CQwBiyjfbJWCQ/CJTPZfXUVRV8Sm9t6Cl/VAT70l6cEXSC8RLWdrxuC3F8?=
 =?iso-8859-1?Q?CqF+Hf0UoGsWVw/9d/jYzMfDefQEPlQVez2e/aUYWzueLlxnBIr8XGONI4?=
 =?iso-8859-1?Q?gaqyuB1fZsRd07cIHFeOXHAM1dvm2/mUqXEPP1/8ewoRs6lt/sZRKhSAB9?=
 =?iso-8859-1?Q?2ADc9QKRblW7WT8SHO+NXWH6FMd5eqY4oH9S9rqBjZrb7KTFoYoIzdlB+J?=
 =?iso-8859-1?Q?m8awG5odCaXlUIvSY+BL+LKGcgBy2usP7nK+7gcbjNZL/B3lRE1GM4d5fC?=
 =?iso-8859-1?Q?uKQiwy69apKeiPjE7xBTehimsWd3dPmsxAtaPveMKbStngviH92DvHFKrf?=
 =?iso-8859-1?Q?3+uU3Fyw2Uvr2sBQc+0TzDH1kjrg8gU8qryfyW12C1PFw907ktkhtsqOZy?=
 =?iso-8859-1?Q?CZUw07RPyRUOEQl94UJCT5yz+RRC6dfjSnoYTNRsAqTGDsxatYuhih8QjM?=
 =?iso-8859-1?Q?4P18uL17EeyVUT28NnPxMerqR4faMBWuxpLPQa3iEaHz2dryyvMceY9fjW?=
 =?iso-8859-1?Q?j6y+lztqYEDSo1naVa04OFag0p4kJx6PNI3mCS0STwJPbnSjXFEL3FVJta?=
 =?iso-8859-1?Q?SLDRrQeBIS29raPIA5QWuXTVM3TpNCS9cVcP9q8hasJcZ+jG8PxkflUuam?=
 =?iso-8859-1?Q?fh8w9WBEGkTfsYpWsynN8rn9YnUA5WNyAq3GBsb2fuAl/127N+sAWIvK69?=
 =?iso-8859-1?Q?1/anXTmnRjyesGs6PP36qbhh1rswoHug+CFIV+x8KB+YIni2L1NUFBBcbT?=
 =?iso-8859-1?Q?vU2sqySjYs3OIF1Bp4FZVZvicgnTD09hRdUyf6jBgWO3IeTEyWC0e0IZVs?=
 =?iso-8859-1?Q?KGQphBYkoEGld/QNS88ZBexoxILI/ZNYSuLhcu9ynPNHl2FtUOM5ktJ8/m?=
 =?iso-8859-1?Q?B03FT7bzxpamLscHd3JjduyL0xtwf9MIQdUUk3QLRxWs8tA7cWBtFL6+rY?=
 =?iso-8859-1?Q?2RVTbpmcvogJiSv/Ols3XMgtnUO4h1QXfnfgqn5r4Ia9YNrhpYM+2zqbEH?=
 =?iso-8859-1?Q?14TH5pbqcIXa88asU9+Txv2upnD4jifBiWyi/3jRm58ERLYD/Z96rZO4M9?=
 =?iso-8859-1?Q?pKou0M9F4hhliGsUhzneNre9qvN6gZ3vBJQ323Z02v2FEn1/yqAYhfQViY?=
 =?iso-8859-1?Q?1MM1jCifUYfcSpJHLuphvtpM5TG0skh+Zb1EYWBcUkYtZjThgz2wDtt/Sl?=
 =?iso-8859-1?Q?pGjZPLYVurR4Q3nGijsIqABAtFUIbz4XSN6+5DfmTjZ8ysN9WT/+ypYpoW?=
 =?iso-8859-1?Q?KYMJOR5wgRreBkq2ZlaqfOy9zmty+kRcRYXP3A/6OpMUY/l8M/Gbv0oa/1?=
 =?iso-8859-1?Q?Ceq1JgeRwtr3NExsr4EmAtODw5/mfwvete5iN+XkUmtouZiPUrbtMMj0Wq?=
 =?iso-8859-1?Q?+WSlc5QT9XG2HVylSn50Jb8Y1mFe1THZroFzTNmLnMjRayzzcH210JB6Bp?=
 =?iso-8859-1?Q?dehQB15zgjw/nwGY5hd0qJGDa7f6hj+SmipN7rap7uCPieUEoZL1LseQv9?=
 =?iso-8859-1?Q?TEd6bNupNz3Y2JloVUKh22IKBD0ar0okx/+/dds02TEwKVKHI/Bvf6ll2K?=
 =?iso-8859-1?Q?I7aybFD9jXdUtknr0T4=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e33ed57-194b-4412-4c95-08dc36af4eab
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 09:42:54.8735
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9sLD5gx+VjMbjDs0KTYWNgTqhMyj5znXcH19gZN9YQUSIXnFWUn4k7ETY6DdS77wltsNsv2Ld+6nO+xA3LWhUXiffCgsuJ6v4L3hL8FMf28=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6140
X-OriginatorOrg: intel.com

On 2024-02-23 at 13:18:32 -0800, Reinette Chatre wrote:
>Hi Maciej,
>
>On 2/22/2024 4:07 AM, Maciej Wieczor-Retman wrote:
>> diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
>> index 161f5365b4f0..bae08d1221ec 100644
>> --- a/tools/testing/selftests/resctrl/resctrl_tests.c
>> +++ b/tools/testing/selftests/resctrl/resctrl_tests.c
>> @@ -134,6 +134,8 @@ static void run_single_test(const struct resctrl_test *test, const struct user_p
>>  	}
>>  
>>  	ret = test->run_test(test, uparams);
>> +	if (test->cleanup)
>> +		test->cleanup();
>>  	ksft_test_result(!ret, "%s: test\n", test->name);
>>  
>>  cleanup:
>
>I think this can be potentially confusing to do cleanup here and
>then follow it with a test_cleanup(). Could this test specific
>cleanup perhaps be called from the general test_cleanup() instead?

Sure, that should look nicer, thanks!

>
>Reinette

-- 
Kind regards
Maciej Wiecz?r-Retman