Received-SPF: pass (google.com: domain of linux-kernel+bounces-81091-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b9bbc1b9-6dc2-48d2-a4ae-4b28516e4131@oracle.com>
Date: Mon, 26 Feb 2024 09:46:58 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 03/11] fs: Initial atomic write support
Content-Language: en-US
To: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>, axboe@kernel.dk,
        kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, jejb@linux.ibm.com,
        martin.petersen@oracle.com, djwong@kernel.org, viro@zeniv.linux.org.uk,
        brauner@kernel.org, dchinner@redhat.com, jack@suse.cz
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ojaswin@linux.ibm.com, linux-aio@kvack.org,
        linux-btrfs@vger.kernel.org, io-uring@vger.kernel.org,
        nilay@linux.ibm.com,
        Prasad Singamsetty <prasad.singamsetty@oracle.com>
References: <878r371tce.fsf@doe.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <878r371tce.fsf@doe.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ZWNPcnB2Rzc5T29vSGQzV2xjWm8yVDVrQ1plTFpnZHFVOFY0MEJKU0tkem5p?=
 =?utf-8?B?L1lSdFY4NHR5U2dKMm96VkVWRjNQeWhaanNuYXdZMC9EWHl0bjVlTHRnZlUx?=
 =?utf-8?B?a2x3dkQxQW1mb2cxRGJZUXh6cjliTWJNeTdoTUQ2VlZoaUJjRmdHdEtEdGJs?=
 =?utf-8?B?RklwTWw1aVhrblBBbWhxeHBjaUdXditMam84ZG1aNGlwRW1ubmpCVmJTd0VJ?=
 =?utf-8?B?WnhPTTJZTUhaNEthVGRKazlpWnIzTEdhdW9jdTZFWXBtT0tlemtCWlJaV0ph?=
 =?utf-8?B?TGt2MUZiVG9LY04vVGRUU3ZJdU44ZXNLZWcrZ04vWGZIeUNweCtWNVQwR254?=
 =?utf-8?B?My9JQnhnbkpEcTc1dEZkaTVyMHRMWU9MRlVyVkRYbkVBTkIzK1BBR0lteUcr?=
 =?utf-8?B?bkkraE5RRFNPMnFmd1p3WW85cm1XeFNxQ3d3U2p1eDdyazRzdVFUZThvQW5Y?=
 =?utf-8?B?ODhVUWNYQjFYTkRacUhROUFzSEZjeU5nRVF1RkdKSEFnUERzRUdvM1ZwTkNv?=
 =?utf-8?B?eDc4R0dYcGNWZ0UxQ1hVbWRBYkdoVGNNY2pXcDQ1UVl3cnVzOWo4SXlqZW9K?=
 =?utf-8?B?SWJ3L05zS09EdmlDeE5OSFd4MnBOcllaRTBvcDBraURwRDFiUG5NdHF5MjRR?=
 =?utf-8?B?c0tOZHY3MzY1clBJV2JOdjhXbGNhOGpoRjVJbWFXMUhUWjBCQzBsR1VSUW5Y?=
 =?utf-8?B?L3VyY2srTU9mY3IzQWJCVTNjQm1iZU9PZFFaVkYvdW5nTy95R2RDZjQxMmRl?=
 =?utf-8?B?QzYyOEovM1ZKVFcwbE00eHRNenQ3TVRDTldsWnk3UjFsZ24rdUJhWWVyWndR?=
 =?utf-8?B?ZU1tZWVnV2VOUmFabExDdzVFdGZpWlJPVktQMU9KQ0R2cWtncnY2NGY3dXdD?=
 =?utf-8?B?MWpVTDJnSjc0c3NRYVBnWjdSeTE2OG15SWFHL0hWcm5QMVBtRW9HZ2huN2Fn?=
 =?utf-8?B?UzZQOXhlWllMb1JOQlkzc1oyU1p1WVZTUE5ZT1hNa2h1dGtRZFJ0Zk9DZStR?=
 =?utf-8?B?N3IxQUVXaVA2ZDQxcElmd2FJcFdRaFhPcC9mSlg2NHNKTXBkcDJDR1V2SVRl?=
 =?utf-8?B?K3gxaGEzQkU4cnkrdUxSMi9KMEFwUElhdVRGaEYyaDdKeitmWTJ4WjFjN29Z?=
 =?utf-8?B?bUZvandydW5yTThZM3dwL3o4REhOblFWcVlXRGZXY09rZXdsbGdMc0tWRnJT?=
 =?utf-8?B?YmdzMkJNV1hyTDhWWEMxV2IzUXRqQTlHeW1xVi9HbmVmYnFtTjNBZ0NPWW8w?=
 =?utf-8?B?NDdOZUpaTUtTaEZ5L1hSY2psckNPa2daK0xyRXUrQVZBRE5KcGpzeUJ3R0NO?=
 =?utf-8?B?M21BNGh4b3dDTHR3UnhDZmU3dWJ0MEtsK1VZNWx0RnpUUW9UK3ducGNnaUdC?=
 =?utf-8?B?aGV2bEpZcUp3a1RUUUhpbGUzdWhEcnV0eC9wODRxNW9teWpDaCtUeXExQVRL?=
 =?utf-8?B?Mm0wT3FwSU8vTzhRenhsaS9PcFhJNDFpS2lsWmdpZGhpMkkyMWFqaGRWc3Az?=
 =?utf-8?B?dnhTbHpTcHhEQndSSXY5RXlYWDdVSFkvR0dYd0VPY1hnZ2VDQzFKdWkrSlFV?=
 =?utf-8?B?U2UybFFrcHlMMiszSHp4L25qb0tZc2luRW41VTRrRkptOXBESVNvS1h1ekVr?=
 =?utf-8?B?TnhjTUN2YnFBbjJqbnB4L3pkaTdKd0Z2eVJxM1FZRDRYRFZhMU5aZVVMNUJT?=
 =?utf-8?B?b0JkbDIyQU5FbStUaCs0UW43NkJ5dk5ob1M4TGhncFlPaUcwMnZ4RVRsM1d1?=
 =?utf-8?B?ZEtxWHYzRllCWVJ2clduN3F6VWVEUnE1RkVLQ3BqanRHaTA0L0hTSmI2bUZ3?=
 =?utf-8?B?TXdDZEg5OVg2cEswWEFMLzNsN0FhSEMxOUpMRk1KMFA5b05sdUJiRXpXSXpS?=
 =?utf-8?B?TGpOciszYVRqQ3ZUU0RxQnZwZUQ5TDkrR0tHdE1qZjRlUlpOU0dId2txZWho?=
 =?utf-8?B?YTZqYlJIRkxVaDVhZ0RrQyttS0hBV21LanRYdkRyK3Iwek1sbS9aTDBOOHdI?=
 =?utf-8?B?d25Qa1VLbHhjdGkwdjJDbURHYzVLOHE4c1ZFekkrdEZKdkQxM08rdUFEWGVZ?=
 =?utf-8?B?RnZrVlpSQW1KcTFNOURTSVZmR1VqYXpOcTF2aDIwSUdVaUZBU3ZlVitpUnRv?=
 =?utf-8?B?cUVOYXFsOTFvVUc3bDVPaDRjK2w4RlNQanBNWHA0NGdsK25EUGQ4bElHazFI?=
 =?utf-8?B?MWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Lpn4+KUGOu4z0fauujmXkA15fzZVlF4rZbBn0kow1ag9IEpDFQjWXDfoqB+fIRe8udLN3LliXEYmgodlap76SLjE1FzM8A+JaxbsAhS62CbzC/zOVyT/eopK8EKG9YTksfkETjZipxqPW7g/s0eospkgRYszMjxoCX47ratU5B7vGasLP0eNSV6q5XEtRKhAErYxzbCWh1PyAp6NgR6Ftl0L07RcLPtW2uDxb6r2lQzno7hpIlv44RDN4t4OABPO9AeBXDCdq8jLbTzeZOclkg5AgJQbpXKIz+FOSSE0WULRpPk7tZmJiW3E7H0Zwditpn3tLiIZ0rwjLYVmOqB9TPyIRCRj8ox8beFUaqgMJUaF5x4sU7LxCXSSVPZMiVnqb6BHuqFT3QUsG3Gdgsz0FRVbWDlcpRARBziJy/mEA6Tcl8lObIqS5PN9p241fJheC4ggEo/iCTnDRq7WZATbfNb+GKOBxNQenkynvE9UNM9upcbrvqJM3bp6A44yqaeWXbjtVMev7lwJlfisQp7PNJ2aUYfDe2FlRpxwMoC5xm1MarVP6rZSGaH43b1P0uRJ/dk/QE9yzjRzHq9dkzOHhO0jrFYykgnjiFzJcLoiXzo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ab82e7b-0458-4a42-47bf-08dc36afe163
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 09:47:01.0513
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q088fEmSBqfi7pFwjUbsiaFjvifC1dSpxZkwLMSZDIVFopQiaTHCP/il+0hTuI5jQi9G21DtKKQ8d5wdpUof7A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5999
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-26_07,2024-02-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402260073
X-Proofpoint-ORIG-GUID: maucKdwenRrHyx57bOKWzv35Qe6WprUg
X-Proofpoint-GUID: maucKdwenRrHyx57bOKWzv35Qe6WprUg

On 26/02/2024 09:13, Ritesh Harjani (IBM) wrote:
>>> maybe generic_atomic_write_valid()?
>> Having "generic" in the name implies that there are other ways in which
>> we can check if an atomic write is valid, but really this function
>> should be good to use in scenarios so far considered.
> It means individual FS can call in a generic atomic write validation
> helper instead of implementing of their own. Hence generic_atomic_write_valid().
> 
> So for e.g. blkdev_atomic_write_valid() function and maybe iomap (or
> ext4 or xfs) can use a generic_atomic_write_valid() helper routine to
> validate an atomic write request.

ok, fine, I can change the name as suggested.

Thanks,
John