Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1213028rbb; Mon, 26 Feb 2024 02:19:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVb/69bu55yv4N6SAoauUZRjeyMR3vEyt/WnRI6Y4eDa5GLzym26MAPgOBekQ7m2fP015NhCFC3av0M4SpO1o/OtGJZFdYEHghZMfheuA== X-Google-Smtp-Source: AGHT+IH4ID3NJVhkQixOTH6Th4YefCeuhVssNohPRHAuIXmIDPo7FiRPRp0MGnI0DwFHQfzPfr/L X-Received: by 2002:a17:906:7191:b0:a43:1182:c06e with SMTP id h17-20020a170906719100b00a431182c06emr2516497ejk.67.1708942740390; Mon, 26 Feb 2024 02:19:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708942740; cv=pass; d=google.com; s=arc-20160816; b=sskXEEDVds6ZNkVxEpSb1gs0dYnB/V76I+2I9a1XIiA96dJaAO2GfcDvM7+pSuwzxr yS/14SkielvCeklQ1aTB39aX7a9I/alQVEqSnIOBVphbzzIJtVcQto2V0u2RDVZFOGps MmhiwM6kY2QWF+HvKWqya3PdcvElxHw591j8k3Xp9xZ6Wus3fhnAATTJ5v7r3tdFm3hd rcJm+QRONBlcZZxPAnukOXQ9LVrL5UWuzFFqUDjPCq2TLY7LE2M8/oFvPmjrraf1nyEE 5LMubftsQpWGgNXXScw9amzZCnvrstk1ARPtKA2I5FVJSF+3oYWiMGxfoRUwg7Ok5oVG XYnQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=mW3Xk9qK5Xxrvz3AXNQXJAQSjYIkreU//UIF7gTwtHA=; fh=C/cU86fkMovkyiOfOX3Gq36E0KmqLV0rsEWHQeXBGUI=; b=NJbdPKi357mF3GwfTfzmHEZ9GUw4VtV0QcCQCH/IBg+KfV97qkp+dACwkQ+RBr76LH gqYnuHMOxtVIQ32pwuPWMrhrxHDGUgPy6oWHVIJdCBfXWx99kWPplI/rGgfa9pKQ8lfT l9CDDVF+AubEEek9BOHtsxhp9ilnvO+3VnMtb5Msx9dni1w7zvULQSU1+f7fOCg7HHIt WmLqz60t/M4HCwtZCGl+IjSLEbs8VKr+kLnPXCTyPTJD/9aLvgNNV9N9vVXL0BZVWV2C ZXhcwVRzMxFib9bL88N69Rvs7g0EXGa8+YGwA9ACr7gtPSPyvjv/fSe0UZBfCpOAzOkI WAqQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AKOoR+ZB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81120-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81120-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qq16-20020a17090720d000b00a3f1b399739si1922908ejb.251.2024.02.26.02.19.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 02:19:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81120-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AKOoR+ZB; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81120-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81120-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 199611F2AF66 for ; Mon, 26 Feb 2024 10:19:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 66EFB4F881; Mon, 26 Feb 2024 09:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AKOoR+ZB" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F0C4F213; Mon, 26 Feb 2024 09:55:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708941338; cv=none; b=s5nCwNgq6WzjcF27WSUgnpytj+PasUpS7Eg6xXraU0cPgxAWyrYwt+3BrLPo2dHl1IvsZHaROTH2Zy8FG+Wd0EzHQDoy8Ooe5IUXDZY1wNF49fDQWLqOydwB7O0TlsTX1UqFQPKWdNLwtRYpV9Bc7BhwT/NyoMrrGSUvtMS2Tk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708941338; c=relaxed/simple; bh=4dRXifSdQjscvfLmqYmq24fqEGlLnuN4Zc0Ty+/Cqmc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OwvQe0AXbDMwbqXTx19Plyq5xxG/n4x9Mrohgrz8LyHCQPc0SAEYqW476sJS5LjZc6nGWcO89QKUZ8q6IeffzKTbVe0VVhL4+WYTtn++a9sI7BfV0E6wZJRbXWwkR1hu8dlwwOtT5ugjHSbpKlYjSmbzhXGeNkfWq+ztRaCWst0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AKOoR+ZB; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A503C43390; Mon, 26 Feb 2024 09:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708941338; bh=4dRXifSdQjscvfLmqYmq24fqEGlLnuN4Zc0Ty+/Cqmc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AKOoR+ZBcLmKp+ldEEnw32sKLbEiPsihkWbr/DdXjQshwve9EmlZ69CX+EtAkkxn8 sQyUpyavmYWBTPZNE/bkt+gnQ3uFPqH+u/QwATZ7pQo5CzC5/8+zZ/J1KqdQifIHps I26x1edA2wGFDQ4aU+Ki4WkTXZ2qkMSkmiOdmA1Pk1Ks/66+cM5AH1KxrUW8RIWSoP l+iFWriLMKYWviwdLxb+6q7mZOwty3yMCEPJlroxdpULY/+EFw7B0FUcvms7UrnF2f Q9/VRqle1CfyJD7lHbpkYzrh+6xjfUJR9+1Y9E2AxKz6+vSJzpJIqfuMtAMatoQwCp 7z7aYRZ7g/25A== From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jonathan Corbet , Sandy Huang , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Maxime Ripard Cc: Hans Verkuil , Sebastian Wick , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Sui Jingfeng Subject: Re: (subset) [PATCH v7 35/36] drm/sun4i: hdmi: Consolidate atomic_check and mode_valid Date: Mon, 26 Feb 2024 10:55:23 +0100 Message-ID: <170894131837.29486.11894124011939274293.b4-ty@kernel.org> X-Mailer: git-send-email 2.43.2 In-Reply-To: <20240222-kms-hdmi-connector-state-v7-35-8f4af575fce2@kernel.org> References: <20240222-kms-hdmi-connector-state-v7-0-8f4af575fce2@kernel.org> <20240222-kms-hdmi-connector-state-v7-35-8f4af575fce2@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 22 Feb 2024 19:14:21 +0100, Maxime Ripard wrote: > atomic_check and mode_valid do not check for the same things which can > lead to surprising result if the userspace commits a mode that didn't go > through mode_valid. Let's merge the two implementations into a function > called by both. > > Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime