Received-SPF: pass (google.com: domain of linux-kernel+bounces-81124-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 26 Feb 2024 10:00:21 +0000
From: Conor Dooley <conor.dooley@microchip.com>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
CC: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>, Conor Dooley
	<conor+dt@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley
	<paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou
	<aou@eecs.berkeley.edu>, William Qiu <william.qiu@starfivetech.com>, Ley Foon
 Tan <leyfoon.tan@starfivetech.com>, <linux-pwm@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: pwm: opencores: Add compatible for StarFive
 JH8100
Message-ID: <20240226-greasily-balcony-cee5014f5b8b@wendy>
References: <20240226033945.816974-1-jisheng.teoh@starfivetech.com>
 <opzxowacxsagwgw3l33p6y7omzjokus2bi3ol5wizfwjwi2s44@3p5frb4ysji7>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qIf1NVTAKfLs5NKT"
Content-Disposition: inline
In-Reply-To: <opzxowacxsagwgw3l33p6y7omzjokus2bi3ol5wizfwjwi2s44@3p5frb4ysji7>

--qIf1NVTAKfLs5NKT
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 26, 2024 at 09:11:23AM +0100, Uwe Kleine-K=F6nig wrote:
> Hello,
>=20
> On Mon, Feb 26, 2024 at 11:39:45AM +0800, Ji Sheng Teoh wrote:
> > StarFive JH8100 uses the same OpenCores PWM controller as JH7110.
> > Mark JH8100 as compatible to the OpenCores PWM controller.
> >=20
> > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> >=20
> > ---
> >=20
> > This patch depends on patch [1] ("dt-bindings: pwm: Add bindings for
> > OpenCores PWM Controller") in Conor's riscv-dt-for-next branch.
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/com=
mit/?h=3Driscv-dt-for-next&id=3D2529085831b01fcd02ff58ab4e2596d3b31bcf80
>=20
> I recommend to make use of git format-patch's --base parameter to
> additionally(!) make this information available to the build bots.

I like the "additionally" :)
>=20
> Looks fine to me.
>=20
> Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> Coner: If you're happy with this patch, please apply it in the same way
> as the initial OpenCores PWM Controller binding patch.

Ye, I can do. Although, I suppose this is an example of why the driver
maintainers applying the bindings is preferred, even if the driver patch
itself isn't ready or there is no driver patch.

Cheers,
Conor.

--qIf1NVTAKfLs5NKT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdxhNAAKCRB4tDGHoIJi
0sfGAP4gXa3ZQBTcw4KYOWpO4Y9Hl56JOtYMdxzTr8/ALwaDwAD/WwrHnl741xey
Tfp2k4uQHY/CONnty4macPOekNyY4wI=
=Oyq2
-----END PGP SIGNATURE-----

--qIf1NVTAKfLs5NKT--