Received-SPF: pass (google.com: domain of linux-kernel+bounces-81209-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1044283e-5059-421b-810b-f5f6938937cc@redhat.com>
Date: Mon, 26 Feb 2024 11:48:24 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] staging: media: atomisp: Fix various formatting issues
 and remove unneccesary braces
Content-Language: en-US
To: Jonathan Bergh <bergh.jonathan@gmail.com>
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240225120350.31226-1-bergh.jonathan@gmail.com>
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20240225120350.31226-1-bergh.jonathan@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Jonathan,

On 2/25/24 13:03, Jonathan Bergh wrote:
> This patch fixes the following formatting issues:
>  * Fix various misaligned * and */ in multiline block comments
>  * Remove unnecessary braces from single line conditional statements
>  * Remove repeated word "from" from comment
> 
> Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

(I'll apply this to my atomisp-branch the next time I'm working on that branch).

Regards,

Hans

> ---
>  drivers/staging/media/atomisp/pci/atomisp_cmd.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index d0db2efe0045..5fa9918c8e1e 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -65,7 +65,8 @@
>   * At 15fps this means 133ms. We set the timeout a bit longer.
>   * Each flash driver is supposed to set its own timeout, but
>   * just in case someone else changed the timeout, we set it
> - * here to make sure we don't damage the flash hardware. */
> + * here to make sure we don't damage the flash hardware.
> + */
>  #define FLASH_TIMEOUT 800 /* ms */
>  
>  union host {
> @@ -1261,11 +1262,10 @@ int atomisp_gdc_cac(struct atomisp_sub_device *asd, int flag,
>  	}
>  
>  	asd->params.gdc_cac_en = !!*value;
> -	if (asd->params.gdc_cac_en) {
> +	if (asd->params.gdc_cac_en)
>  		asd->params.config.morph_table = asd->params.css_param.morph_table;
> -	} else {
> +	else
>  		asd->params.config.morph_table = NULL;
> -	}
>  	asd->params.css_update_params_needed = true;
>  	atomisp_update_capture_mode(asd);
>  	return 0;
> @@ -3035,8 +3035,8 @@ void atomisp_handle_parameter_and_buffer(struct atomisp_video_pipe *pipe)
>  }
>  
>  /*
> -* Function to configure ISP parameters
> -*/
> + * Function to configure ISP parameters
> + */
>  int atomisp_set_parameters(struct video_device *vdev,
>  			   struct atomisp_parameters *arg)
>  {
> @@ -3367,7 +3367,7 @@ int atomisp_fixed_pattern(struct atomisp_sub_device *asd, int flag,
>  		return 0;
>  	}
>  
> -	/* Add function to get black from from sensor with shutter off */
> +	/* Add function to get black from sensor with shutter off */
>  	return 0;
>  }
>