Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758322AbYAAXPo (ORCPT ); Tue, 1 Jan 2008 18:15:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755086AbYAAXPh (ORCPT ); Tue, 1 Jan 2008 18:15:37 -0500 Received: from smtp5.pp.htv.fi ([213.243.153.39]:47189 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754641AbYAAXPg (ORCPT ); Tue, 1 Jan 2008 18:15:36 -0500 Date: Wed, 2 Jan 2008 01:15:21 +0200 From: Adrian Bunk To: Oliver Pinter =?utf-8?B?KFBpbnTDqXIgT2xpdsOpcik=?= Cc: stable@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] OSS msnd: fix array overflows Message-ID: <20080101231521.GG27566@does.not.exist> References: <20080101134921.GQ2360@does.not.exist> <6101e8c40801011043k209e1db6t1f5877b1c034c865@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6101e8c40801011043k209e1db6t1f5877b1c034c865@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1539 Lines: 52 On Tue, Jan 01, 2008 at 07:43:23PM +0100, Oliver Pinter (Pintér Olivér) wrote: > then it is auch to 2.6.22-stable? That's a very old bug in a driver for ancient hardware, so there's no need to hurry. > On 1/1/08, Adrian Bunk wrote: > > This patch fixes array overflows in the OSS msnd driver spotted by the > > Coverity checker. > > > > Signed-off-by: Adrian Bunk > > > > --- > > > > This patch has been sent on: > > - 27 Oct 2007 > > > > 97463a59dfb9ccb915d3b615225c98cb3e310c0a > > diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h > > index 05cf786..d0ca582 100644 > > --- a/sound/oss/msnd.h > > +++ b/sound/oss/msnd.h > > @@ -233,8 +233,8 @@ typedef struct multisound_dev { > > spinlock_t lock; > > int nresets; > > unsigned long recsrc; > > - int left_levels[16]; > > - int right_levels[16]; > > + int left_levels[32]; > > + int right_levels[32]; > > int mixer_mod_count; > > int calibrate_signal; > > int play_sample_size, play_sample_rate, play_channels; > > Thanks, > Oliver cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/