Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1232901rbb; Mon, 26 Feb 2024 03:08:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7mQ7X9qYtFdhmEULbb7b97ccFTaKXUcAc6mFFddaOXlJqdAqHN134hk8tzkd1UekHaZNxa41tN5pmjh05QTDQtGHtpaLq1FGh8wZQlA== X-Google-Smtp-Source: AGHT+IHw/E6orM4ad1sH254hMRmDZ0KwTKrhfM0vL+ruhS2JiLjlcpxj8N9ywcWG0hnhHhHDh/Xr X-Received: by 2002:a81:e549:0:b0:608:bc78:94b7 with SMTP id c9-20020a81e549000000b00608bc7894b7mr4729033ywm.49.1708945720980; Mon, 26 Feb 2024 03:08:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708945720; cv=pass; d=google.com; s=arc-20160816; b=rI9ZgC94gBDBvtIOXOHf+nrNZwmXDo4tmX8/JWyrukTmO1AmusUqMYMfNHByg3damm GJIVQRoWNXDPFk4OBEKRiqDWcL4LnK+djfd+w67GM0I0Cl6pwCQiqYNt8lsd0uzJrOMv gUEK975Mgjl4MV9IlAASKtNHfNwMiiXz9tN8uuX9/cDOz8+NbtiVBYLJgDu0mbpfl4N2 V5fGtBlGR6EKb+w6bEscfn/psMU92ICCpAfSVH/YdxS3aXjQIING1xJZBdiu+/r0FcI8 ZPSV7y2oOrRB3gt4XLgWrvcEyQMDm41YciYSByBdIhYNNIkqMoWJ290i+0rgYM2klKU2 BEDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=NcDq1qWEty3GrmSdiQNAMmQGE+3xREv3uriI4WyZhVU=; fh=NxilBuiqz+2U7sXeqs9J6pTxX3FVKueJylk5PSevRpk=; b=diiu4wRxh9R0hPp0WsepupGFiTDvlAiM37dHBvTacOy1YC3MW7rFQcJpMuLrs59bkm Y4rVYvg1jzmHthXMT9bkUo0nor3E2qt0SDdtsqwVcxwxATuQLITyiIyNa92xP1nfqNj5 hL28zIcUJs/Grn/k2pT9X2udP6hyx3yHRcZaFVlTvlTi5nzHwJY4XOqhiYOhz+Cr624R HgFxKnBCMRAzYM3qnBK/cF2IZNd0Cs3WPLRICQbPqHSyliKNX0RLxyLKTVJuQwg5MXJT mrbk79EdTrYjLszXjHZ0uCXvOFFmBJDB5pjcY3Id6dtAwRFkIdFg4VE3+DYp0rvDG1i+ tUiA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-81251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81251-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 19-20020ac85653000000b0042e2b466390si4739859qtt.215.2024.02.26.03.08.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 03:08:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=pengutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-81251-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81251-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A92EB1C24567 for ; Mon, 26 Feb 2024 11:08:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2FA3A1EB56; Mon, 26 Feb 2024 11:08:33 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C3161EB2B for ; Mon, 26 Feb 2024 11:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708945712; cv=none; b=hsQ6LMLxkwArUkLheWwIw/i86Hh1GlO10SK1DOyZaHz0W6O2dwVRRqyCllFo4TD55Om44nm1vp2ypZsu0kqOfgeLB/hL0r61YGWAeO/eR0lXkW0Arb0GL+4Zd6HgngIzqU/xVWQi6bjfXu6MQOObhkzo7D39skO+yOjjBLjhO8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708945712; c=relaxed/simple; bh=qr8hL1g7sAkBTasKdRNUXXfQV4F3/3ixv1b1xAVXtwo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mONTotKO4LtyWwE/jGW7gaB77tt6MMwclYg69pKUBMnfkcMhalOkXR48I0So56uFgdZi9sDewxEFkOuEsOh/MA3pjtF/sWq2y3ovEC2i91pPHCLFTpKa44fz0snocFgR0Btu85V3OPODizEBfDcV6IsXnQ11L+kJsfiWvtieiTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1reYqM-00077Z-Uo; Mon, 26 Feb 2024 12:08:22 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1reYqL-002yub-BQ; Mon, 26 Feb 2024 12:08:21 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1reYqL-008rqN-0w; Mon, 26 Feb 2024 12:08:21 +0100 From: Oleksij Rempel To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Woojung Huh Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: [PATCH net v1 1/1] net: lan78xx: fix "softirq work is pending" error Date: Mon, 26 Feb 2024 12:08:20 +0100 Message-Id: <20240226110820.2113584-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Disable BH around the call to napi_schedule() to avoid following error: NOHZ tick-stop error: local softirq work is pending, handler #08!!! Fixes: ec4c7e12396b ("lan78xx: Introduce NAPI polling support") Signed-off-by: Oleksij Rempel --- drivers/net/usb/lan78xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 7d7e185d7fae..3ff430198512 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1501,7 +1501,9 @@ static int lan78xx_link_reset(struct lan78xx_net *dev) lan78xx_rx_urb_submit_all(dev); + local_bh_disable(); napi_schedule(&dev->napi); + local_bh_enable(); } return 0; -- 2.39.2