Received-SPF: pass (google.com: domain of linux-kernel+bounces-81211-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <549ba85b-9902-4fed-9f67-e3ebc3aec3ec@redhat.com>
Date: Mon, 26 Feb 2024 11:49:03 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: dell-privacy: Remove usage of
 wmi_has_guid()
Content-Language: en-US
To: Armin Wolf <W_Armin@gmx.de>, ilpo.jarvinen@linux.intel.com
Cc: Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240223162905.12416-1-W_Armin@gmx.de>
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20240223162905.12416-1-W_Armin@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi,

On 2/23/24 17:29, Armin Wolf wrote:
> The WMI driver core already takes care that the WMI driver is
> only bound to WMI devices with a matching GUID.
> 
> Remove the unnecessary call to wmi_has_guid(), which will always
> be true when the driver probes.
> 
> Tested on a Dell Inspiron 3505.
> 
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/platform/x86/dell/dell-wmi-privacy.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-privacy.c b/drivers/platform/x86/dell/dell-wmi-privacy.c
> index 4d94603f7785..4b65e1655d42 100644
> --- a/drivers/platform/x86/dell/dell-wmi-privacy.c
> +++ b/drivers/platform/x86/dell/dell-wmi-privacy.c
> @@ -297,10 +297,6 @@ static int dell_privacy_wmi_probe(struct wmi_device *wdev, const void *context)
>  	struct key_entry *keymap;
>  	int ret, i, j;
> 
> -	ret = wmi_has_guid(DELL_PRIVACY_GUID);
> -	if (!ret)
> -		pr_debug("Unable to detect available Dell privacy devices!\n");
> -
>  	priv = devm_kzalloc(&wdev->dev, sizeof(*priv), GFP_KERNEL);
>  	if (!priv)
>  		return -ENOMEM;
> --
> 2.39.2
>