Received-SPF: pass (google.com: domain of linux-kernel+bounces-81271-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f516eb83-c393-af67-803f-4cf664865cf8@bytedance.com>
Date: Mon, 26 Feb 2024 19:33:53 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH 0/3] Support intra-function call validation
To: bp@alien8.de, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
 jpoimboe@redhat.com, peterz@infradead.org, mbenes@suse.cz,
 gregkh@linuxfoundation.org, stable@vger.kernel.org,
 alexandre.chartre@oracle.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
References: <20240226094925.95835-1-qirui.001@bytedance.com>
From: qirui <qirui.001@bytedance.com>
In-Reply-To: <20240226094925.95835-1-qirui.001@bytedance.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

This issue only occurs in 5.4 LTS versions after LTS 5.4.250 (inclusive), and this patchset is based on commit 6e1f54a4985b63bc1b55a09e5e75a974c5d6719b (Linux 5.4.269)

On 2/26/24 5:49 PM, Rui Qi wrote:
> Since kernel version 5.4.250 LTS, there has been an issue with the kernel live patching feature becoming unavailable. When compiling the sample code for kernel live patching, the following message is displayed when enabled:
> 
> livepatch: klp_check_stack: kworker/u256:6:23490 has an unreliable stack
> 
> After investigation, it was found that this is due to objtool not supporting intra-function calls, resulting in incorrect orc entry generation.
> 
> This patchset adds support for intra-function calls, allowing the kernel live patching feature to work correctly.
> 
> Alexandre Chartre (2):
>    objtool: is_fentry_call() crashes if call has no destination
>    objtool: Add support for intra-function calls
> 
> Rui Qi (1):
>    x86/speculation: Support intra-function call validation
> 
>   arch/x86/include/asm/nospec-branch.h          |  7 ++
>   include/linux/frame.h                         | 11 ++++
>   .../Documentation/stack-validation.txt        |  8 +++
>   tools/objtool/arch/x86/decode.c               |  6 ++
>   tools/objtool/check.c                         | 64 +++++++++++++++++--
>   5 files changed, 91 insertions(+), 5 deletions(-)
>