Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1282550rbb; Mon, 26 Feb 2024 04:54:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVEwegr+tybh0tjDWDntXus/Lz8BGYRJenjG1jCxxB4tbQJ0BakficGjGJNJ9iuFUgM2uCdMtBoFpdg+h6jPcAqOnxiY/xXjCbj7suU8Q== X-Google-Smtp-Source: AGHT+IFJXZM2Pp9CmcpwOBM/RKbMpLRUezqD+SQWnlxp6OQp/t3pNfRi6WPXRYMfpthxUkxik4aX X-Received: by 2002:a05:620a:1374:b0:787:9be3:933b with SMTP id d20-20020a05620a137400b007879be3933bmr12094271qkl.37.1708952049358; Mon, 26 Feb 2024 04:54:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708952049; cv=pass; d=google.com; s=arc-20160816; b=EQMdFYTwJWYS5gLhPcfpGOS+d4SvzBet4HZ7wM61dar3dTrYQrLKGrjn24nD5RlStw atdR39ONK/wS+4CkdxMacaoOVCEY3UBKgERGmIUZPGkhfjfGuT9kg4sCID6eK7PsDAWb eK7fefDlVnr0lFGd48w4RLbdy39lgOmJXnyMHoXjOcTgIpIWOrpiqFtjl4Gu3Xxnfypr OzCRlQXB/MhrOfGMDusATJTNcNkowH+jb9tymMboVrtM53hIg0BP30E+9E130U6PLvj8 oLBQ4OvT4+dlIH20bodHjOpL58eQT82ZhaWcvb4XvUT1IFcEGO8+WplAfWq3XsqyVdQA mq1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M9B5Uvew9xAvuUMjh9ofeJ7p8pQRcV7VkL83dSaI60U=; fh=eCes8CmiUeJJolOzoGD0yJZNwwU/ldG5b8OJj4IcBPc=; b=CORobSz2ijvJ5qOK7fmwSSUMPGKsdT0Y/jnbwprnd5OyJd2OqLunFKekARg9u4fdcN cSWtkdANsSey+iRL8NbRGx01b+YC5Nm4Yg7CStQgm0NoH/gDBhwxqMQPdcDY0LFB+eUU aMULl5BEilwJ4tXABhJMlFC5H3WPjtDbt5dVLLk4IRhamHMUXPvZwOqPBa8sJ4WRQ0M/ LAltqrQj9/1xCSmMA84NbyLf92KzIp6kM01XE/bAeSFHh+QCAjmV7e5j2ZpxgQQGrGkC 07u2Jpsh/BtpaFCVKCejn8OvqKHHxg8i3u91vqH/Rp4oDuquNf8PoqKZRhVDmovakrRw VRGQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=Z9O9xi7d; arc=pass (i=1 dkim=pass dkdomain=resnulli-us.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-81415-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81415-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q7-20020ae9e407000000b00787ccd4fb28si3075436qkc.206.2024.02.26.04.54.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 04:54:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81415-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20230601.gappssmtp.com header.s=20230601 header.b=Z9O9xi7d; arc=pass (i=1 dkim=pass dkdomain=resnulli-us.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-81415-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81415-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1F9291C225C5 for ; Mon, 26 Feb 2024 12:54:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 244D580021; Mon, 26 Feb 2024 12:53:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="Z9O9xi7d" Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B56217F498 for ; Mon, 26 Feb 2024 12:53:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708952036; cv=none; b=JYqpApENRGelN2+H7nIl+uOCq9eadAUb+TEc4dEJdl7cywhDyrYakUAhAUX+f89qGh1W/uOE/PqA2+qdTZI+uzCF7q5SSrdzwM54VBiq3URCMW5Zp/pMmJD9SANvhbeOCD5pveFfhHWrEzPteHuTA8OUskAc7KkrZ7Mz6f41a14= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708952036; c=relaxed/simple; bh=M9B5Uvew9xAvuUMjh9ofeJ7p8pQRcV7VkL83dSaI60U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yjc2cdCefQ088cXozNgbTQStLY6vDahi6D+QcXNMAgsykUL9V8cUPdUakfE8bVFezxHHN+9MD5haI6Q2qCMM+e64fnY19vNzhh4h5QKreRsZpCzA7ruUrECFRaH/LK/v+o6Ng4r5TXYdY4iP0eaQgjscJEwYmlNWpIx6JYcaRU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=Z9O9xi7d; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-33d509ab80eso1324038f8f.3 for ; Mon, 26 Feb 2024 04:53:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1708952033; x=1709556833; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M9B5Uvew9xAvuUMjh9ofeJ7p8pQRcV7VkL83dSaI60U=; b=Z9O9xi7dxpp7cx8NUpGPeXLqnAP2bM+5vufZEBB1FbO1LLRHK0w7C3uEnE0ZZcUk7D 124lgXKsnGfHmrA4JsiSP9SPRg6yLCczezFbJmprkr4qxQGgqoodV328KJV9p/fclPlL /t1CMNe2Ivu9vZ8Tu6DAz2EvfMxiNvPiex+FxhEdSLVFJLxnMkwEBk2DlQoAD7PIkBRg 0d/DI1vyiMjIvrtg4lYKZ6NPl2oNtwZf0mjP7vOsdtIC2KZNrVV4S80W6wyYSyyt8edq hcgoawZbKD/+Y5FuVunhZxUj5foe0vgWFjwODqpyV6rtD6MrnCp1Edqam0jlnvdiZ2jm 85hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708952033; x=1709556833; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M9B5Uvew9xAvuUMjh9ofeJ7p8pQRcV7VkL83dSaI60U=; b=ccKV1PZHRhbIrDF0s4keRHSe31lcbRi57atFYRXXavge6+LF+RmtwDpnGRbQHyWRNw bVs4xtmdLzzWsMmjoyimqjJ7i/eoyleLJG8MjgCUtb4PkYE1lBVRX68GpyngO4nfnbiK oH7nrx0kL8S+OOihN9wKRsyjnohPsuUgR+74VkDiosqakfxiWsHEzGe3+GPho1ABcrNU 05QqTpyoTpBCpiC9vQa/c9auNWzEU9d4+a4S9TXqITkhvaB8X1LRNiYfipBmR0XsFEne 4lva8LIO8CxVsiM7B+h2BUE+fC7fUbYIDD2N5kw43omjX7X94yhdGdXMjlo3quAUn4T0 Di6A== X-Forwarded-Encrypted: i=1; AJvYcCXT728KGC/aBp8/SDOddW2nkk5+QpEM7MU8+en59quCxecaIi2m28UiOBmU7SszR+I6O/ZG9uljSKddb8BKpgR4jFuyMbCYtJuy7dlh X-Gm-Message-State: AOJu0YxbyoZ4r98+Skn2tQ/lIdoZMu9+QCmvYPHb+BXvLlyOR62j7Qpf MEGo5OYbkFKFoHFIsoDPMKL4G9UR6UvcLtE8fpGN5PxOKOjCcTLB+G1sXBocPbs= X-Received: by 2002:a5d:5b85:0:b0:33d:87e9:5900 with SMTP id df5-20020a5d5b85000000b0033d87e95900mr4608962wrb.62.1708952033028; Mon, 26 Feb 2024 04:53:53 -0800 (PST) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id g16-20020adffc90000000b0033d3b8820f8sm8172448wrr.109.2024.02.26.04.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 04:53:52 -0800 (PST) Date: Mon, 26 Feb 2024 13:53:51 +0100 From: Jiri Pirko To: Jones Syue =?utf-8?B?6Jab5oe35a6X?= Cc: "netdev@vger.kernel.org" , "j.vosburgh@gmail.com" , "andy@greyhouse.net" , "davem@davemloft.net" , "edumazet@google.com" , Jakub Kicinski , "pabeni@redhat.com" , "corbet@lwn.net" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v3] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with __agg_has_partner Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Mon, Feb 26, 2024 at 03:24:52AM CET, jonessyue@qnap.com wrote: >Replace macro MAC_ADDRESS_EQUAL() for null_mac_addr checking with inline >function__agg_has_partner(). When MAC_ADDRESS_EQUAL() is verifiying >aggregator's partner mac addr with null_mac_addr, means that seeing if >aggregator has a valid partner or not. Using __agg_has_partner() makes it >more clear to understand. > >In ad_port_selection_logic(), since aggregator->partner_system and >port->partner_oper.system has been compared first as a prerequisite, it is >safe to replace the upcoming MAC_ADDRESS_EQUAL() for null_mac_addr checking >with __agg_has_partner(). > >Delete null_mac_addr, which is not required anymore in bond_3ad.c, since >all references to it are gone. > >Signed-off-by: Jones Syue Reviewed-by: Jiri Pirko