Received-SPF: pass (google.com: domain of linux-kernel+bounces-81428-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240112035039.833974-1-maobibo@loongson.cn> <b7c08e0d-bd7d-aea9-250e-1649e95599b7@loongson.cn>
 <fbd8b226-1972-322b-d884-bb41d262dd16@loongson.cn>
In-Reply-To: <fbd8b226-1972-322b-d884-bb41d262dd16@loongson.cn>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Mon, 26 Feb 2024 20:58:00 +0800
Message-ID: <CAAhV-H6wC95cgo=f2-kx6viSKUPo6Mty+Hrr7XJ=7pKJeHbQOA@mail.gmail.com>
Subject: Re: [PATCH] LoongArch: KVM: Remove unnecessary CSR register saving
 during enter guest
To: zhaotianrui <zhaotianrui@loongson.cn>
Cc: maobibo <maobibo@loongson.cn>, kvm@vger.kernel.org, loongarch@lists.linux.dev, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

LGTM, queued for loongarch-kvm.

Huacai

On Thu, Feb 1, 2024 at 11:30=E2=80=AFAM zhaotianrui <zhaotianrui@loongson.c=
n> wrote:
>
> Reviewed-by: Tianrui Zhao <zhaotianrui@loongson.cn>
>
> =E5=9C=A8 2024/1/31 =E4=B8=8A=E5=8D=8811:48, maobibo =E5=86=99=E9=81=93:
> > slightly ping :)
> >
> > On 2024/1/12 =E4=B8=8A=E5=8D=8811:50, Bibo Mao wrote:
> >> Some CSR registers like CRMD/PRMD are saved during enter VM mode. Howe=
ver
> >> they are not restored for actual use, saving for these CSR registers
> >> can be removed.
> >>
> >> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> >> ---
> >>   arch/loongarch/kvm/switch.S | 6 ------
> >>   1 file changed, 6 deletions(-)
> >>
> >> diff --git a/arch/loongarch/kvm/switch.S b/arch/loongarch/kvm/switch.S
> >> index 0ed9040307b7..905b90de50e8 100644
> >> --- a/arch/loongarch/kvm/switch.S
> >> +++ b/arch/loongarch/kvm/switch.S
> >> @@ -213,12 +213,6 @@ SYM_FUNC_START(kvm_enter_guest)
> >>       /* Save host GPRs */
> >>       kvm_save_host_gpr a2
> >> -    /* Save host CRMD, PRMD to stack */
> >> -    csrrd    a3, LOONGARCH_CSR_CRMD
> >> -    st.d    a3, a2, PT_CRMD
> >> -    csrrd    a3, LOONGARCH_CSR_PRMD
> >> -    st.d    a3, a2, PT_PRMD
> >> -
> >>       addi.d    a2, a1, KVM_VCPU_ARCH
> >>       st.d    sp, a2, KVM_ARCH_HSP
> >>       st.d    tp, a2, KVM_ARCH_HTP
> >>
> >> base-commit: de927f6c0b07d9e698416c5b287c521b07694cac
> >>
>
>