Received-SPF: pass (google.com: domain of linux-kernel+bounces-81450-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 26 Feb 2024 16:11:05 +0300
From: Serge Semin <fancer.lancer@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>, 
	Jiaxun Yang <jiaxun.yang@flygoat.com>, Andrew Morton <akpm@linux-foundation.org>, 
	Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mips: cm: Convert __mips_cm_l2sync_phys_base() to
 weak function
Message-ID: <6n2synlvazjh2gptxtioju7dciwshwqyei4xnfzorns66b3hqx@c7blt5kwnpbl>
References: <20240226105427.7191-1-fancer.lancer@gmail.com>
 <20240226105427.7191-2-fancer.lancer@gmail.com>
 <34af21b5-a878-418e-a70b-299cab61b37e@app.fastmail.com>
 <y2lxeu5uvj7ezlv7kf6lox5e5xprmvrhqmf3gvzjsatlrrlub7@mvqzoyq5mnvd>
 <cc9e02b3-57df-4a7d-bd21-2d574bf4b878@app.fastmail.com>
 <simbnmm644ouv3kc3agsxiub6fzg6advihkqsbjzgmb44nmuxv@ktgkhn3kr43z>
 <60e60313-3cc4-452f-a222-aadd7728183d@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <60e60313-3cc4-452f-a222-aadd7728183d@app.fastmail.com>

On Mon, Feb 26, 2024 at 01:29:54PM +0100, Arnd Bergmann wrote:
> On Mon, Feb 26, 2024, at 13:20, Serge Semin wrote:
> > On Mon, Feb 26, 2024 at 01:04:33PM +0100, Arnd Bergmann wrote:
> >> On Mon, Feb 26, 2024, at 12:27, Serge Semin wrote:
> 
> > I see your point now. Thanks for clarification. IMO it would be less
> > readable due to the ifdef-ery and the new config, and less
> > maintainable due to the conditional compilation, but would provide a
> > more performant solution since the compiler will be able to inline the
> > singly used static method. Basically you suggest to emulate the weak
> > implementation by an additional kernel config.
> 
> I mean the kernel config that you already need here, since
> the strong version of the function is already optional.

Why would I need it if after this patch is applied the
mips_cm_l2sync_phys_base() method will be converted to a global weak
implementation?

> 
> > Not sure whether it would be better than a well-known
> > weak-attribute-based pattern. Anyway let's wait for the
> > Thomas' opinion about your suggestion. If he thinks
> > it would be better I'll update the patches.
> 
> Weak functions are not used all that much outside of a
> couple of parts of the kernel. There is a lot of them
> in drivers/pci/, a little bit in acpi and efi, and
> then a bit in arch/*/, though most of that is in mips.

+ a lot of them in kernel/*, some in mm/* .)

> 
> Ifdef checks in .c files are not great, but at least they
> are much more common than __weak functions and self-documenting.

Ok. I don't have concretely strong opinion about what is better. Let's
wait for what Thomas thinks about this.

-Serge(y)

> 
>      Arnd