Received-SPF: pass (google.com: domain of linux-kernel+bounces-81462-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Peng Fan <peng.fan@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, "sudeep.holla@arm.com"
	<sudeep.holla@arm.com>, "cristian.marussi@arm.com"
	<cristian.marussi@arm.com>, "linus.walleij@linaro.org"
	<linus.walleij@linaro.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-gpio@vger.kernel.org"
	<linux-gpio@vger.kernel.org>, Aisheng Dong <aisheng.dong@nxp.com>, Nitin Garg
	<nitin.garg_3@nxp.com>, Ranjani Vaidyanathan <ranjani.vaidyanathan@nxp.com>,
	Ye Li <ye.li@nxp.com>
Subject: RE: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type
Thread-Topic: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type
Thread-Index: AQHaZicCkH+tvBnis0Gt2w9aePsLUbEcn84w
Date: Mon, 26 Feb 2024 13:16:51 +0000
Message-ID:
 <DU0PR04MB94172086AB4EF0389B78CA6A885A2@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240223071557.2681316-1-peng.fan@oss.nxp.com>
In-Reply-To: <20240223071557.2681316-1-peng.fan@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?yg13sSSeA8tKzX5VRkGNOt+ZoAbrIBzZq19Fw1L6JfzuD46zEcXwEwOP+ciC?=
 =?us-ascii?Q?SuRtbLxwTKYAyEynWnUCcQ/u7TmqzGIqVTtf+zietdbh23Gp5ZQnoYBdurDC?=
 =?us-ascii?Q?53zn1FGu6czGU+fCigQ0hArJ+0yVOx6hI/XN/Ns6TUtpizYovOSgJ4KLl+PR?=
 =?us-ascii?Q?PIVfGe1s9Fr3euP/PJ6t2C2exHGJmsWqPQ4/Iw2RGpOuPCuGIRodgsNetk1C?=
 =?us-ascii?Q?pWyAsj9aW19wzI3TFuqYPnHlUY0tEzvkm+2U6D97pqzgE+lnBOh4mun2jfOx?=
 =?us-ascii?Q?po8piOXWQ7HslfNzMpHDacPAjDOeZ+Bw2YuSI6+SzhUcrugnWGEtJsgiz2gP?=
 =?us-ascii?Q?K6e1uLHmFU52g2g0GZiIfUo7dhK2louZ7YPU7spQGiq9dBhAPOfOx6g6HD57?=
 =?us-ascii?Q?VpKklw4ZeSrIfEV/pUbxR9gTFWM5eT5wK19dWwQxf7ATjSurPo+cfPoc9jfn?=
 =?us-ascii?Q?Jt9s3FAfrO4cq6EpD3Y1xkIkUng6jBhCdVCzjW728kVfKa5FnfoWdqiRI5kY?=
 =?us-ascii?Q?STpfIksAbzPGIOXtUvBmS9PXlgNKmMVely0o+PLoxOPXkl7gLB7O+GO5BLJX?=
 =?us-ascii?Q?sMD4Pr534GqkdfL2ZXDR3f7D6cYFQVSeDuJZq0AimlJaKX/AoOq3msuZpuz9?=
 =?us-ascii?Q?k0sOGCQ+9ZsU6MTCMrsVA9H0k1rfc+UhwtBymvh7x17KiKarp2mRmCPSmo1V?=
 =?us-ascii?Q?RYI9cE3URkC7MrxIx6zBngD0wYbZ1Mnv7409DS97LZXUplhPY54YKpQo/pnF?=
 =?us-ascii?Q?bH7obaUH7PoD9Te1hWcFznZ/tfi9N2BTGjwMoSZz5HbjykktDUMVRBfz/3/h?=
 =?us-ascii?Q?da3lwEaFK/bBWWPZbZBotDBxSuk3psXXBTaqfdS7gQjrmnNY1gWzBiHTu5oX?=
 =?us-ascii?Q?L9lmt0RA4e8I8eDJYsu8+VZLW2+2ZfGKn+ocmZt/XM1JZyqcCqTlNBkuQZyF?=
 =?us-ascii?Q?8YgfVqMigq4hJOIT4Kah1hUh5lQdyeYnMKfWVBwPKvgww8VZ9AytVbLUaMsW?=
 =?us-ascii?Q?5av8p1GL65sRqLl8FGsuEH3LeOI1YRp2mm71wIsoG2wwfm4rEC9/8sKLFsAu?=
 =?us-ascii?Q?VZsYD9s+QzsADnxOZ2WxrjrbmvU8qPbIDVSntReT5910NgwEe0gqBDtURA/F?=
 =?us-ascii?Q?Vp93P4boYudZdCIMRxMoizA/hPB0KrnrshdZJ96w1ywadDeFLcjhtvQ6xlAh?=
 =?us-ascii?Q?v0LgvRQTBP1P9v1MufLEfxu+8KN8U6E42q0llLgreVh/aSedYCDbOU4+m5w6?=
 =?us-ascii?Q?Wcl1Nq8ZCJMqIi53T6BY4dWHYh1JsNCHcmtO609z3yZv6wXyUgy2yrVxp34q?=
 =?us-ascii?Q?LjEUdzG6zFlxIYFDnGQXfHU1JwXq9ivdzMj05cOyip7NtNzSRj1LCCyKL1ho?=
 =?us-ascii?Q?k9pngMaL36E0LB4MGYmLibQV74RBNCKqkWJXwzPbUSftTWUlC09hGPYRTQ9g?=
 =?us-ascii?Q?8lz7Ua5LbUeYv0sUPGIlBraRuvHsNPrrZXsnXyNCkUJaQCx16SFbd18oa8fO?=
 =?us-ascii?Q?Iw07p9yx1go+k5MaQck89jw86lF/OOEaRGHjbX0KZ3GniesaraYGp4WJWqlU?=
 =?us-ascii?Q?ET3jyc/nHkTky9iQAHw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 446cf428-be6b-4836-8465-08dc36cd3224
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Feb 2024 13:16:51.6915
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p+mDW1FZGHu5EC8ClyuRefjk+Q0vUuMX9q5g5VDklIcgZIIuA46IVaHdB8NApeMYZWLsisdAOsmB1/uygGUj5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8405

Hi Linus, Sudeep, Cristian,

> Subject: [PATCH] pinctrl: scmi: support i.MX OEM pin configuration type

Sorry to ping early, but this impacts the design and i.MX95 SoC upstream(
although I removed pinctrl to let uboot init pinmux as of now), so I would
like see whether are you ok with the approach or not. This is the best as
of now I could think out to not adding more size to firmware and make the
dts format similar as previous i.MX.

Thanks,
Peng.

>=20
> From: Peng Fan <peng.fan@nxp.com>
>=20
> i.MX95 System Manager FW supports SCMI PINCTRL protocol, but uses OEM
> Pin Configuration type, so extend the driver to support custom params.
>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>=20
> V1:
>  Based on https://lore.kernel.org/all/20240223-pinctrl-scmi-v4-0-
> 10eb5a379274@nxp.com/
>  This is an reimplementation for supporting i.MX95 OEM settings.
>  With this patch, the dts will be like:
>=20
> +#define IMX95_PAD_SD1_CLK__USDHC1_CLK(val)	\
> +	sd1clk {				\
> +		pins =3D "sd1clk";		\
> +		imx,func-id =3D <0>;		\
> +		imx,pin-conf =3D <val>;		\
> +	}
>   ....
> +
> +	pinctrl_usdhc1: usdhc1grp {
> +		IMX95_PAD_SD1_CLK__USDHC1_CLK(0x158e);
> +		IMX95_PAD_SD1_CMD__USDHC1_CMD(0x138e);
>  ....
> +	};
>=20
>  drivers/pinctrl/pinctrl-scmi.c | 10 ++++++++++  drivers/pinctrl/pinctrl-=
scmi.h
> | 15 +++++++++++++++
>  2 files changed, 25 insertions(+)
>  create mode 100644 drivers/pinctrl/pinctrl-scmi.h
>=20
> diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scm=
i.c index
> f2fef3fb85ae..e58f1aaf9963 100644
> --- a/drivers/pinctrl/pinctrl-scmi.c
> +++ b/drivers/pinctrl/pinctrl-scmi.c
> @@ -19,6 +19,7 @@
>  #include <linux/pinctrl/pinctrl.h>
>  #include <linux/pinctrl/pinmux.h>
>=20
> +#include "pinctrl-scmi.h"
>  #include "pinctrl-utils.h"
>  #include "core.h"
>  #include "pinconf.h"
> @@ -472,6 +473,13 @@ static const struct pinconf_ops
> pinctrl_scmi_pinconf_ops =3D {
>  	.pin_config_config_dbg_show =3D pinconf_generic_dump_config,  };
>=20
> +static const struct pinconf_generic_params pinctrl_scmi_oem_dt_params[] =
=3D
> {
> +	{"imx,func-id", IMX_SCMI_PIN_MUX, -1},
> +	{"imx,daisy-id", IMX_SCMI_PIN_DAISY_ID, -1},
> +	{"imx,daisy-conf", IMX_SCMI_PIN_DAISY_CFG, -1},
> +	{"imx,pin-conf", IMX_SCMI_PIN_CONF, -1}, };
> +
>  static int pinctrl_scmi_get_pins(struct scmi_pinctrl *pmx,
>  				 unsigned int *nr_pins,
>  				 const struct pinctrl_pin_desc **pins) @@ -
> 548,6 +556,8 @@ static int scmi_pinctrl_probe(struct scmi_device *sdev)
>  	pmx->pctl_desc.pctlops =3D &pinctrl_scmi_pinctrl_ops;
>  	pmx->pctl_desc.pmxops =3D &pinctrl_scmi_pinmux_ops;
>  	pmx->pctl_desc.confops =3D &pinctrl_scmi_pinconf_ops;
> +	pmx->pctl_desc.custom_params =3D pinctrl_scmi_oem_dt_params;
> +	pmx->pctl_desc.num_custom_params =3D
> +ARRAY_SIZE(pinctrl_scmi_oem_dt_params);
>=20
>  	ret =3D pinctrl_scmi_get_pins(pmx, &pmx->pctl_desc.npins,
>  				    &pmx->pctl_desc.pins);
> diff --git a/drivers/pinctrl/pinctrl-scmi.h b/drivers/pinctrl/pinctrl-scm=
i.h new
> file mode 100644 index 000000000000..fcc61bc19c98
> --- /dev/null
> +++ b/drivers/pinctrl/pinctrl-scmi.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright 2024 NXP
> + */
> +
> +#ifndef __DRIVERS_PINCTRL_SCMI_H
> +#define __DRIVERS_PINCTRL_SCMI_H
> +
> +/* OEM VENDOR Pin Configuration Type */
> +#define IMX_SCMI_PIN_MUX	192
> +#define IMX_SCMI_PIN_CONF	193
> +#define IMX_SCMI_PIN_DAISY_ID	194
> +#define IMX_SCMI_PIN_DAISY_CFG	195
> +
> +#endif /* __DRIVERS_PINCTRL_SCMI_H */
> --
> 2.37.1