Received-SPF: pass (google.com: domain of linux-kernel+bounces-81473-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f142baba-619c-940c-9ceb-7c0d9c8ca7dc@quicinc.com>
Date: Mon, 26 Feb 2024 18:52:49 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH vRFC 3/8] treewide: rename firmware_request_platform()
Content-Language: en-US
To: Greg KH <gregkh@linuxfoundation.org>
CC: Luis Chamberlain <mcgrof@kernel.org>, <russ.weight@linux.dev>,
        <rafael@kernel.org>, <linux-kernel@vger.kernel.org>,
        <cocci@systeme.lip6.fr>
References: <20240222180033.23775-1-quic_mojha@quicinc.com>
 <20240222180033.23775-4-quic_mojha@quicinc.com>
 <2024022347-ribcage-clench-37c4@gregkh>
 <Zdi2odoYPBWywOXn@bombadil.infradead.org>
 <2024022323-accustom-eradicate-8af4@gregkh>
 <Zdj1K28NBfGfSJ-0@bombadil.infradead.org>
 <2024022452-unwilling-pancake-3b2a@gregkh>
 <ed9f2b75-38d3-8562-0476-2200e201d4c9@quicinc.com>
 <2024022644-trough-humility-12b8@gregkh>
From: Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <2024022644-trough-humility-12b8@gregkh>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/26/2024 6:39 PM, Greg KH wrote:
> On Mon, Feb 26, 2024 at 04:22:09PM +0530, Mukesh Ojha wrote:
>>
>>
>> On 2/24/2024 11:06 AM, Greg KH wrote:
>>> On Fri, Feb 23, 2024 at 11:42:35AM -0800, Luis Chamberlain wrote:
>>>> On Fri, Feb 23, 2024 at 04:33:40PM +0100, Greg KH wrote:
>>>>> On Fri, Feb 23, 2024 at 07:15:45AM -0800, Luis Chamberlain wrote:
>>>>>> On Fri, Feb 23, 2024 at 07:21:31AM +0100, Greg KH wrote:
>>>>>>> On Thu, Feb 22, 2024 at 11:30:28PM +0530, Mukesh Ojha wrote:
>>>>>>>> Rename firmware_request_platform() to request_firmware_platform()
>>>>>>>> to be more concrete and align with the name of other request
>>>>>>>> firmware family functions.
>>>>>>>
>>>>>>> Sorry, but no, it should be "noun_verb" for public functions.
>>>>>>
>>>>>> News to me, do we have this documented somewhere?
>>>>>
>>>>> Not really, but searching makes it nicer.
>>>>>
>>>>> And yes, I violated this in the past in places, and have regretted it...
>>>>
>>>> Care to share a few examples of regret?
>>>
>>> 	get_device()
>>> 	put_device()
>>> 	kill_device()
>>>
>>> vs. a saner:
>>> 	kobject_get()
>>> 	kobject_put()
>>> 	kobject_del()
>>>
>>> Learn from the mistakes of my youth please :)
>>
>> Thanks for the history.,
>> In that case, should we fix this verb_noun cases ?
>>
>> request_firmware()
>> request_firmware_into_buf()
>> request_firmware_nowarn()
>> request_firmware_direct()
>> request_firmware_cache()
>> request_partial_firmware_into_buf()
>> release_firmware()
> 
> That would provide consistency, right?

Yes, Below names look better..

firmware_request()
firmware_request_into_buf()
firmware_request_nowarn()
firmware_request_direct()
firmware_request_cache()
firmware_request_partial_into_buf()
firmware_release()

@Luis/Others, Can we do this change ?

-Mukesh
> 
> thanks,
> 
> greg k-h