Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1300391rbb; Mon, 26 Feb 2024 05:23:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUGZGG/lAnjhuugMkSL/6lLT2ba/M7OYe4+DZDM09wrw5v8/COFpjFV+Xx1ACvQ8X9QJOk81tZB/x/T2pApe9jnBvtHHtHi940W8V2kzA== X-Google-Smtp-Source: AGHT+IFHAH8tVhvFN3ULyPnYHPjH9jdxOovAJQ73VICDxOXRGwqoXKidxnZ8v+1dferL+xGvECON X-Received: by 2002:a17:906:f854:b0:a43:21fb:d0db with SMTP id ks20-20020a170906f85400b00a4321fbd0dbmr2644910ejb.10.1708953830567; Mon, 26 Feb 2024 05:23:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708953830; cv=pass; d=google.com; s=arc-20160816; b=bLm04rVQu70mzuXX8+/D1I6he4N5otK4f2mFF8C1GS0glOsJPaH0By9peByozNymt+ 4LOxcsEUTXwi8rdjLzI83IlQYf5w85TQXJeAcv3fb0uamKB2mdKS/CUIJjQr7GR0urNf 2rXmFjVT68mTT/ezjoW+5XkbspNvneWVbDdL23WPDxUas4z8An+25dup9rNBS1B1FV7+ b3Q6UEUGa+Y4p8Lg7RGvR8N/yRKJ27RXg+w53wwqv4KonPOyCdyslr+XeLbqsZb95V2Y d+o71/cnuYVvxi/za2D0DLzKSqvZ1VuEfmjsEHCbNdOCDuh0K+jHekWFjAqvTTr7XQVY 7/AA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=m/tSf7s6oMy9b/w5e5M2eW7k6sYnkwvDfWsBiPp021M=; fh=8y3PF0Avsc4osEl4+vest2v7XybeOK5+oEln5/Kdrf4=; b=HmtgqupWuk2oDn/w/z2rQI6TfB223iNWM7Q6grkdw2NnXcCdHQq0I9NlvZ3yFIM11T 6bWukFamJzI+vTEMNPuc4DXqf3pSM1NR7eOrCa/tSZxQCYgEmm3mo7n3W6NWaz2lnWrN ZGZhKuGW5kl7HB68Qp4arxqtE636AmEMvkQYxD5Eyt9PL4CVv0PMUPKzugBraccMlvPe dlE96pFk6Y0lrnbFmOjBUoabyeSI7LS+ynmakZ58uw5Q3FSzK9nlsW57KtAX17HEq3PY U/vEzS34uEFVoiAq6SwqDgl4ax26BhuKuNCImaDeBrC2dacYReXOPH5l1Rcbe8JFzms7 CpaQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KglfUhfF; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-81474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81474-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id r21-20020a170906365500b00a42f385aed9si1992784ejb.561.2024.02.26.05.23.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 05:23:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KglfUhfF; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-81474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81474-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4C1FF1F277C7 for ; Mon, 26 Feb 2024 13:23:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 859B8128378; Mon, 26 Feb 2024 13:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KglfUhfF" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 770031CFA9; Mon, 26 Feb 2024 13:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708953821; cv=none; b=uHL3UOMIQgqPvH2M1lNf1mM6n0lztxDg9ZHBDOWIfrsgNlIdxD+EMh99NbcQfqujkdYLHhsC3AByy4nKXxKJ0UcYx6WdR5Kz4DOvIi1CcfXxoMqbq50n7andSyBHybZ9lCvKR+2qgA85eQ2Ms1QgVCQa1Bi99cX+NlV441knj+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708953821; c=relaxed/simple; bh=FSsP/gIPNxGhuPogvvjZRJ+z4u9hWzSoEWz5moPh4EQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CMCR9O+euE+5D0sGdRqgZ8l2WfXhyP5R79sQoFK7IUqtBlC6F5gsOrhFyBJRMUyUuDO31sAibZoPjirzkk45KVPQQEMfIDCqDCUIGGokUJkXec1+vX0etwCrUr825/Z7yEpbTn41qQ2nw2+UUvqheOwdc05kk2glCHubPayLQBw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=KglfUhfF; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=m/tSf7s6oMy9b/w5e5M2eW7k6sYnkwvDfWsBiPp021M=; b=Kg lfUhfFNbD/uo2XP4HWJqG3U9zZ1JfRKrGuWh/lAEcsrcl1TmGflONf4sc1z8+iB08sImLBd6SH2tt q1sd9sIcHnRqorzaGs6loyNxajtfsSnmsJhfngCg1f8IXWqozs5MklUMmOZrS47Ad14jTAlhsXNIe 8N3urXo81ehQ6iI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1reaxB-008iyE-Vr; Mon, 26 Feb 2024 14:23:33 +0100 Date: Mon, 26 Feb 2024 14:23:33 +0100 From: Andrew Lunn To: Steffen =?iso-8859-1?Q?B=E4tz?= Cc: Fabio Estevam , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , "Russell King (Oracle)" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 1/2] net: dsa: mv88e6xxx: fix marvell 6320/21 switch probing Message-ID: References: <20240226091325.53986-1-steffen@innosonix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240226091325.53986-1-steffen@innosonix.de> On Mon, Feb 26, 2024 at 10:13:23AM +0100, Steffen B?tz wrote: > As of commit de5c9bf40c45 ("net: phylink: require supported_interfaces to > be filled") > Marvell 88e6320/21 switches fail to be probed: > > ... > mv88e6085 30be0000.ethernet-1:00: phylink: error: empty supported_interfaces > error creating PHYLINK: -22 > ... > > The problem stems from the use of mv88e6185_phylink_get_caps() to get > the device capabilities. Create a new dedicated phylink_get_caps for the > 6320 and 6321 to properly support their set of capabilities. > > Fixes: de5c9bf40c45 ("net: phylink: require supported_interfaces to be filled") > Signed-off-by: Steffen B?tz Reviewed-by: Andrew Lunn Andrew