Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1303332rbb; Mon, 26 Feb 2024 05:29:48 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWVCS6NpEvddNiA/4ef4lDLXwQbcPhfAanBslehfbCRnsLSDVWXY+x1cXlBbG9DHWNuP4B8FaoDoAq24gvKakLM8KtH+5vQgslAIkpVLQ== X-Google-Smtp-Source: AGHT+IGDILldskAHSK8ys0HUlMxGmT5Wg4oNydDDHkBd10gfRBUq0T7ab/m02SQP/jjCBDJrod8X X-Received: by 2002:ac8:7d04:0:b0:42e:6468:6f99 with SMTP id g4-20020ac87d04000000b0042e64686f99mr8979212qtb.6.1708954188527; Mon, 26 Feb 2024 05:29:48 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708954188; cv=pass; d=google.com; s=arc-20160816; b=Og8uBImAwdEkDT6SG5TFjtP/gvNbn6gKLXWwVBOZhJ8mSoBVuXv1MF57VZ7yB7c/It OE4zwiAXZtup9IuGC7uOT6oMPLjmBj2ocI827OiD34ScMz3ohKMezg5NbKdnfB19JoG7 xswJYm8FG4OFcufcaJoIfwxhqc84QUNilyGKVP2fN7vph7jN92ZHz7HBcLiiwbpUi9PM TJWRemxe5S9F0CKZTgDxuHevfbi/3qnAyAR/cTixh7VuSoBv/4faYI+KI9i0msLy1VqK HwjkDupVOG1BCPSA794x3r0+K8qO6b9Q/pi0gWapE5UXnXFxpxKWr6lBHj0P8LQec5vu qx2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OIChTOJqIAL3o/KQWDyOknyuQUwlXKRD2jZImdPr+oI=; fh=a8bId+zjJV8hHJmBaAT1Kwo02VdONIGGKX3rlY32j0Q=; b=entUZQVJViY3Q70qfrmpR/UubCed5uSTsjeAFH8MWLnl+nY3d9bMe4svhMe66Pg4rc nBFXN3gduuQEuvK1SnxCfZ/Ov5kN0L3hzUJ190UN5Y19VbqobZn0shT58vyPXzUMuCdm hHADEhKxiKAykokf45C5i+Jw2TLRM6T5HockA4gwdko+T+kMAaF+LMxiKhxhCaQ2U50c 70lo1Y/zV0wjwJglpVUuf/YR2uewAMx6i1t4CJ1WS0g9Ys1KVHnioRRYJhVSWjEZoy32 S+jbfmvJW0QLv0WHg51sHJmYGqA5+6VR2ig3ltDDic1YBCLxUXu2KDCNRmfQdn1qzWfH HCsA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="o98Mo/78"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-81488-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81488-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id n23-20020ac86757000000b0042e7068f105si4886660qtp.638.2024.02.26.05.29.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 05:29:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81488-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="o98Mo/78"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-81488-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81488-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 492451C29629 for ; Mon, 26 Feb 2024 13:29:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3C6E712881C; Mon, 26 Feb 2024 13:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="o98Mo/78" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66A4D128363; Mon, 26 Feb 2024 13:29:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708954182; cv=none; b=VoSM7JMgd6+NCddvA1cCjxdOcBxueENDEnLLHrGg3dou2Q8kIobj5FfoWSv+qGXcLxRX5BfD/NuNdZ2gHyB0x0aVAQ1pbhXr3pP9klYAk2mAK4aCfSB1iomK4Eimb7OB7rBh0YSAKOteSS8JmZ0E7Unh0FDoGduvNE/Sk8iy42o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708954182; c=relaxed/simple; bh=67jJEXxyLq9p2Ef/4B1PzCLF2zQY+FmX1wTG8Gq5oXc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tj4UIFg43iRXGvcYC+pf497zXffb3rh6sORkvbLlKgfPtk8i8/Hj4NQgEdKLt6cbrBz2V7sVgGgtqAW/7WTCDIYhWSaQJa2D8BQ9H3zgUwi6E5c7qpXtzJS7pMkmOxauapol4W8ALxzhm/ahVUn86bjC21zkPCT/Ua5Td7URJIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=o98Mo/78; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA4CAC433F1; Mon, 26 Feb 2024 13:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1708954182; bh=67jJEXxyLq9p2Ef/4B1PzCLF2zQY+FmX1wTG8Gq5oXc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o98Mo/78L3E7sA77ucBISa4JtTv2jdikLLb0VUxng7vucJvL8JcQeWlkUskMHgAxF THupOv/r8Y5Elk/G4hB2rW1NgQZySrafB3w2YOuGyZfJGibJEm0tXrHpyD5SLQ5W3j 2HaXeNBuPkdVlRLeai8qrhhrmRz0Thwvl1YXOn0k= Date: Mon, 26 Feb 2024 14:29:39 +0100 From: Greg KH To: Rui Qi Cc: bp@alien8.de, mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com, jpoimboe@redhat.com, peterz@infradead.org, mbenes@suse.cz, stable@vger.kernel.org, alexandre.chartre@oracle.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] objtool: is_fentry_call() crashes if call has no destination Message-ID: <2024022656-anemia-slacked-e1d4@gregkh> References: <20240226094925.95835-1-qirui.001@bytedance.com> <20240226094925.95835-2-qirui.001@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240226094925.95835-2-qirui.001@bytedance.com> On Mon, Feb 26, 2024 at 05:49:23PM +0800, Rui Qi wrote: > From: Alexandre Chartre > > commit 87cf61fe848ca8ddf091548671e168f52e8a718e upstream. > > Fix is_fentry_call() so that it works if a call has no destination > set (call_dest). This needs to be done in order to support intra- > function calls. > > Signed-off-by: Alexandre Chartre > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Miroslav Benes > Acked-by: Josh Poimboeuf > Link: https://lkml.kernel.org/r/20200414103618.12657-2-alexandre.chartre@oracle.com When you forward a patch on for inclusion, you too have to sign off on it. Please do so for all of these commits. And we recieved a few different copies of this series, please resend a v2 series so we know which one is the correct one to review. thanks, greg k-h