Received-SPF: pass (google.com: domain of linux-kernel+bounces-81493-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <5cdbfed3-62cd-41fd-b71a-5c6b1940ceb6@kernel.org>
Date: Mon, 26 Feb 2024 05:33:14 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] zonefs: remove SLAB_MEM_SPREAD flag usage
Content-Language: en-US
To: chengming.zhou@linux.dev, naohiro.aota@wdc.com, jth@kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-mm@kvack.org, vbabka@suse.cz, roman.gushchin@linux.dev,
 Xiongwei.Song@windriver.com, Chengming Zhou <zhouchengming@bytedance.com>
References: <20240224135329.830543-1-chengming.zhou@linux.dev>
From: Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <20240224135329.830543-1-chengming.zhou@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 2024/02/24 5:53, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  fs/zonefs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index 236a6d88306f..c6a124e8d565 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1422,7 +1422,7 @@ static int __init zonefs_init_inodecache(void)
>  {
>  	zonefs_inode_cachep = kmem_cache_create("zonefs_inode_cache",
>  			sizeof(struct zonefs_inode_info), 0,
> -			(SLAB_RECLAIM_ACCOUNT | SLAB_MEM_SPREAD | SLAB_ACCOUNT),
> +			SLAB_RECLAIM_ACCOUNT | SLAB_ACCOUNT,
>  			NULL);
>  	if (zonefs_inode_cachep == NULL)
>  		return -ENOMEM;

Looks good, but please rework the commit message as you suggested on the btrfs
list to have more details about this change. Thanks.

-- 
Damien Le Moal
Western Digital Research