Received-SPF: pass (google.com: domain of linux-kernel+bounces-81497-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 26 Feb 2024 14:36:17 +0100
Message-Id: <CZF1U6LPB3XB.1BXJPWRGB4TH@bootlin.com>
Subject: Re: [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and
 system-wide suspend
Cc: "Apurva Nandan" <a-nandan@ti.com>, <linux-spi@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, "Gregory CLEMENT"
 <gregory.clement@bootlin.com>, "Vladimir Kondratiev"
 <vladimir.kondratiev@mobileye.com>, "Thomas Petazzoni"
 <thomas.petazzoni@bootlin.com>, "Tawfik Bayouk"
 <tawfik.bayouk@mobileye.com>, "Nishanth" <nm@ti.com>, "Vignesh"
 <vigneshr@ti.com>
To: "Dhruva Gole" <d-gole@ti.com>, "Mark Brown" <broonie@kernel.org>
From: =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>
References: <20240222-cdns-qspi-pm-fix-v4-0-6b6af8bcbf59@bootlin.com>
 <170862920925.104158.14642580909914879148.b4-ty@kernel.org>
 <20240226121803.5a7r5wkpbbowcxgx@dhruva>
In-Reply-To: <20240226121803.5a7r5wkpbbowcxgx@dhruva>

Hello Dhruva,

On Mon Feb 26, 2024 at 1:18 PM CET, Dhruva Gole wrote:
> Hi Mark, Theo,
>
> + Nishanth, Vignesh (maintainers of TI K3)
>
> On Feb 22, 2024 at 19:13:29 +0000, Mark Brown wrote:
> > On Thu, 22 Feb 2024 11:12:28 +0100, Th=C3=A9o Lebrun wrote:
> > > This fixes runtime PM and system-wide suspend for the cadence-qspi
> > > driver. Seeing how runtime PM and autosuspend are enabled by default,=
 I
> > > believe this affects all users of the driver.
> > >=20
> > > This series has been tested on both Mobileye EyeQ5 hardware and the T=
I
> > > J7200 EVM board, under s2idle.
> > >=20
> > > [...]
> >=20
> > Applied to
> >=20
> >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-=
next
> >=20
> > Thanks!
> >=20
> > [1/4] spi: cadence-qspi: fix pointer reference in runtime PM hooks
> >       commit: 32ce3bb57b6b402de2aec1012511e7ac4e7449dc
> > [2/4] spi: cadence-qspi: remove system-wide suspend helper calls from r=
untime PM hooks
> >       commit: 959043afe53ae80633e810416cee6076da6e91c6
> > [3/4] spi: cadence-qspi: put runtime in runtime PM hooks names
> >       commit: 4efa1250b59ebf47ce64a7b6b7c3e2e0a2a9d35a
> > [4/4] spi: cadence-qspi: add system-wide suspend and resume callbacks
> >       commit: 078d62de433b4f4556bb676e5dd670f0d4103376
>
> It seems like between 6.8.0-rc5-next-20240220 and
> 6.8.0-rc5-next-20240222 some of TI K3 platform boot have been broken.
>
> It particularly seemed related to these patches because we can see
> cqspi_probe in the call trace and also cqspi_suspend toward the top.
>
> See logs for kernel crash in [0] and working in [1]

I'm guessing we are talking about tags next-20240220 and next-20240222
on: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/

Neither of those tags include the patches about fixing PM hooks.

   =E2=9F=A9 # next-20240220
   =E2=9F=A9 git log --oneline --author theo.lebrun 2d5c7b7eb345 \
      drivers/spi/spi-cadence-quadspi.c

   =E2=9F=A9 # next-20240222
   =E2=9F=A9 git log --oneline --author theo.lebrun e31185ce00a9 \
      drivers/spi/spi-cadence-quadspi.c
   0f3841a5e115 spi: cadence-qspi: report correct number of chip-select
   7cc3522aedb5 spi: cadence-qspi: set maximum chip-select to 4
   0d62c64a8e48 spi: cadence-qspi: assert each subnode flash CS is valid
   =E2=9F=A9 # Those are unrelated patches.

Also it shows from the calltrace: this series renames the runtime
suspend/resume hooks to cqspi_runtime_* while the callstack you gave
talks about cqspi_suspend. It only gets called at system-wide suspend
following this series.

My guess is that this series will rather fix the issue that you are now
facing. :-) Could you try applying them and checking if that fixes your
error?

Regards,

--
Th=C3=A9o Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com