Received-SPF: pass (google.com: domain of linux-kernel+bounces-81500-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 26 Feb 2024 13:40:00 +0000
From: Mark Brown <broonie@kernel.org>
To: Dhruva Gole <d-gole@ti.com>
Cc: Apurva Nandan <a-nandan@ti.com>,
	=?iso-8859-1?Q?Th=E9o?= Lebrun <theo.lebrun@bootlin.com>,
	linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@bootlin.com>,
	Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Tawfik Bayouk <tawfik.bayouk@mobileye.com>, Nishanth <nm@ti.com>,
	Vignesh <vigneshr@ti.com>
Subject: Re: [PATCH v4 0/4] spi: cadence-qspi: Fix runtime PM and system-wide
 suspend
Message-ID: <cb74a9f9-abfa-4a94-b4a9-bf41ddc697eb@sirena.org.uk>
References: <20240222-cdns-qspi-pm-fix-v4-0-6b6af8bcbf59@bootlin.com>
 <170862920925.104158.14642580909914879148.b4-ty@kernel.org>
 <20240226121803.5a7r5wkpbbowcxgx@dhruva>
 <69f3dcd7-b79f-4b4f-aecb-dc559d74e6e4@sirena.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dT9DhkmsR3HA0bqQ"
Content-Disposition: inline
In-Reply-To: <69f3dcd7-b79f-4b4f-aecb-dc559d74e6e4@sirena.org.uk>


--dT9DhkmsR3HA0bqQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Feb 26, 2024 at 01:27:57PM +0000, Mark Brown wrote:
> On Mon, Feb 26, 2024 at 05:48:03PM +0530, Dhruva Gole wrote:
> > On Feb 22, 2024 at 19:13:29 +0000, Mark Brown wrote:

> [    1.709414] Call trace:
> [    1.711852]  __mutex_lock.constprop.0+0x84/0x540
> [    1.716460]  __mutex_lock_slowpath+0x14/0x20
> [    1.720719]  mutex_lock+0x48/0x54
> [    1.724026]  spi_controller_suspend+0x30/0x7c
> [    1.728377]  cqspi_suspend+0x1c/0x6c
> [    1.731944]  pm_generic_runtime_suspend+0x2c/0x44
> [    1.736640]  genpd_runtime_suspend+0xa8/0x254

> (it's generally helpful to provide the most relevant section directly.)

> The issue here appears to be that we've registered for runtime suspend
> prior to registering the controller...

Actually, no - after this series cqspi_suspend() is the system not
runtime PM operation and should not be called from runtime suspend.  How
is that happening?

--dT9DhkmsR3HA0bqQ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXclLAACgkQJNaLcl1U
h9BuqQf+MH9CDnVqVpElG8YMfnoXoUebQzNfXKDwkudLGGp0ExSf1+MjPcfmzGrB
mBXwd7A39yEX3v3CUFctuC2UovQA2eJDJXeGnpHuAJPSmbuWFrIlLUJEm2lv3CAl
dSvAWQl9O+26dtX6Tda0897TMuD/hIX8bf+NY6ejvSyb61gBMGJS23AbwA6rQbkx
E0/ulqCQ8lYL8WCYf/eoxEC3mSJefWAkjalulhvcWBfZgZrQe5uIddcmThn/Bn96
JtK+wi1iT9ZtCysv0dwa8+lD3iSCeO2JLBHfchCTFlUfFwRH5gZX8SS4dTZhzMmi
U0cVSxyElPcusXldph2Lw8ghLhM88A==
=uNwv
-----END PGP SIGNATURE-----

--dT9DhkmsR3HA0bqQ--