Received-SPF: pass (google.com: domain of linux-kernel+bounces-81519-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240219160912.1206647-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20240219160912.1206647-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
In-Reply-To: <20240219160912.1206647-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 26 Feb 2024 14:42:57 +0100
Message-ID: <CAMuHMdVVUpq3+O298s=2V95T5Ub4MgM9kj=mQ-fHL8KUgD0Uug@mail.gmail.com>
Subject: Re: [PATCH 3/4] soc: renesas: Add identification support for RZ/V2H SoC
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, 
	linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Prabhakar,

On Mon, Feb 19, 2024 at 5:10=E2=80=AFPM Prabhakar <prabhakar.csengg@gmail.c=
om> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Add support to identify the RZ/V2H (R9A09G057) SoC.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Thanks for your patch!

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -344,6 +344,11 @@ config ARCH_R9A09G011
>         help
>           This enables support for the Renesas RZ/V2M SoC.
>
> +config ARCH_R9A09G057
> +       bool "ARM64 Platform support for RZ/V2H{P}"
> +       help
> +         This enables support for the Renesas RZ/V2H{P} SoC variants.

"RZ/V2H(P)" (everywhere).

> +
>  endif # ARM64

> --- a/drivers/soc/renesas/renesas-soc.c
> +++ b/drivers/soc/renesas/renesas-soc.c

> @@ -177,6 +181,11 @@ static const struct renesas_soc soc_rz_g3s __initcon=
st __maybe_unused =3D {
>         .id     =3D 0x85e0447,
>  };
>
> +static const struct renesas_soc soc_rz_v2h __initconst __maybe_unused =
=3D {
> +       .family =3D &fam_rzv2h,
> +       .id     =3D 0x847A447,

Lower case hex please.

> +};

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds