Received-SPF: pass (google.com: domain of linux-kernel+bounces-81532-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <aa180f33-9c42-4435-aff2-f23c42bcadea@ti.com>
Date: Mon, 26 Feb 2024 19:17:31 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] clk: keystone: sci-clk: Adding support for non
 contiguous clocks
Content-Language: en-US
To: Francesco Dolcini <francesco@dolcini.it>
CC: <nm@ti.com>, <kristo@kernel.org>, <ssantosh@kernel.org>, <chandru@ti.com>,
        <rishabh@ti.com>, <kamlesh@ti.com>, <vigneshr@ti.com>,
        <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <linux-clk@vger.kernel.org>
References: <20240213082640.457316-1-u-kumar1@ti.com>
 <20240226105435.GA11908@francesco-nb>
From: "Kumar, Udit" <u-kumar1@ti.com>
In-Reply-To: <20240226105435.GA11908@francesco-nb>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/26/2024 4:24 PM, Francesco Dolcini wrote:
> On Tue, Feb 13, 2024 at 01:56:40PM +0530, Udit Kumar wrote:
>> Most of clocks and their parents are defined in contiguous range,
>> But in few cases, there is gap in clock numbers[0].
>> Driver assumes clocks to be in contiguous range, and add their clock
>> ids incrementally.
>>
>> New firmware started returning error while calling get_freq and is_on
>> API for non-available clock ids.
> Is this the kind of errors I should expect in such situation?
>
> ti-sci-clk 44043000.system-controller:clock-controller: recalc-rate failed for dev=13, clk=7, ret=-19
>
> If this is the case, I feel like this patch should be back-ported to
> stable kernels.

Sure will send to stable@vger.kernel.org


> Any malfunction because of these errors or just some noise in the logs?

Error is noise in logs, no impact on function as these reserved clocks

are not used by drivers.


>
> Francesco
>