Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1317269rbb; Mon, 26 Feb 2024 05:55:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWtLGr+C1jx7NFLtmnQosAw4iHMzYWjIk6iK36e/4Y9njGtB18qexqJNQlTIvr0Ax0+Ff3nNsWLRTT+MdOhvFf3QUaxnr3z0dy1j0VWUQ== X-Google-Smtp-Source: AGHT+IHyT5pBFDTuUzNOoFz57QM66iFy7unaex8k8lXdSi2f7nbP0DW4qrMRflGPLSsfTkoKVMye X-Received: by 2002:a05:6358:88e:b0:17b:64af:cd7b with SMTP id m14-20020a056358088e00b0017b64afcd7bmr6839373rwj.16.1708955717384; Mon, 26 Feb 2024 05:55:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708955717; cv=pass; d=google.com; s=arc-20160816; b=ncciaB+Qd+mTVmclnfI5b9oQGcA7KLESqoUYYW4FKCVC5bsD2SZd+dhMuDU4+KytnZ aJ1T3rRm/R8twh+qV7o7Q3Bc70fFzZ6zLXu93lj6bxxpHRmHvXqecK6JN5Tdcu3jd05m ON5eqWiFXsdfECjhggvPR2xjve6pUOjRRawvZJL4zf41ZzUOFted+XLTUeADdPMXtPe2 xZ8d/YxfJDug06w9cOoBb+F97sx8iheHHJqXfcOM8rr+cBNy4hYjCfmH1i00KFZ9pKTD xR6I9e5PqkPDqPKSvksr4vTz6EVIAADPTg1QZqbb+RQmWvYOxbXKPxTtWajXS0bi6ZS3 k25A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8/7EY5ehvj4v/FSW3EO/5WrXQhR8QOZgE4fTb+c2pnU=; fh=ZyQ3LFwZmCW6SR/DQrHLlUKH+pq3jhq/on8C6w6cT54=; b=uefza1bQITi9+xKf9OBMp6O73OR8+IMAxCPCBxOhzUthlMwsw15VeKuJeCsuiqIjNN ABcWCsxSXPEzRSmoJJ9CeUrvnQZaiCKiCyDfp+ejBPqW8wE8zA62xpQj3eNGW1tdUqOW G36nRi7D78XBCsbv43ZFAVzrmy49dT0iI3Prc/AyqHY125CiDAWH5E2lzAEsSHsPQPlI CoDL1iafYV2yEldjjYHUAfmscL9Q3S2ZMLldJwiNiKyWGrR3FtT+KjiopKg6axj6QiY/ KdE6WcsTvB04DVj2154GDlsz/q273lu1GAA5y18902d9OgyouHXNzhc40PkcATqWBlJS KSWQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLF2GRs1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81530-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h10-20020a056a00230a00b006e4827e6fe6si3825067pfh.136.2024.02.26.05.55.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 05:55:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SLF2GRs1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81530-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81530-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 733642924C7 for ; Mon, 26 Feb 2024 13:48:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 514D21292EE; Mon, 26 Feb 2024 13:47:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SLF2GRs1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2C91AACC; Mon, 26 Feb 2024 13:47:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708955256; cv=none; b=aEJMX3MxKcxNwdGANM1x6eqiSKU53vmzOfbYzA5dFYzEFeZSMusgLbaZn3QkBtC5UbarwdouQXCoOLwR4zQWIKWbwRLnnJ5AWkb9Nag75lHH1H5dSUzhfeJbBWsYV1dCJFMFtRh6HKILSjyxktAZw0sUGp3bNPrlhVfRx+rKPE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708955256; c=relaxed/simple; bh=fSJaGhfbzk3mg9Gy/IkD4517DdQOP65I1oQqAokj57g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kv5owtYhvTKfPO+JgWkoQ5IDtG7KjL6kXjcIJFt04QSjKr9Wm14nyyI6QXjGyWI7gUgQ3uXkVRD4p9YGFds4p7DUej0Pies5WmRxLuX7QOyFk77awWxlt7IwREK+xjgAQFvUjqlrbNukDeMZAl+48SViDyQwL/9H6KXU+Jh7+oA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SLF2GRs1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B552C433C7; Mon, 26 Feb 2024 13:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708955255; bh=fSJaGhfbzk3mg9Gy/IkD4517DdQOP65I1oQqAokj57g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SLF2GRs1FNRQRREvRc0IrbCboJQPubtEH/xb1/5pMSw4F/R5Ds+sNAKHXtH3bTZ73 IipHQ7/5PdlRjKq0/n2WuEQGT81qUUAmsd3l4Sh3rEbbDgoUHGhFBWTmRRYrKrKD1k p3rqxWMAuCSy8yyPUBPCawWS46wLH6pUQXi1Aw5Lpog2b5rLJsMxOfJS9CajvuICQ0 d+zJv0b8zQ/PNYvOzo+GG+/3srCyC6GNu1PEMK+XPrBfRVzvo3Ra7qoINBrJHuIZIZ aqlSU/DN4ZjmecGXdHB+/Oj4iAreUbOoBZximzjzWy7xdkBy2mR3V0FOUVHMFyH4gz d3HbrlViWZT+w== Date: Mon, 26 Feb 2024 13:47:30 +0000 From: Simon Horman To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, Steffen Klassert , Herbert Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] xfrm: Do not allocate stats in the driver Message-ID: <20240226134730.GE13129@kernel.org> References: <20240222144117.1370101-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222144117.1370101-1-leitao@debian.org> On Thu, Feb 22, 2024 at 06:41:17AM -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the xfrm driver and leverage the network > core allocation. Reviewed-by: Simon Horman