Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1348106rbb; Mon, 26 Feb 2024 06:41:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXu7EAR0ZVBbY7Ui8gzE0qk+oi/YesWSuY35G3qdjVsJoIugFw/HtPaoxgpVctA6gyNvaU6EmhE1rmqmi1sF7Y0UDI8FkHzyUeaiDAyng== X-Google-Smtp-Source: AGHT+IEguy4x7DaeLY9hr0Z+x50HCVqKjLay8OqqeUmSWPooyWTD0ZBvtGRugFXYQNo6BAZvYzIS X-Received: by 2002:a05:6871:7983:b0:21f:c36a:b706 with SMTP id pb3-20020a056871798300b0021fc36ab706mr6977831oac.24.1708958492529; Mon, 26 Feb 2024 06:41:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708958492; cv=pass; d=google.com; s=arc-20160816; b=JLsEY2h/lm1hD9V1Y+wuICKM/Va011EbRCr2waeKWy6ejFlocX+gvEpsaPfEg0xhz6 MvSW3vBDD1W6KzaYWsFdFL3Rubd2WdMLHVJP7h+HBi3pwIo5CuQAUXQb5z7mvoenJzEa l9y2iIVBfbGojb7z6SAnmRihQfZSE0XF291NJXld9Qk9ERXAfyfIA0FjFLrrZvnJTQXi wDnBwvA4a3/Kqet5cEPl9vAWzjltWPM/4B8q2M6ldWG4TMjc/pvX88AE4lclMgpw5U0h nj80pOwcYuC0AqvGwus7crtcEGzjBGMdDh3oclmWbLHCvcCyC/0/DkdGHhmOWXK1K59/ MKxw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=JnSt4IJZTEI8zkQLr8kQBuMJnDRUrPTQ0cGk7n5MhPo=; fh=z/xTaK9oPgxevmlE7a9Gf5BjYpByleWTd7ZDUcLG9k8=; b=zDVVs8g0clG0J2AqHv8ZbVcP2oyoceI8P0FPs/0DiEREOpxvTxSrDhMU0/z2bOyz0S U88gtMCkdOLkLD8MqnaDTBIK48CMKjy3TMIcPahPnIteQB1rAxcLETvGg9bqhmJY6EXN d0hiMFwnFJda2VBj1bWV44t20iyMtdZZP34dF+UHq4ShEefqHFJGjwIUOCDlRk6/ubk0 jvfLNoqELDWQXrtX9QqCrrBKWoBYErK7hUT42AQX0H6qGvx06Ar6WZdaxwFpbLjuKamm OVXVSMY4Kdp9mkaJfP3bmZsnjGYHw0Fojx+xOL2PxfMZ7L26T3GywK+/91SR8BeSVSfF ecaw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-81658-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81658-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id y6-20020ae9f406000000b00787cb2f073asi3635634qkl.342.2024.02.26.06.41.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 06:41:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81658-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-81658-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81658-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 492601C223A6 for ; Mon, 26 Feb 2024 14:41:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5578813172D; Mon, 26 Feb 2024 14:35:31 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8719212BEB1 for ; Mon, 26 Feb 2024 14:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708958130; cv=none; b=Ls2Tj6DNa1YQLoWDUE71Rov8sNqHrS3OQ7IYOKh8ciIpODaYfrImaxqJoauuZ8UvVhm5uPO1oEhlgtsDEvvQBO0WlI309FwUcjEpgO7JANxiKn8Bc4yn+lFPJj6YMzVf6qBAawNEw5kbpVbfzcE6sKS9HVorXkJa5MQV+hfot18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708958130; c=relaxed/simple; bh=Fz41MqNPHXkjmlJi5LlMt1NTgGE6wC6Ek8w812V5lec=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=XuV69veg292xy3G3juMkMmIbTaqhLMbMEishrilTXnG0m18L2sA+IXG6PobWtNV0DaeNwHlwhHfibHWHUjurc26gYg1dVVaBl2BOp/bEXLwSOQwYfotsTULMqjJgbxgsA8AX0dxjLX1WRKLZGSPLTWrVRPeQgdADDpyjA+bHYuc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 41390DA7; Mon, 26 Feb 2024 06:36:06 -0800 (PST) Received: from ewhatever.cambridge.arm.com (ewhatever.cambridge.arm.com [10.1.197.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 463153F762; Mon, 26 Feb 2024 06:35:26 -0800 (PST) From: Suzuki K Poulose To: mathieu.poirier@linaro.org, Yang Jihong , alexander.shishkin@linux.intel.com, john.garry@huawei.com, jonathan.cameron@huawei.com, yangyicong@hisilicon.com, linux-kernel@vger.kernel.org Cc: Suzuki K Poulose , yangyicong@huawei.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v2] hwtracing: hisi_ptt: Move type check to the beginning of hisi_ptt_pmu_event_init() Date: Mon, 26 Feb 2024 14:35:18 +0000 Message-Id: <170895806567.105951.9088649560811181589.b4-ty@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240108121906.3514820-1-yangjihong1@huawei.com> References: <20240108121906.3514820-1-yangjihong1@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Mon, 8 Jan 2024 12:19:06 +0000, Yang Jihong wrote: > When perf_init_event() calls perf_try_init_event() to init pmu driver, > searches for the next pmu driver only when the return value is -ENOENT. > Therefore, hisi_ptt_pmu_event_init() needs to check the type at the > beginning of the function. > Otherwise, in the case of perf-task mode, perf_try_init_event() returns > -EOPNOTSUPP and skips subsequent pmu drivers, causes perf_init_event() to > fail. > > [...] Applied, thanks! [1/1] hwtracing: hisi_ptt: Move type check to the beginning of hisi_ptt_pmu_event_init() https://git.kernel.org/coresight/c/06226d120a28 Best regards, -- Suzuki K Poulose