Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1364342rbb; Mon, 26 Feb 2024 07:07:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWsKPnOEqcyCLSvi0c+A798pGjWUuHixQ5iGsffFurmMTWBoS2nW0Cd8cZIu+fCPbHUL3iRI6aXZjTwooVf41Gqno/pdsWWODEt0pQ4Wg== X-Google-Smtp-Source: AGHT+IEXAFHY7t5Jw157SF9lO4MsoDCFkpZ5u8idZsFru1R5rtsAJwNtJBgBER2689mN64JXWrc4 X-Received: by 2002:a17:906:128a:b0:a3e:876d:1b1 with SMTP id k10-20020a170906128a00b00a3e876d01b1mr4740052ejb.20.1708960073096; Mon, 26 Feb 2024 07:07:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708960073; cv=pass; d=google.com; s=arc-20160816; b=sK5tXMMEXjQI6e/0P5PLO6zPxrkOV8/Ji9VFfOdvDCR9y1T84GIBEssJW30RVyBhyB lrszLCtE+aw9XoorAqR6qZk+cJqYsjnobmukTcDCBUyJ7xOAJLdCtc1lqWc7A37AuVMH hO9zqiimox3nNrYcMG8zIDFHcRndUQ2+eVtg0ckvHUcI14q5r8rI/ySPIsEOvUpz2F+i ePWjOBab1Wqzp+p5l8T2WyHrCNv7rPriR0F1UJoADy1asJQA1UfTO+Srk8TmsBHmK6Uo 5dbMIY3U7/EslqLhMgxhHvvZfGr28z8icGhKU3sJMeKjn/Cypk4+sL+WgMAx4gc4WeQY +U2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-transfer-encoding :content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:message-id:subject:cc:to:from:date :dkim-signature; bh=//OKjg7LXV8H7gX2Gh4uY9/4XlV3lAnSxPOQfVzPG7U=; fh=gwYNO/A0AOwsEorbTq6zwshvb0d8adoAH2/vAS1SJQI=; b=K/9526auPzE/HEyn60Cn5yVkjxOp5h753YnE+ne3ZNxEMOGkDxpCzszUHwFtk5Djr8 G6Ry4GIYLs79FMbWMo8+yFQuyh38fnyWv2QiKY+VGdzg19esJP4keC0qRoewm7e+Gn5h lntd6f9F7tlHrLIBokKmD1KCpmH41PR2oABMvsYeQulEZCUxbbiGVTPL2WDodMbl76us liBMH5Ldzvbz3a9nft9GkBZT0LSCtvFgTum1f1yXN8GeycJQwK3mo3exToMXr27i0sGB cuaeoH8e65q31CgZZJxkKLPuBpSZCVExjuM7xsLWUWX2nJuKU88QveMnio8oRVQNWgPg W+xw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QvQm1Tgx; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-81733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id b13-20020a170906d10d00b00a3e95937621si2163520ejz.449.2024.02.26.07.07.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 07:07:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QvQm1Tgx; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-81733-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81733-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 0E7F51F221AE for ; Mon, 26 Feb 2024 15:07:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4C5AD13247F; Mon, 26 Feb 2024 14:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="QvQm1Tgx" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A94E12BF1C for ; Mon, 26 Feb 2024 14:47:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708958832; cv=none; b=HlT/VZ4DFpSa0mMHqNG5tnqlwxbI44bfNIVuXJ4RL9hd7dZHA0e8c3GpAiQ9mnHezNbu/tPAW3EMLPQgpapNyc0MGjBog2IeZNmZsUUaL4HNHr6kfsXQV0DVrVic/DiJNAdqQPEZPzuCyBemTs/p0n71P9+dCTr8bytA3LHlGVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708958832; c=relaxed/simple; bh=BS/LynQ/vfsRyBPVQ8PFhDz219TrZ+G+szkSUtWDY2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ntYRFQ35xCZoD1AdLoNkhY9yS2s3HZYrGnoKWBfmSoouYkRqqb1m4wTD5CAUJsrnj+A+NYMidg26NI2Q28LzCkyfw9o7aOZHg9Y+gSkhAs26e6ZwWtHczi/nraVER937ccUqeDD1xxT59IYC37tjpjJnVtM9hhao6KHv8e017QM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=QvQm1Tgx; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708958831; x=1740494831; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=BS/LynQ/vfsRyBPVQ8PFhDz219TrZ+G+szkSUtWDY2k=; b=QvQm1TgxBswjVGgXmMxzLalwsDR0EYOkZIE+jVFjd8C5f/LWRqeGAVut x73H4I2ThfHMYzrFIVgvQExbvB5NPUwgjJVaR58QoZBIJZBxcIleUlyf+ 6ZftohHFVRcYOKehcVzztWsbF5jHwFarzMcvSsRZZuaJ0iUjVqWEMIpHj hnlI6eEcOu1cWZmIiI7NxgdgPv1XlTEZTeWAFREhVTjMb42mIzBFpfZRN rzeW3jxhGUfpYTAUrxBPLYFcYrlDXZEbJ/aC5YyLuZmDDlLSIZ3NpXJqn LAWG5wTQ2bxfIG2F8hE5FFenjMsboL2YGcNEzVVzC/gIQFNf/qze8CRab A==; X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="14681758" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="14681758" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 06:47:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10995"; a="913874171" X-IronPort-AV: E=Sophos;i="6.06,185,1705392000"; d="scan'208";a="913874171" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Feb 2024 06:47:08 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1recG1-00000007hu6-2KVF; Mon, 26 Feb 2024 16:47:05 +0200 Date: Mon, 26 Feb 2024 16:47:05 +0200 From: Andy Shevchenko To: Shahar Avidar Cc: gregkh@linuxfoundation.org, luca.ceresoli@bootlin.com, benjamin.tissoires@redhat.com, elder@linaro.org, robh@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: pi433: Move FIFO_THRESHOLD define to source file Message-ID: References: <20240225173341.1278918-1-ikobh7@gmail.com> <20240225173341.1278918-5-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240225173341.1278918-5-ikobh7@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Sun, Feb 25, 2024 at 07:33:41PM +0200, Shahar Avidar wrote: > FIFO_THRESHOLD is only being used by pi433_if.c source file Same issue (and seems in all of your commit messages) — missing periods at the end of the sentences. Respect English grammar, please. -- With Best Regards, Andy Shevchenko