Received-SPF: pass (google.com: domain of linux-kernel+bounces-81740-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 26 Feb 2024 16:53:50 +0200 (EET)
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>, 
    Hans de Goede <hdegoede@redhat.com>, 
    Mario Limonciello <mario.limonciello@amd.com>, 
    platform-driver-x86@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, 
    kernel-janitors@vger.kernel.org, dan.carpenter@linaro.org
Subject: Re: [PATCH] platform/x86/amd/pmf: Fix missing error code in
 amd_pmf_init_smart_pc()
In-Reply-To: <20240226144011.2100804-1-harshit.m.mogalapalli@oracle.com>
Message-ID: <a7b4dfc8-8be9-911a-6c56-4f84c1b85d73@linux.intel.com>
References: <20240226144011.2100804-1-harshit.m.mogalapalli@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1479405409-1708959230=:1203"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1479405409-1708959230=:1203
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Mon, 26 Feb 2024, Harshit Mogalapalli wrote:

> On the error path, assign -ENOMEM to ret when memory allocation of
> "dev->prev_data" fails.
>=20
> Fixes: e70961505808 ("platform/x86/amd/pmf: Fixup error handling for amd_=
pmf_init_smart_pc()")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is based on static analysis with smatch, only compile tested
> ---
>  drivers/platform/x86/amd/pmf/tee-if.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86=
/amd/pmf/tee-if.c
> index 8527dca9cf56..dcbe8f85e122 100644
> --- a/drivers/platform/x86/amd/pmf/tee-if.c
> +++ b/drivers/platform/x86/amd/pmf/tee-if.c
> @@ -458,8 +458,10 @@ int amd_pmf_init_smart_pc(struct amd_pmf_dev *dev)
>  =09amd_pmf_hex_dump_pb(dev);
> =20
>  =09dev->prev_data =3D kzalloc(sizeof(*dev->prev_data), GFP_KERNEL);
> -=09if (!dev->prev_data)
> +=09if (!dev->prev_data) {
> +=09=09ret =3D -ENOMEM;
>  =09=09goto error;
> +=09}
> =20
>  =09ret =3D amd_pmf_start_policy_engine(dev);
>  =09if (ret)
>=20

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-1479405409-1708959230=:1203--