Received-SPF: pass (google.com: domain of linux-kernel+bounces-81757-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 26 Feb 2024 16:02:36 +0100
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn
 <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Florian Fainelli
 <f.fainelli@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, Jonathan
 Corbet <corbet@lwn.net>
Subject: Re: [PATCH net-next 1/2] doc: sfp-phylink: drop the mention to
 phylink_config->pcs_poll
Message-ID: <20240226160236.20c0be97@device-28.home>
In-Reply-To: <Zdx40zi1Qz61sCX7@shell.armlinux.org.uk>
References: <20240220160406.3363002-1-maxime.chevallier@bootlin.com>
	<20240220160406.3363002-2-maxime.chevallier@bootlin.com>
	<Zdx40zi1Qz61sCX7@shell.armlinux.org.uk>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Russell,

On Mon, 26 Feb 2024 11:41:07 +0000
"Russell King (Oracle)" <linux@armlinux.org.uk> wrote:

> On Tue, Feb 20, 2024 at 05:04:03PM +0100, Maxime Chevallier wrote:
> > commit 64b4a0f8b51b ("net: phylink: remove phylink_config's pcs_poll")
> > dropped the phylink_config->pcs_poll field, which is no longer required
> > to be set by MAC drivers. Remove that mention in the phylink porting
> > guide.  
> 
> The porting guide needs to be updated with the PCS, and the details for
> that moved over rather than being deleted. While it's true that this
> member is gone from phylink_config, it was only removed after the
> introduction of the similarly named member in phylink_pcs.
> 
> In other words, point 10 should probably read:
> 
> 10. Arrange for PCS link state interrupts to be forwarded into
>     phylink, via:
> 
>     .. code-block:: c
> 
>         phylink_pcs_change(pcs, link_is_up);
> 
>     where ``link_is_up`` is true if the link is currently up or false
>     otherwise. If a PCS is unable to provide these interrupts, then
>     it should set ``pcs->pcs_poll = true;`` when creating the PCS.
> 
> However, for that to make sense, we then need the guide to provide
> details about creating the PCS, and also the mac_select_pcs() method.
> Thus my comment about a much bigger update being required.
> 

Makes sense. If that's OK I'll send a V2 with a PCS handling addition
to it, and see how that looks.

Thanks for the review,

Maxime