Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1376192rbb; Mon, 26 Feb 2024 07:26:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUPlEjED+J7R3+VTsrGbtRZFVyGzm6bIGpmkIgyO1yssZT/JRSAt4WkTSzpETXp9h1rBlbPJDosfCcwpvVESNN9uxJQ1AOX3g8ATdo/PQ== X-Google-Smtp-Source: AGHT+IEPhXZgvWbvhF9w6v2NOHXRC6HtX3bEDFQPd51LGJUqidvLWyiMf52H0gS+VQVkMUprz2k2 X-Received: by 2002:a05:6a21:1799:b0:19e:48b6:9c43 with SMTP id nx25-20020a056a21179900b0019e48b69c43mr6057962pzb.58.1708961213590; Mon, 26 Feb 2024 07:26:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708961213; cv=pass; d=google.com; s=arc-20160816; b=diQuJcg0GYe59WKrs3UcEEOX33EElC3ZnN728AGiiEDObyIKSsg5eRbBehQaF+AwQc noOtNJK5VKMEXzu3puuCc+vIdmah1jbNdEML2IBQ9Xht3G6iMmQoUot2GBV3CxuG3vIb dfTlY1HnLRPJWapm9wMaIJkDuuzVRLsth3Hx3aokCrYCmvTYwQ3Q0TtuKv5FMuOKJ/Gf FgyixRToP842cwyxM9+LPvKvyyGQczhH/Nstb0vfGr7CKFSpUGIVXhqwxJZbo6TuH2eR x8Qlto8YHVweJG5G4+6+mHYKHJjhWPPgJA0pPDFBNk3lAV8u82nWjTov0SbBIrDldwPJ gAYg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=nGdq6XXk/UeuFTtMavMdttmSA0H2jvS5cq8hYJMXAAE=; fh=2MvYA+sl6CTGHQKLIjOaHq0+9QYLHBzp0u9b3UW6OiI=; b=el8Yqw4ZLtbtkLqFnI0RR1JUj3sEUZ7FsmR0YJr9qrVB+uMW+XFBRTouva4I+3+BOs 6Gu29Y9ZaAg8HfxpzNG/vGZ0Mu9xKkxrdfMSouATzQJqvABOnDQ+yvXnZpOeopAssnEJ LA7ITsSkOxScFjPs3J3UytCJX+Tr6CMPcounnxeiDissxtDrJ6Wvw8Fdi9HkzY9g7YCP DIJdJsymy/j2MieZ44Td0uzp7Cp1og8XekBtA+hIZFbuWiKoT8zELEHdbceFmMb2ym8D UMby26MabZtAUFlTkQiUncJQRG1Q2TClOdDAv7EKTGCBrpWMPOKIjjFFs9dlP01zUUrT VyIg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qgABhc4V; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-81760-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81760-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e35-20020a635023000000b005e46720db84si2794092pgb.117.2024.02.26.07.26.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 07:26:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81760-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=qgABhc4V; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-81760-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81760-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9D153283747 for ; Mon, 26 Feb 2024 15:15:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 462C812BF2D; Mon, 26 Feb 2024 15:06:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="qgABhc4V" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 502C412B157; Mon, 26 Feb 2024 15:06:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708960013; cv=none; b=Vr5LFyDmqvqg2+ooVh6mloLSIIjDt4Z319z5rk25llo++nhhztWvoC9vRTijLXuJ1MCXIPnvZ7HKlPnPcXl0CP+U2e6PBFklcxVLtOeE4sWqZ2LXk6m9kcNLasOxU/FvECcRU/1L/QWhn8OyxbWbHg4Ude8L9CV5T7RVNzfRMyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708960013; c=relaxed/simple; bh=gTTT/xt37ba6unWv4bWQIlsiwtT9vCOYF4yilWXM058=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hjRbzcuudHRpS2JBPp979ZuRJHQbOOiM3q1REE0S4NmQ6mkkdaZE7c5uoEFy3UGL6FZ1vY2guO3YeyUrAbrwrx3hDf8B0EQci3UDzMIpBuJAFCd1qmp+hN+bF0NlxJEuKO3tVA8bh3x3eEss//fcClDuxlAZ2jHo41gNzg+7S1M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=qgABhc4V; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=nGdq6XXk/UeuFTtMavMdttmSA0H2jvS5cq8hYJMXAAE=; b=qgABhc4VCew3o6bM8DM/zk3Nhx 6ofzYt23vaaOqwho9Sz+QjCExHO1D3JxIxkJJDbw4CuELj+2CXQ2RjUQBdJem0lb1nG5DzYXsS323 ejPk9phPb7CiS59mMOLbmyv4W6GmHBzTGnN6/V3b2uDlEKYf+UDlIkczFDY3MjEcgJT8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1recZ7-008jZO-R1; Mon, 26 Feb 2024 16:06:49 +0100 Date: Mon, 26 Feb 2024 16:06:49 +0100 From: Andrew Lunn To: Shengyu Qu Cc: "Russell King (Oracle)" , hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Well, that seems some kind weird trick implemented in that chip's SDK (maybe > hardware?). It would automatically detect the speed rate that host uses and > switch to that rate. The system log of the stick shows that. Please could you show some examples from the system log. If this patch is accepted, these details need to be in the commit message, to explain how this actually works, when it should not actually work.... Andrew