Received-SPF: pass (google.com: domain of linux-kernel+bounces-81763-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Thomas Gleixner <tglx@linutronix.de>
To: Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
 kvm@vger.kernel.org
Cc: x86@kernel.org, Stephen Rothwell <sfr@canb.auug.org.au>, Xin Li
 <xin@zytor.com>
Subject: Re: [PATCH] x86: irq: unconditionally define KVM interrupt vectors
In-Reply-To: <20240223102229.627664-1-pbonzini@redhat.com>
References: <20240223102229.627664-1-pbonzini@redhat.com>
Date: Mon, 26 Feb 2024 16:10:05 +0100
Message-ID: <87zfvn9s8i.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Fri, Feb 23 2024 at 05:22, Paolo Bonzini wrote:
> Unlike arch/x86/kernel/idt.c, FRED support chose to remove the #ifdefs
> from the .c files and concentrate them in the headers, where unused
> handlers are #define'd to NULL.
>
> However, the constants for KVM's 3 posted interrupt vectors are still
> defined conditionally in irq_vectors.h.  In the tree that FRED support was
> developed on, this is innocuous because CONFIG_HAVE_KVM was effectively
> always set.  With the cleanups that recently went into the KVM tree to
> remove CONFIG_HAVE_KVM, the conditional became IS_ENABLED(CONFIG_KVM).
> This causes a linux-next compilation failure in FRED code, when
> CONFIG_KVM=n.
>
> In preparation for the merging of FRED in Linux 6.9, define the interrupt
> vector numbers unconditionally.
>
> Cc: x86@kernel.org
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Suggested-by: Xin Li (Intel) <xin@zytor.com>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>