Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1379424rbb; Mon, 26 Feb 2024 07:32:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW5F3SJPsptEhRVK52MAIfLkU0qiEfpVDGLilNrpwC7dHbfsKVkfXbnERTyr+7txJDz1zdE4MnF7th/o2LBHeuoDd5xvF9ZJfwxiCQFeA== X-Google-Smtp-Source: AGHT+IGgqA9Ldwtl9JEGBSMZ+AZ3Rpi+LslpEu7d2n4Scdl5gKpM2fEFPQB5bnCsWuiaBJzhbImR X-Received: by 2002:a17:90b:1050:b0:29a:9ba0:8a5b with SMTP id gq16-20020a17090b105000b0029a9ba08a5bmr4850178pjb.5.1708961529128; Mon, 26 Feb 2024 07:32:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708961529; cv=pass; d=google.com; s=arc-20160816; b=JOrVmXm5XTXy9YXoZ7TPbee8IPTdsXIBdqMWhBPeLNWtdeYz8oxElFs3u+3waVOWsZ 2c9qPwC+M2OpZq/PmMi2eFZRVl+NbNMkKLCBjqcZJ7+WyH+M4xJlAAun0H+PFYgSs7Z3 50CFW/ATVdiV3AluVCTsFSrOJwTAgnsja9xMVUALVn7HX5QQhSoxNk8gK5LYZAF3V6tu Zi3yS0EWDr+S3LyKG3k2dXabl7Qe63D6xeHvsX+Mh5Z1qF0W1k+br/fjHYb6865nVKxy doBwt4IDBIKvNY631t8lOGfGIZ7WHsG6/h6cVaGpnikfxvLyahMBGoNbOJC+DoDXzPv0 e6WA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=X+I52Ol9YmRyCDIRYCW22Vk6nS4OHq3YYIFS09Nzw6E=; fh=1GrpTxMuHgVBjIih//gCm1tfyLNe3bZDZOFLXKEOn4M=; b=FTIdSqkKIXQ9p147KqcdcQv5ZHkmj6wU2eBi7Dxyq/wMfhC4n2VkQf74CV5kkVowjr Y5kawPnzbn/A8Ihj00MdvlnbD91EnpDD+KrriKyzZF2pdDVUGGN+KFKY9qLiEElEfwMX hDb+NJj7RvjQyy9oCQqkqJZnIg4HDteGKTjLvte/08q+shxWkH348Qs+ybKOtvfGPHgU ATURXDqgRNlf54ENVfyHYuCEF+xbyrxzeKaZdYGWM8NjssMSN9U7lHox7KDg1Ix43lxB ny6Og+qHauR5IlFOaaI6bfE1pmU+LySMxHUeop8+4/ykXp9LVS8a6J/v+S3cqLcVcYZR TLmQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r5VB1e+G; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81801-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id sv3-20020a17090b538300b00296fe939aacsi3927074pjb.124.2024.02.26.07.32.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 07:32:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=r5VB1e+G; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-81801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81801-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 76C7B29B6E7 for ; Mon, 26 Feb 2024 15:28:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2569E12BF05; Mon, 26 Feb 2024 15:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r5VB1e+G" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C37D12AAEE; Mon, 26 Feb 2024 15:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708961296; cv=none; b=HO8NZZ7/Eddvif/VN5Kcebz1DPYAfiZOxluOkNn319x35kVcTTTbu7IWREdIf+pX/K7BSx416j4wbGgVAfe86uAPj0jj0BvlS+FUEP3/4E7Tw/mVO2RNrRPWNIF8Fzv7lY6yfx/ii8klMqiu5XU6PQk50azXmQ3QcwFmZiLGm/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708961296; c=relaxed/simple; bh=kn8CsHxeqDeP0T8Y+7WnbCgzGRh3dcKdz1ZaTvleJR8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lamFvMTPhf8agC0CI3ih+oT3c7BEnugSU0k59VTv9qKuOQO4g9wU3W6Cydoj33zNdoKBLLTRIuu59LsbdMmkGCVjN8ETkN4wkd3a2iUH/Um1m9cYAJd1sR6TUqIlPK77Oklf5K65CgrgMuHEV7vBlbYUbHuw2S0xoqsglfh6aWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r5VB1e+G; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6413CC433F1; Mon, 26 Feb 2024 15:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708961295; bh=kn8CsHxeqDeP0T8Y+7WnbCgzGRh3dcKdz1ZaTvleJR8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r5VB1e+GKBGqyMISOJnMz7UmKSCHQI7f6E9Hz2sT1hHrDS1+gakIQz2YaMUfuQ/Pc gpzrJtfVOJo3Yj9bdsVYbI9wvKMdGzBdL+jtOsEo/5EVPRBscKdC6nolxMib7xQsxp 1mLUs4+CpjR3zvgNcrg0LgVI1e33Hfbywurhqjs5YmaaA8Twahk/BCZtbv1IUXIv6g u+kQArVJvHcuU+TqoFNLWkPCvBCEkYDzup4DwVtvFyE01URwBv1ZG2adQC9d3L1CkW PQi4jb9TxdVSRtPG4jbAv6m02/ga4bi8V8ZhWAD9lSUTOufO+5dyRD1cp0xPLjMSdU gSZPjU+3VuM1w== Date: Mon, 26 Feb 2024 07:28:14 -0800 From: Jakub Kicinski To: wenyang.linux@foxmail.com Cc: Luis Chamberlain , Kees Cook , Joel Granados , Christian Brauner , davem@davemloft.net, David Ahern , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/8] introduce sysctl SYSCTL_U8_MAX and SYSCTL_LONG_S32_MAX Message-ID: <20240226072814.1d9ab85f@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 25 Feb 2024 12:05:30 +0800 wenyang.linux@foxmail.com wrote: > The boundary check of multiple modules uses these static variables (such as > two_five_five, n_65535, ue_int_max, etc), and they are also not changed. > Therefore, add them to the shared sysctl_vals and sysctl_long_vals to avoid > duplication. This also reduce the size a bit You provide no data on how big the reduction is. Eric's suggestion to encode the values directly in the table entry sounds great, please invest your time in that, instead of half measures.