Received-SPF: pass (google.com: domain of linux-kernel+bounces-81815-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <01bf2ba5-edb3-46dc-8725-93b823dc0fb1@amd.com>
Date: Mon, 26 Feb 2024 09:35:16 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86/amd/pmf: Fix missing error code in
 amd_pmf_init_smart_pc()
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
 Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
 dan.carpenter@linaro.org
References: <20240226144011.2100804-1-harshit.m.mogalapalli@oracle.com>
 <a7b4dfc8-8be9-911a-6c56-4f84c1b85d73@linux.intel.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <a7b4dfc8-8be9-911a-6c56-4f84c1b85d73@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFdIUTZIREhhcVRnai91WXVHRlRwVUVSLzJKSEtpRXE2VCtGMkRKcnVSUkFm?=
 =?utf-8?B?V1czRy9xejk1NUVsZnBHaHdVSmlOczNJSFdGaEh4czNLUXdiQjNHbEN6N0lh?=
 =?utf-8?B?ZmVIV0E0OVZsVmlTczZSclF6Q1JQbmxZVU85RG5aK1dBQ28zM3NkRFY0TzRh?=
 =?utf-8?B?TDF2aEFyTTJlM05xN296THpRR2pBSk82UjJyMXpYNTQ2WHJ4Wkt2RHpEMmIw?=
 =?utf-8?B?SHVEa0ZJMjl3MTJLeCtOd215Rk5QZjhHcHVlS016Y01JaUJiWmpSbm5qSFpi?=
 =?utf-8?B?dVVzU1Q0V3locU1ZU2xGMURocXJXaGxSWHdDV2lQanBhR01lbmFGMTlsUDZP?=
 =?utf-8?B?Tm1QYzRwdnp2QjAwclFuWElGam82V1lFZzFPc0JyaXBBeXRQWllHMTQyR3Fx?=
 =?utf-8?B?OExucSs0S3hnU0lGN1FFanA3RnFqbmFrSjdHVkNPc1Y2OEZkckhUdkFaUWhv?=
 =?utf-8?B?MXByaWttTTk3eFRNcENuMXBsU3UvVTdBaTNOWmpRUkUvQmVWSWFLaGhzMy9o?=
 =?utf-8?B?U2pQcXFjSFZsNTk5aVNkaldURzhtcmVjR0lmUXlpNmZTOWNFWG9SYnVDRGNy?=
 =?utf-8?B?MGk1L3JHcVJIdE5ia3ZrRmJLeTRYeHcvcEVzaEpsNS9TY2ZBZlVLVThGVHhM?=
 =?utf-8?B?L2daUjUrcDk1ZzZna1ZtZjcwdUZrbkJaODM0cy9HdEdpL05IK3lDdWN4WWRB?=
 =?utf-8?B?bGhiQjF0ZjFOMEZmTHJYTXZqNkJ1VWtBcDB2cFNEL0EzZytIcVQwUmJkM1ly?=
 =?utf-8?B?YUdVcXdRMEJPOUpISWFRL3lVSU5UN3U0MkV4UjVJMmg0UUJlMkJlUnNPRUQ5?=
 =?utf-8?B?b1ZldlBhUmNVK2dlUXRuSUVYRGlXaE96M0Q0bHlyYUM2OFNaS2V3Y0pYREJH?=
 =?utf-8?B?U21sUWt0UXdEME50MFlYYVlMSldXQkZmeXNXUVV3dGF0ZmErd1laSEMzUlFH?=
 =?utf-8?B?UjBYOGhoRXJBZm05MWVhOWJ1TnMyZkFYQVZSVzRueWhRMFM1aTRSRHJmelN4?=
 =?utf-8?B?RVB2bUF1emlVL2xNSW1IaklCcndJRE01TnBuKzNXWnpqWS9sVkZmc1R0Qngy?=
 =?utf-8?B?VmdWYm9PSHI1N1pVOEVjN3IyejRDMEExbVRKMGxueHZsN0V1WThndFhzTHNW?=
 =?utf-8?B?UklVMTA5T00xempUNzZ1NnZZbitOQ0tPS09mZ21zSzg1OCtoK1J5Z04xRkZQ?=
 =?utf-8?B?L1VIVi84QlBMelhJaXZ2QkpYb3VLcWliaUljelp2a3h5YmRNWjAyNWpxZnB6?=
 =?utf-8?B?OFM4Q205SkhTeEVMdEhqMk1pb1d5eUFETkM1KzFZZkV4Ykp6UFI2bTZ6T0VE?=
 =?utf-8?B?SzNpSU94VFhYQkc1eGRhWkVTdGVXUG93SzBEbEl3Ty9pVDN4Yk5OTkt5am9j?=
 =?utf-8?B?ck1jeTEyT1JDMVMzRXZjSElYQXFrY2xUaExQQTRjUFhhMk4xNnExT1pWcXhY?=
 =?utf-8?B?TzdvTzFXU0pRa1hhTWVsQU5tNHJtSHNWa29rWTF6dWlINUplYkV6TEJrVU03?=
 =?utf-8?B?UkVuTy91MVA1azdOSUlIV1NVSCtRZTlEV3h6Tjg1NFJoSnQrc1M4VVIxQ3Nk?=
 =?utf-8?B?RmpaSWtIVXluUkF3WENCcEZkOTRmSHZMODFFa0xkdnhxRXVBWG1QSGdwSGVl?=
 =?utf-8?B?Zk81amowZjF1MmZIUnhqakMraTR3QTRPSjYyeWFtY0RDK0dxbzJReEd1Ynd6?=
 =?utf-8?B?MFdYSlBSZGpwSE50QytHdWlzZEsvK25FaEZNYW4vcUsyYmlwYXM1M054Mzhx?=
 =?utf-8?B?emxQckxocmg3MG5JZW1USmczbzZOT2tsRzRqZ3FYU3JmR1E0R2NoSnFoUkU5?=
 =?utf-8?B?TE1xM2ZqT0svQ0cxR2dJMTF5b1c5RmU5ZlVMUDZmTHpSZ3hoTnBkQkxNYnRl?=
 =?utf-8?B?MFQrbWZpTGJZY3FKQXhJQjBNMjMrMHl4NmE0YlZyY2RBVmVlODh1ZDE5MkZD?=
 =?utf-8?B?WlVCMlNIRkhlTnJwdXZUUkRKMzFvU2ZOM01iSlVldHd5ZWVTaFZLcXRmNHdX?=
 =?utf-8?B?dkZGd1RsTDMyK250RWwwL3c4Qk03Rk9RdnZNdzFNL25rdlYzblVDQWxRSEtY?=
 =?utf-8?B?VUtOYTlpNE1CL1VjYXNKRFJXei9KWlhEYzFNQUo2Yjk3b1E5dFcwdjJLaUVo?=
 =?utf-8?Q?jYeo0FJGWeb4/GGHIE2EA613Q?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a934d5a0-2e0a-4b4a-661f-08dc36e0871f
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6095.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2024 15:35:14.8683
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QOgmA+g/2G4s4oP/5DtIN2NdSvciMJFhc853x1NwYhU2i5bc/ECkLjper3q+Z31Y6ykm3dfloD7ofDthWn3g6w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4068

On 2/26/2024 08:53, Ilpo Järvinen wrote:
> On Mon, 26 Feb 2024, Harshit Mogalapalli wrote:
> 
>> On the error path, assign -ENOMEM to ret when memory allocation of
>> "dev->prev_data" fails.
>>
>> Fixes: e70961505808 ("platform/x86/amd/pmf: Fixup error handling for amd_pmf_init_smart_pc()")
>> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
>> ---
>> This is based on static analysis with smatch, only compile tested
>> ---
>>   drivers/platform/x86/amd/pmf/tee-if.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c
>> index 8527dca9cf56..dcbe8f85e122 100644
>> --- a/drivers/platform/x86/amd/pmf/tee-if.c
>> +++ b/drivers/platform/x86/amd/pmf/tee-if.c
>> @@ -458,8 +458,10 @@ int amd_pmf_init_smart_pc(struct amd_pmf_dev *dev)
>>   	amd_pmf_hex_dump_pb(dev);
>>   
>>   	dev->prev_data = kzalloc(sizeof(*dev->prev_data), GFP_KERNEL);
>> -	if (!dev->prev_data)
>> +	if (!dev->prev_data) {
>> +		ret = -ENOMEM;
>>   		goto error;
>> +	}
>>   
>>   	ret = amd_pmf_start_policy_engine(dev);
>>   	if (ret)
>>
> 
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 

Thanks for the patch!

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>