Received-SPF: pass (google.com: domain of linux-kernel+bounces-81726-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 26 Feb 2024 16:42:33 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: nikita.shubin@maquefel.me
Cc: Hartley Sweeten <hsweeten@visionengravers.com>,
	Alexander Sverdlin <alexander.sverdlin@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Damien Le Moal <dlemoal@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v8 23/38] input: keypad: ep93xx: add DT support for
 Cirrus EP93xx
Message-ID: <ZdyjWVwYRfASc38I@smile.fi.intel.com>
References: <20240226-ep93xx-v8-0-3136dca7238f@maquefel.me>
 <20240226-ep93xx-v8-23-3136dca7238f@maquefel.me>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240226-ep93xx-v8-23-3136dca7238f@maquefel.me>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Mon, Feb 26, 2024 at 10:30:19AM +0300, Nikita Shubin via B4 Relay wrote:
> From: Nikita Shubin <nikita.shubin@maquefel.me>
> 
> - drop flags, they were not used anyway
> - add OF ID match table
> - process "autorepeat", "debounce-delay-ms", prescale from device tree
> - drop platform data usage and it's header
> - keymap goes from device tree now on

..

>  struct ep93xx_keypad {
> -	struct ep93xx_keypad_platform_data *pdata;
>  	struct input_dev *input_dev;
>  	struct clk *clk;
> +	unsigned int	debounce;
> +	uint16_t	prescale;

In case you need to send a new version note that the indentation of the fields
is different here. Also uint16_t is not the type we expect to see usually
(does the file use it already?). In kernel we have u16.

>  	void __iomem *mmio_base;

-- 
With Best Regards,
Andy Shevchenko