Received-SPF: pass (google.com: domain of linux-kernel+bounces-81862-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 26 Feb 2024 17:04:58 +0100
From: Alexander Dahl <ada@thorsis.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: ojeda@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com,
	sebastian.hesselbarth@gmail.com, andy.shevchenko@gmail.com,
	geert@linux-m68k.org, pavel@ucw.cz, lee@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 0/3] auxdisplay: 7 segment LED display
Message-ID: <20240226-scabby-fiber-87d5d6e45028@thorsis.com>
Mail-Followup-To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
	ojeda@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	andrew@lunn.ch, gregory.clement@bootlin.com,
	sebastian.hesselbarth@gmail.com, andy.shevchenko@gmail.com,
	geert@linux-m68k.org, pavel@ucw.cz, lee@kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org
References: <20240225213423.690561-1-chris.packham@alliedtelesis.co.nz>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240225213423.690561-1-chris.packham@alliedtelesis.co.nz>
Precedence: bulk

Hello Chris,

Am Mon, Feb 26, 2024 at 10:34:20AM +1300 schrieb Chris Packham:
> This series adds a driver for a 7 segment LED display.
> 
> I'd like to get some feedback on how this could be extended to support >1
> character. The driver as presented is sufficient for my hardware which only has
> a single character display but I can see that for this to be generically useful
> supporting more characters would be desireable.
> 
> Earlier I posted an idea that the characters could be represended by
> sub-nodes[1] but there doesn't seem to be a way of having that and keeping the
> convenience of using devm_gpiod_get_array() (unless I've missed something).
> 
> [1] - https://lore.kernel.org/lkml/2a8d19ee-b18b-4b7c-869f-7d601cea30b6@alliedtelesis.co.nz/

Read that thread out of curiosity and I'm sorry if I'm late to the
party, but I wondered why this is limited to LEDs connected to GPIOs?

Would it be possible to somehow stack this on top of some existing
LEDs?  I mean you could wire a 7 segment device to almost any LED
driver IC with enough channels, couldn't you?

Greets
Alex

> 
> Chris Packham (3):
>   auxdisplay: Add 7 segment LED display driver
>   dt-bindings: auxdisplay: Add bindings for generic 7 segment LED
>   ARM: dts: marvell: Add 7 segment LED display on x530
> 
>  .../auxdisplay/generic,gpio-7seg.yaml         |  40 +++++
>  .../boot/dts/marvell/armada-385-atl-x530.dts  |  13 +-
>  drivers/auxdisplay/Kconfig                    |   7 +
>  drivers/auxdisplay/Makefile                   |   1 +
>  drivers/auxdisplay/seg-led.c                  | 152 ++++++++++++++++++
>  5 files changed, 212 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/auxdisplay/generic,gpio-7seg.yaml
>  create mode 100644 drivers/auxdisplay/seg-led.c
> 
> -- 
> 2.43.2
> 
>