Received-SPF: pass (google.com: domain of linux-kernel+bounces-81804-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240219170337.2161754-1-andriy.shevchenko@linux.intel.com> <20240219170337.2161754-2-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20240219170337.2161754-2-andriy.shevchenko@linux.intel.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 26 Feb 2024 16:28:20 +0100
Message-ID: <CAMuHMdVv==58uen8nukLDB9ADCvJJFYTb2bZSAcFKQ0wUmqL9w@mail.gmail.com>
Subject: Re: [PATCH v3 1/9] auxdisplay: linedisp: Group display drivers together
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Andy Shevchenko <andy@kernel.org>, 
	Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Robin van der Gracht <robin@protonic.nl>, Paul Burton <paulburton@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andy,

On Mon, Feb 19, 2024 at 6:03=E2=80=AFPM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> For better usability group the display drivers together in Kconfig
> and Makefile. With this we will have the following sections:
>   - Character LCD
>   - Samsung KS0108 LCD controller
>   - Single character line display
>   - Character LCD with non-conforming interface
>
> While at it, drop redundant 'default n' entries.
>
> Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for your patch!

> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig

> +#
> +# Single character line display section
> +#
> +config LINEDISP
> +       tristate "Character line display core support" if COMPILE_TEST
> +       help
> +         This is the core support for single-line character displays, to=
 be
> +         selected by drivers that use it.
> +
> +config IMG_ASCII_LCD
> +       tristate "Imagination Technologies ASCII LCD Display"
> +       depends on HAS_IOMEM
> +       default y if MIPS_MALTA
> +       select MFD_SYSCON
> +       select LINEDISP
> +       help
> +         Enable this to support the simple ASCII LCD displays found on
> +         development boards such as the MIPS Boston, MIPS Malta & MIPS S=
EAD3
> +         from Imagination Technologies.
> +
> +config HT16K33
> +       tristate "Holtek Ht16K33 LED controller with keyscan"

HT16K33 also supports dot-matrix displays using fbdev...
Yes, categorizing is difficult.

> --- a/drivers/auxdisplay/Makefile
> +++ b/drivers/auxdisplay/Makefile
> @@ -5,12 +5,15 @@
>
>  obj-$(CONFIG_CHARLCD)          +=3D charlcd.o
>  obj-$(CONFIG_HD44780_COMMON)   +=3D hd44780_common.o
> -obj-$(CONFIG_ARM_CHARLCD)      +=3D arm-charlcd.o
> +obj-$(CONFIG_HD44780)          +=3D hd44780.o
> +obj-$(CONFIG_LCD2S)            +=3D lcd2s.o
> +obj-$(CONFIG_PARPORT_PANEL)    +=3D panel.o
> +
>  obj-$(CONFIG_KS0108)           +=3D ks0108.o
>  obj-$(CONFIG_CFAG12864B)       +=3D cfag12864b.o cfag12864bfb.o
> -obj-$(CONFIG_IMG_ASCII_LCD)    +=3D img-ascii-lcd.o
> -obj-$(CONFIG_HD44780)          +=3D hd44780.o
> -obj-$(CONFIG_HT16K33)          +=3D ht16k33.o
> -obj-$(CONFIG_PARPORT_PANEL)    +=3D panel.o
> -obj-$(CONFIG_LCD2S)            +=3D lcd2s.o
> +
>  obj-$(CONFIG_LINEDISP)         +=3D line-display.o
> +obj-$(CONFIG_IMG_ASCII_LCD)    +=3D img-ascii-lcd.o
> +obj-$(CONFIG_HT16K33)          +=3D ht16k33.o
> +
> +obj-$(CONFIG_ARM_CHARLCD)      +=3D arm-charlcd.o

I still think these should be sorted alphabetically.

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds