Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1408506rbb; Mon, 26 Feb 2024 08:21:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUy4w4jyNAhxM+jC+TUrOFGVJVhypGzq1ThmkDplqxd9jEIl+fIHN5/66Nop+ulWfK7lSgB08ovoPcorzorGEAN44FzyeHw4gzRR4ENAA== X-Google-Smtp-Source: AGHT+IGfbeJKEh9HArySICNDxFqTj0IfZhuNGOZOwCuKh7/q0uyubJQRDplRNxESf7CxEwD8angT X-Received: by 2002:a05:6a20:ce49:b0:19c:6a60:b433 with SMTP id id9-20020a056a20ce4900b0019c6a60b433mr7675055pzb.3.1708964468841; Mon, 26 Feb 2024 08:21:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708964468; cv=pass; d=google.com; s=arc-20160816; b=IeDEksBH1X1zSvdxOGGff2JqnsoSWt9ny3Zseoo9pl8MdMj9Tz1zoqQNnoQDJEvHQF iFb7EfD/AYYZEFdmHCslp63A3anon8orkWGa06yEuK3ypI28ELQgRZME7IXy+asuIIyp EjoMpZHGl0shaET3vWcen0URFLL+Ls8w0nEu0JSwqvm+h65AAckl0rPclhW9hrlcfRpt dg/B2MxLnrAlQDYbJ6g7bZf4PPgK1hlTo2tcvKDPory3hyjcaQeTUFVrzFPYm39ZNO+f cYkC1WdSPQt3J3BobYMj5pzVN+NbN1z+HsyOpX3IO83+Zsi9IK/Xq6Omk/G7dOXatosr EHqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VQ6ZSxatzFmn25+yzQDmr+s/5uD5itV+q5l/DZTxHwI=; fh=WvdC4VroxRaHMG5vy8339F7nlKBpB0N8o4XnTSSt2G0=; b=L/mSNh77zHD1IpLhjXbtxQibTLFfgPD7fN9MCAukLps396sIgq48eChVSqKd0eliW/ ARLChR9eR/liF9/hXGyC9Bn+CXLD8JHwH2VTrPbyf8Fp7u47CCls4pZNMgqYZo4MYJ2d TXlXBHIeYqd01W34tld9TKwtSNbqGDEMdRIRzGBaeuoyEGBMIo/L5LcpiaoJDUfoMJzj 6rFLkhT8Rgy0EzwfNVRx7s7xtGkOObPiHefC4O5pte0cak+Ce9JuHon20eaBLO5UI7qu xhLnZNhJaTYsDTVC+bgjUMg6OyHAqMHIHgCD0i9D0KmvO9mCLh8K22j0dZ86Hzv6MfAY XR0A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KD6zZoZg; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-81829-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id v184-20020a6389c1000000b005dc8b2148ccsi3880365pgd.836.2024.02.26.08.21.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 08:21:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-81829-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KD6zZoZg; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-81829-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-81829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BF222B2F08E for ; Mon, 26 Feb 2024 15:44:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6E23912BF03; Mon, 26 Feb 2024 15:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="KD6zZoZg" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8A3C12AAE5; Mon, 26 Feb 2024 15:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708962239; cv=none; b=NtOMSoNFwR7+XoevLuhr3b0MQoObjXnVHDeSCSlUg4cZUtyZ8S+FDM4o1tm/sMYzNH9/mILJNxi87XO4MDDNQjkF9eDdEcrx2Q9yB4S0YqA4AUN0uPR4cLi47uiJ/tamxACTu2M+LMwnGu75jCBHElIar03cq9kVsBjzRRNnWmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708962239; c=relaxed/simple; bh=A01BNmVP9A1tmR3VtlSByNSQsi8R6HrQkgjno3xZJLs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gu5d/1H+doX7zRGeaBdZp7oJK7UJ9p39ZXzxytjovadEaXmdXnsIc/QwjiZxkKSgupzvH64lprGpeDWmekt1NCTjJ9b05xSLK+Cf8XWfZ83jf5ooWdVxCL+N9dCkr8YxpSWPvbFDOzDFEumoW8JpKYsUvOgv4hy/jMJn79HRDUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=KD6zZoZg; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=VQ6ZSxatzFmn25+yzQDmr+s/5uD5itV+q5l/DZTxHwI=; b=KD6zZoZgvnLZUnuYQ6vfPvEv0x NkfDIfPm42C8wJTy/gC4AEFjeVv9Mpa6TDw3lgLpKSb8ZoiDbCPoQJ3g/WZyap/7vtjJbf79DSbqv H0lpUuKbvBUIE3upA4C6MhLt8aaUvEIpz9PqwOel9giPa49lg4oVkXkoFhNQ39u068KQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1red9A-008jol-KK; Mon, 26 Feb 2024 16:44:04 +0100 Date: Mon, 26 Feb 2024 16:44:04 +0100 From: Andrew Lunn To: Catalin Popescu Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bsp-development.geo@leica-geosystems.com, m.felsch@pengutronix.de Subject: Re: [PATCH] net: phy: dp83826: disable WOL at init Message-ID: <0fca6571-39ee-47de-94bc-1bf9749192b1@lunn.ch> References: <20240223143127.1942129-1-catalin.popescu@leica-geosystems.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223143127.1942129-1-catalin.popescu@leica-geosystems.com> On Fri, Feb 23, 2024 at 03:31:27PM +0100, Catalin Popescu wrote: > Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning") > introduced a regression in that WOL is not disabled by default for DP83826. > WOL should normally be enabled through ethtool. > > Signed-off-by: Catalin Popescu d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning") is only in net-next? So you should set the patch subject to net-next. See: https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#netdev-faq Please also add a Fixes tag. The change itself looks O.K. Andrew