Received-SPF: pass (google.com: domain of linux-kernel+bounces-81755-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 26 Feb 2024 17:01:15 +0200 (EET)
To: "David E. Box" <david.e.box@linux.intel.com>
cc: rajvi.jingar@linux.intel.com, platform-driver-x86@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 3/3] platform/x86/intel/pmc/arl: Put GNA device in D3
In-Reply-To: <20240221211204.515159-3-david.e.box@linux.intel.com>
Message-ID: <62a64727-5732-ace0-2a29-f5d883c6e370@linux.intel.com>
References: <20240221211204.515159-1-david.e.box@linux.intel.com> <20240221211204.515159-3-david.e.box@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-988846203-1708959675=:1203"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-988846203-1708959675=:1203
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Wed, 21 Feb 2024, David E. Box wrote:

> To unblock Package C state entry, put the GNA device in D3 by default if =
no

Hi David,

It would be nice if this kind of not so well-known acronyms are opened by=
=20
default in the commit message so reviewers have a chance to understand=20
what this is about (me included, I had to look it up).

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

> driver is loaded for it.
>=20
> Fixes: 83f168a1a437 ("platform/x86/intel/pmc: Add Arrow Lake S support to=
 intel_pmc_core driver")
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
>  drivers/platform/x86/intel/pmc/arl.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/platform/x86/intel/pmc/arl.c b/drivers/platform/x86/=
intel/pmc/arl.c
> index 683ae828276b..34b4cd23bfe5 100644
> --- a/drivers/platform/x86/intel/pmc/arl.c
> +++ b/drivers/platform/x86/intel/pmc/arl.c
> @@ -673,6 +673,7 @@ static struct pmc_info arl_pmc_info_list[] =3D {
>  };
> =20
>  #define ARL_NPU_PCI_DEV=09=09=090xad1d
> +#define ARL_GNA_PCI_DEV=09=09=090xae4c
>  /*
>   * Set power state of select devices that do not have drivers to D3
>   * so that they do not block Package C entry.
> @@ -680,6 +681,7 @@ static struct pmc_info arl_pmc_info_list[] =3D {
>  static void arl_d3_fixup(void)
>  {
>  =09pmc_core_set_device_d3(ARL_NPU_PCI_DEV);
> +=09pmc_core_set_device_d3(ARL_GNA_PCI_DEV);
>  }
> =20
>  static int arl_resume(struct pmc_dev *pmcdev)

--8323328-988846203-1708959675=:1203--