Received-SPF: pass (google.com: domain of linux-kernel+bounces-81910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b86a2c0c-72a6-4b14-92f6-523da8291631@arm.com>
Date: Mon, 26 Feb 2024 16:29:36 +0000
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] OPP: Extend dev_pm_opp_data with turbo support
Content-Language: en-US
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org,
 morten.rasmussen@arm.com, viresh.kumar@linaro.org, rafael@kernel.org,
 cristian.marussi@arm.com, sudeep.holla@arm.com, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org, quic_mdtipton@quicinc.com,
 linux-arm-msm@vger.kernel.org, nm@ti.com, dietmar.eggemann@arm.com
References: <20240117110443.2060704-1-quic_sibis@quicinc.com>
 <20240117110443.2060704-2-quic_sibis@quicinc.com>
From: Lukasz Luba <lukasz.luba@arm.com>
In-Reply-To: <20240117110443.2060704-2-quic_sibis@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 1/17/24 11:04, Sibi Sankar wrote:
> Let's extend the dev_pm_opp_data with a turbo variable, to allow users to
> specify if it's a boost frequency for a dynamically added OPP.
> 
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>   drivers/opp/core.c     | 1 +
>   include/linux/pm_opp.h | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index c4e0432ae42a..e233734b7220 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -2065,6 +2065,7 @@ int _opp_add_v1(struct opp_table *opp_table, struct device *dev,
>   	/* populate the opp table */
>   	new_opp->rates[0] = data->freq;
>   	new_opp->level = data->level;
> +	new_opp->turbo = data->turbo;
>   	tol = u_volt * opp_table->voltage_tolerance_v1 / 100;
>   	new_opp->supplies[0].u_volt = u_volt;
>   	new_opp->supplies[0].u_volt_min = u_volt - tol;
> diff --git a/include/linux/pm_opp.h b/include/linux/pm_opp.h
> index 76dcb7f37bcd..a08a1fb1ca2a 100644
> --- a/include/linux/pm_opp.h
> +++ b/include/linux/pm_opp.h
> @@ -93,6 +93,7 @@ struct dev_pm_opp_config {
>    * @u_volt: The voltage in uV for the OPP.
>    */
>   struct dev_pm_opp_data {
> +	bool turbo;

Please add description of that new field, like other
fields in the comment above.

>   	unsigned int level;
>   	unsigned long freq;
>   	unsigned long u_volt;