Received-SPF: pass (google.com: domain of linux-kernel+bounces-81901-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 26 Feb 2024 16:24:47 +0000
From: Conor Dooley <conor@kernel.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: haibo.chen@nxp.com, jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt
Message-ID: <20240226-germinate-anymore-fb85ca9bb226@spud>
References: <20240226130826.3824251-1-peng.fan@oss.nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="KDf/GB9r/eUFTniC"
Content-Disposition: inline
In-Reply-To: <20240226130826.3824251-1-peng.fan@oss.nxp.com>


--KDf/GB9r/eUFTniC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>=20
> Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268,
> so drop it.

Don't just remove it from the example, drop it from the binding too?
It does permit a 4th "self testing" interrupt.

Thanks,
Conor.

>=20
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml=
 b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> index dacc526dc695..dfc3f512918f 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
> @@ -31,7 +31,6 @@ properties:
>        - description: normal conversion, include EOC (End of Conversion),
>            ECH (End of Chain), JEOC (End of Injected Conversion) and
>            JECH (End of injected Chain).
> -      - description: Self-testing Interrupts.
> =20
>    clocks:
>      maxItems: 1
> @@ -70,8 +69,7 @@ examples:
>              reg =3D <0x44530000 0x10000>;
>              interrupts =3D <GIC_SPI 217 IRQ_TYPE_LEVEL_HIGH>,
>                           <GIC_SPI 218 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>,
> -                         <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +                         <GIC_SPI 219 IRQ_TYPE_LEVEL_HIGH>;
>              clocks =3D <&clk IMX93_CLK_ADC1_GATE>;
>              clock-names =3D "ipg";
>              vref-supply =3D <&reg_vref_1v8>;
> --=20
> 2.37.1
>=20

--KDf/GB9r/eUFTniC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZdy7TwAKCRB4tDGHoIJi
0jiBAP47uO3KUowK4k4Q2P4b5rgtZ/Y4YuZ79RpRL0Rb4+E1jAD/deGLacfUyxqF
xY7kk9/vNJWngdQW7RU/N6r/w/U/LgE=
=oLVV
-----END PGP SIGNATURE-----

--KDf/GB9r/eUFTniC--